This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.0.0] Remove reference assemblies from NetFx netstandard support package #23711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple tools in .NETFramework projects are attempting to load references for execution which fails for reference assemblies. To work better with these tools, don't use reference assemblies in the support package.
ericstj
added
the
* NO MERGE *
ericstj
changed the title
weshaggard
approved these changes
Aug 31, 2017
ericstj
removed
the
* NO MERGE *
|
@ericstj given that we don't stablize this package did you want to bump the patch version of it or keep it the same? |
Good call, I'll bump it for clarity. |
|
test Innerloop Windows_NT Debug x86 Build and Test |
|
@dotnet/dnceng do we have a issue with getting windows machines in CI currently? |
|
@weshaggard Yes, please see the outage mail. |
|
Merging without CI finishing because it was green before the last commit which was just a version bump. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple tools in .NETFramework projects are attempting to load references
for execution which fails for reference assemblies.
To work better with these tools, don't use reference assemblies in the support
package.
Note: this only fixes the problem in our support package, and this change will need to be ingested by SDK in order to work. We should also consider making a change to our standalone packages.
/cc @weshaggard
Related: dotnet/sdk#1522