Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyDescriptor - MemberDescriptor.Attributes (iteration 2) #26756

Merged
merged 2 commits into from Feb 8, 2018

Conversation

@k0st1x
Copy link
Contributor

commented Feb 1, 2018

Fixes #26600
PropertyDescriptor - MemberDescriptor.Attributes returns base attribute instead of ancestor's attribute

k0st1x added 2 commits Jan 31, 2018
@safern

This comment has been minimized.

Copy link
Member

commented Feb 2, 2018

@safern
safern approved these changes Feb 2, 2018
Copy link
Member

left a comment

LGTM.

@karelz karelz changed the title #26600 PropertyDescriptor - MemberDescriptor.Attributes (iteration 2) PropertyDescriptor - MemberDescriptor.Attributes (iteration 2) Feb 4, 2018

@karelz

This comment has been minimized.

Copy link
Member

commented Feb 4, 2018

BTW: You can add "Fixes #" into top post to trigger GitHub auto-closing feature upon merge - see details.

@k0st1x

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2018

@karelz thank you for guiding me.
This PR was reviewed, it passed the auto tests.
Is this enough to accept the changes?

@karelz

This comment has been minimized.

Copy link
Member

commented Feb 5, 2018

Area owners/experts (@safern @maryamariyan) will decide when to merge. Looks like @safern wanted another code review from @stephentoub

@k0st1x

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2018

i very much count on that issue will be closed in 2.1 release.
@stephentoub what can I do to facilitate issue closing as soon as possible?

@karelz

This comment has been minimized.

Copy link
Member

commented Feb 6, 2018

@k0st1x 2.1 has still some time to bake - few days is not going to make a difference. We do not need to rush it "ASAP".

@stephentoub stephentoub merged commit a4ab230 into dotnet:master Feb 8, 2018

14 checks passed

Alpine.3.6 x64 Debug Build Build finished.
Details
CROSS Check Build finished.
Details
Linux arm Release Build Build finished.
Details
Linux x64 Release Build Build finished.
Details
NETFX x86 Release Build Build finished.
Details
OSX x64 Debug Build Build finished.
Details
Packaging All Configurations x64 Debug Build Build finished.
Details
Tizen armel Debug Build Build finished.
Details
UWP CoreCLR x64 Debug Build Build finished.
Details
UWP NETNative x86 Release Build Build finished.
Details
WIP ready for review
Details
Windows x64 Debug Build Build finished.
Details
Windows x86 Release Build Build finished.
Details
license/cla All CLA requirements met.
Details

@karelz karelz added this to the 2.1.0 milestone Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.