New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brotli support to SocketsHttpHandler #29729

Merged
merged 2 commits into from May 17, 2018

Conversation

@stephentoub
Member

stephentoub commented May 15, 2018

  • Add DecompressionMethods.Brotli
  • Add support for Brotli to SocketsHttpHandler
  • Add some tests

Fixes #26995
cc: @ianhays, @joshfree, @geoffkizer, @davidsh

@joshfree

This comment has been minimized.

Show comment
Hide comment
@joshfree

joshfree May 15, 2018

Member

Thanks @stephentoub

related asp.net issue aspnet/BasicMiddleware#217

Member

joshfree commented May 15, 2018

Thanks @stephentoub

related asp.net issue aspnet/BasicMiddleware#217

stephentoub added some commits May 15, 2018

Add Brotli support to SocketsHttpHandler
- Add DecompressionMethods.Brotli
- Add support for Brotli to SocketsHttpHandler
- Add some tests
@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub May 16, 2018

Member

@dotnet-bot test Windows x64 Debug Build please (lots of unrelated failures on the Nano server leg... looks like the system is in a bad state)

Member

stephentoub commented May 16, 2018

@dotnet-bot test Windows x64 Debug Build please (lots of unrelated failures on the Nano server leg... looks like the system is in a bad state)

@stephentoub stephentoub merged commit 91f2cd7 into dotnet:master May 17, 2018

13 of 14 checks passed

Windows x64 Debug Build Build finished.
Details
CROSS Check Build finished.
Details
Linux arm Release Build Build finished.
Details
Linux arm64 Release Build Build finished.
Details
Linux x64 Release Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
NETFX x86 Release Build Build finished.
Details
OSX x64 Debug Build Build finished.
Details
Packaging All Configurations x64 Debug Build Build finished.
Details
UWP CoreCLR x64 Debug Build Build finished.
Details
UWP NETNative x86 Release Build Build finished.
Details
WIP ready for review
Details
Windows x86 Release Build Build finished.
Details
license/cla All CLA requirements met.
Details

@stephentoub stephentoub deleted the stephentoub:brotlihttp branch May 17, 2018

hughbe added a commit to hughbe/corefx that referenced this pull request May 29, 2018

Add Brotli support to SocketsHttpHandler (dotnet#29729)
* Add Brotli support to SocketsHttpHandler

- Add DecompressionMethods.Brotli
- Add support for Brotli to SocketsHttpHandler
- Add some tests

* Address PR feedback

satano added a commit to satano/corefx that referenced this pull request May 30, 2018

Add Brotli support to SocketsHttpHandler (dotnet#29729)
* Add Brotli support to SocketsHttpHandler

- Add DecompressionMethods.Brotli
- Add support for Brotli to SocketsHttpHandler
- Add some tests

* Address PR feedback

@karelz karelz added this to the 3.0 milestone Jun 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment