Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Change EnsureSuccessStatusCode to not dispose response content #29795
Historically, this method has always disposed the response content if it was
The use case of #26684 is that the response content should be available regardless
May 19, 2018
13 of 14 checks passed
This PR was merged after the .NET Core 2.1 branch was finalized. So, the documentation is still correct.
However, starting after .NET Core 2.1, this sentence is no longer true. It should be removed at that time from the documentation:
I did not see the changes applied to 2.2 release: https://github.com/dotnet/corefx/blob/release/2.2/src/System.Net.Http/src/System/Net/Http/HttpResponseMessage.cs. Can anyone confirm if the comment by @davidsh is still valid?
It's a bit confusing, but coreclr and corefx have very few changes between 2.1 and 2.2, only critical fixes. Most changes that went into corefx after 2.1, including this one, will be in 3.0, which is the next major rev of the runtime and libraries. 2.2 was primarily about improvements to ASP.NET.