New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FEATURE_ETLEVENTS conditional compilation #30071

Merged
merged 2 commits into from Jun 2, 2018

Conversation

@laurentkempe
Copy link
Collaborator

laurentkempe commented Jun 2, 2018

Fixes #19624

@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Jun 2, 2018

CLA assistant check
All CLA requirements met.

@ViktorHofer

This comment has been minimized.

Copy link
Member

ViktorHofer commented Jun 2, 2018

@dotnet-bot test OSX x64 Debug Build

@laurentkempe

This comment has been minimized.

Copy link
Collaborator Author

laurentkempe commented Jun 2, 2018

@ViktorHofer Thx for the help

@ViktorHofer

This comment has been minimized.

Copy link
Member

ViktorHofer commented Jun 2, 2018

I pushed a commit to your PR to remove some obsolete constants and references here. cc @brianrob

@ViktorHofer ViktorHofer merged commit 45395bd into dotnet:master Jun 2, 2018

15 checks passed

CROSS Check Build finished.
Details
Linux arm Release Build Build finished.
Details
Linux arm64 Release Build Build finished.
Details
Linux x64 Release Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
NETFX x86 Release Build Build finished.
Details
OSX x64 Debug Build Build finished.
Details
Packaging All Configurations x64 Debug Build Build finished.
Details
Tizen armel Debug Build Build finished.
Details
UWP CoreCLR x64 Debug Build Build finished.
Details
UWP NETNative x86 Release Build Build finished.
Details
WIP ready for review
Details
Windows x64 Debug Build Build finished.
Details
Windows x86 Release Build Build finished.
Details
license/cla All CLA requirements met.
Details
@ViktorHofer

This comment has been minimized.

Copy link
Member

ViktorHofer commented Jun 2, 2018

Thanks a lot for your help @laurentkempe 👍

@laurentkempe laurentkempe deleted the laurentkempe:remove-conditial-compilation-in-System.Diagnostics.Tracing branch Jun 2, 2018

@karelz karelz added the Hackathon label Jun 2, 2018

@karelz karelz added this to the 3.0 milestone Jun 2, 2018

@brianrob

This comment has been minimized.

Copy link
Member

brianrob commented Jun 5, 2018

Thanks very much @laurentkempe and @ViktorHofer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment