Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add test to ensure FromBase64 bug doesn't regress. - #30814

Merged
stephentoub merged 1 commit into
masterfrom
unknown repository
Jul 3, 2018
Merged

stephentoub merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 3, 2018

Copy link
Copy Markdown

Convert.FromBase64() had a subtle bug where an illicit
second padding character at the end of the string caused
the decode to "succeed" by dropping the fifth to
last character.

We inadvertently fixed this bug while optimizing that
api in .NetCore 2.1. Adding test to document bug and
ensure we don't regress.

Details in https://github.com/dotnet/corefx/issues/30793

Convert.FromBase64() had a subtle bug where an illicit
second padding character at the end of the string caused
the decode to "succeed" by dropping the fifth to
last character.

We inadvertently fixed this bug while optimizing that
api in .NetCore 2.1. Adding test to document bug and
ensure we don't regress.

Details in https://github.com/dotnet/corefx/issues/30793
@ghost ghost self-assigned this Jul 3, 2018
@stephentoub

Copy link
Copy Markdown
Member

We inadvertently fixed this bug while optimizing that api in .NetCore 2.1.

It's such a nice feeling when that happens; usually it's the opposite :)

@stephentoub

Copy link
Copy Markdown
Member

Thanks

@ghost

ghost commented Jul 3, 2018

Copy link
Copy Markdown
Author

@dotnet-bot test Packaging All Configurations x64 Debug Build

@stephentoub
stephentoub merged commit f1065c7 into dotnet:master Jul 3, 2018
@ghost
ghost deleted the base64 branch July 3, 2018 17:22
@karelz karelz modified the milestones: Future, 3.0 Jul 8, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Convert.FromBase64() had a subtle bug where an illicit
second padding character at the end of the string caused
the decode to "succeed" by dropping the fifth to
last character.

We inadvertently fixed this bug while optimizing that
api in .NetCore 2.1. Adding test to document bug and
ensure we don't regress.

Details in https://github.com/dotnet/corefx/issues/30793

Commit migrated from dotnet/corefx@f1065c7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants