This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add test to ensure FromBase64 bug doesn't regress. #30814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert.FromBase64() had a subtle bug where an illicit second padding character at the end of the string caused the decode to "succeed" by dropping the fifth to last character. We inadvertently fixed this bug while optimizing that api in .NetCore 2.1. Adding test to document bug and ensure we don't regress. Details in https://github.com/dotnet/corefx/issues/30793
ghost
self-assigned this
It's such a nice feeling when that happens; usually it's the opposite :) |
stephentoub
approved these changes
Jul 3, 2018
|
Thanks |
|
@dotnet-bot test Packaging All Configurations x64 Debug Build |
ghost
deleted the
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Convert.FromBase64() had a subtle bug where an illicit second padding character at the end of the string caused the decode to "succeed" by dropping the fifth to last character. We inadvertently fixed this bug while optimizing that api in .NetCore 2.1. Adding test to document bug and ensure we don't regress. Details in https://github.com/dotnet/corefx/issues/30793 Commit migrated from dotnet/corefx@f1065c7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert.FromBase64() had a subtle bug where an illicit
second padding character at the end of the string caused
the decode to "succeed" by dropping the fifth to
last character.
We inadvertently fixed this bug while optimizing that
api in .NetCore 2.1. Adding test to document bug and
ensure we don't regress.
Details in https://github.com/dotnet/corefx/issues/30793