This fixes the following test failure (on my de-CH machine)
After the change the build succeeds.
Fix vector tests to work on non en-US culture machines
LGTM. running this through our CI
Is that officially the first community pull request? If yes, will that be the first ACCEPTED community pull request? 👍
Awesome - thank you!
Great catch, thanks for submitting this. I believe there is an analogous test in Vector4Tests.cs that needs to be changed, as well (it also tests this same case for Vector4).
@adamralph I was hoping this would be a "Remove all regions" troll PR. Much disappoint.
Haha awesome! First Accepted PR 👍
@mellinoe that test was using the wrong variable for assertion which is why it was passing. I've fixed it in another PR #32
Fuck yeah @adamralph
💥 Immortalised yourself here @adamralph 👍
Awesome you are the first
Holy shit - it happened 🙈🙏
Congrats @adamralph. Let's drink on it next week!
@dennisdoomen looking forward to that!
Yes. Yes. Yes.
On my god.... it was the first community PR accepted, built, unit tested and stamped by Microsoft!
That didn't take long!
This is amazing! OSS works!
This is HUGE!! Awesome!
Woot @adamralph - You the man!! That's at least two beers for you next week! (@ buildstuff.lt)
Nice job @adamralph!
No freaking way... give that man a Surface Pro 3 & XBOX One!
I think thus fits the bill for:
Eh @andrewconnell ?
So great 👍
Nicely done @adamralph :-)
@adamralph Simply awesome, you just earned your spot in history buddy. Can I name drop and say @adamralph was my team mate! :-)
Fuck yeah? Fuck yeahhhh!!!!!!!!!!11
Awesome @adamralph 💯
Great to see Microsoft embracing open-source completely, this is fantastic! Great job getting things started @adamralph!
@adamralph man, you did it... Thanks and Thanks to team dot net for all this OSS work. +1
Never thought I would see the day.
Nice! Well done!
This is historical! 😃
Couldn't resist, LGTM!