Fix vector tests to work on non en-US culture machines #31

Merged
merged 1 commit into from Nov 12, 2014

Projects

None yet
@adamralph
Contributor

This fixes the following test failure (on my de-CH machine)

image

After the change the build succeeds.

@luisrudge

๐Ÿ‘

@joshfree
Member

LGTM. running this through our CI

@MaximRouiller

Is that officially the first community pull request? If yes, will that be the first ACCEPTED community pull request? ๐Ÿ‘

@nguerrera
Member
@gaearon
gaearon commented Nov 12, 2014

๐Ÿ‘

@FiveTimesTheFun
Contributor

Awesome - thank you!

@mellinoe
Member

Great catch, thanks for submitting this. I believe there is an analogous test in Vector4Tests.cs that needs to be changed, as well (it also tests this same case for Vector4).

๐Ÿ‘

@damianh
damianh commented Nov 12, 2014

@adamralph I was hoping this would be a "Remove all regions" troll PR. Much disappoint.

@dotnet-bot dotnet-bot merged commit 5ec20d0 into dotnet:master Nov 12, 2014
@adamralph adamralph deleted the adamralph:fix-tests branch Nov 12, 2014
@davepermen

๐Ÿ‘ congratulations

@pgermishuys

congrats!

@shanselman

Woot

@alfhenrik

Awesome dude!

@Stephanvs

Haha awesome! First Accepted PR ๐Ÿ‘

@adamralph
Contributor

@mellinoe that test was using the wrong variable for assertion which is why it was passing. I've fixed it in another PR #32

@jeffdoolittle

๐Ÿ‘

@paulcbetts

Fuck yeah @adamralph

@TheSoftwareDev

๐Ÿ‘

@Mpdreamz

๐Ÿ’ฅ Immortalised yourself here @adamralph ๐Ÿ‘

@juanfranblanco

Awesome you are the first

@charleslbryant

Sweet

@tiagobabo

๐Ÿ‘

@tugberkugurlu

๐Ÿ’ฅ ๐ŸŽ†

@ciriarte

๐Ÿ‘ fantastic!

@erinpagemd

๐Ÿ‘

@AlexZeitler

Holy shit - it happened ๐Ÿ™ˆ๐Ÿ™

@Haacked
Haacked commented Nov 12, 2014

selfie-0

@dennisdoomen

Congrats @adamralph. Let's drink on it next week!

@adamralph
Contributor

@dennisdoomen looking forward to that!

@dsyme
dsyme commented Nov 12, 2014

Yes. Yes. Yes.

@MaximRouiller

On my god.... it was the first community PR accepted, built, unit tested and stamped by Microsoft!

๐Ÿ˜ฎ

@keithelder

That didn't take long!

@plaurin
plaurin commented Nov 12, 2014

This is amazing! OSS works!

@caioproiete

This is HUGE!! Awesome!

@sikanderiqbal

History!

@shiftkey

Obligatory:

@giggio
giggio commented Nov 12, 2014

Just awesome!

@DavidChristiansen

Woot @adamralph - You the man!! That's at least two beers for you next week! (@ buildstuff.lt)

@glennblock

Nice job @adamralph!

@khellang
Contributor

Yay! ๐Ÿ˜๐Ÿ‘

Yay

@andrewconnell

No freaking way... give that man a Surface Pro 3 & XBOX One!

xhwl9dq

No more...

@georgeracu

๐Ÿ‘

@jbuiss0n

Awesome !

@rylancates

So great ๐Ÿ‘

@Zimmergren

Nicely done @adamralph :-)

@ezechibritton

@adamralph Simply awesome, you just earned your spot in history buddy. Can I name drop and say @adamralph was my team mate! :-)

@odiszapc

Fuck yeah? Fuck yeahhhh!!!!!!!!!!11

@gy
gy commented Nov 21, 2014

Awesome @adamralph ๐Ÿ’ฏ

@manigandham

Great to see Microsoft embracing open-source completely, this is fantastic! Great job getting things started @adamralph!

@kunjee17

@adamralph man, you did it... Thanks and Thanks to team dot net for all this OSS work. +1

@phillip-haydon

image

image

image

Never thought I would see the day.

@henriksen

Nice! Well done!

@vidyavardhan

๐Ÿ‘

@fagnercarvalho

This is historical! ๐Ÿ˜ƒ

@cyberid41

Congratulations ๐Ÿ‘

@AnthonyDGreen

Couldn't resist, LGTM!
#NDCOslo

@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment