Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix vector tests to work on non en-US culture machines - #31

Merged
dotnet-bot merged 1 commit into
dotnet:masterfrom
adamralph:fix-tests
Nov 12, 2014
Merged

Fix vector tests to work on non en-US culture machines#31
dotnet-bot merged 1 commit into
dotnet:masterfrom
adamralph:fix-tests

Conversation

@adamralph

@adamralph adamralph commented Nov 12, 2014

Copy link
Copy Markdown
Contributor

This fixes the following test failure (on my de-CH machine)

image

After the change the build succeeds.

@joshfree

joshfree commented Nov 12, 2014

Copy link
Copy Markdown
Member

LGTM. running this through our CI

@MaximRouiller

MaximRouiller commented Nov 12, 2014

Copy link
Copy Markdown

Is that officially the first community pull request? If yes, will that be the first ACCEPTED community pull request? 👍

@nguerrera

nguerrera commented Nov 12, 2014

Copy link
Copy Markdown
Contributor

@MaximRouiller Yes.

@gaearon

gaearon commented Nov 12, 2014

Copy link
Copy Markdown

👍

@FiveTimesTheFun

FiveTimesTheFun commented Nov 12, 2014

Copy link
Copy Markdown
Contributor

Awesome - thank you!

@mellinoe

mellinoe commented Nov 12, 2014

Copy link
Copy Markdown
Contributor

Great catch, thanks for submitting this. I believe there is an analogous test in Vector4Tests.cs that needs to be changed, as well (it also tests this same case for Vector4).

👍

@damianh

damianh commented Nov 12, 2014

Copy link
Copy Markdown

@adamralph I was hoping this would be a "Remove all regions" troll PR. Much disappoint.

@dotnet-bot
dotnet-bot merged commit 5ec20d0 into dotnet:master Nov 12, 2014
@adamralph
adamralph deleted the fix-tests branch November 12, 2014 16:49
@davepermen

davepermen commented Nov 12, 2014

Copy link
Copy Markdown

👍 congratulations

@pgermishuys

pgermishuys commented Nov 12, 2014

Copy link
Copy Markdown

congrats!

@shanselman

shanselman commented Nov 12, 2014

Copy link
Copy Markdown

Woot

@hnrkndrssn

hnrkndrssn commented Nov 12, 2014

Copy link
Copy Markdown

Awesome dude!

@Stephanvs

Stephanvs commented Nov 12, 2014

Copy link
Copy Markdown

Haha awesome! First Accepted PR 👍

@adamralph

adamralph commented Nov 12, 2014

Copy link
Copy Markdown
Contributor Author

@mellinoe that test was using the wrong variable for assertion which is why it was passing. I've fixed it in another PR #32

@DamianEdwards

DamianEdwards commented Nov 12, 2014

Copy link
Copy Markdown
Member

:shipit:

@jeffdoolittle

jeffdoolittle commented Nov 12, 2014

Copy link
Copy Markdown

👍

@anaisbetts

anaisbetts commented Nov 12, 2014

Copy link
Copy Markdown

Fuck yeah @adamralph

@NickMOrlando

NickMOrlando commented Nov 12, 2014

Copy link
Copy Markdown

👍

@Mpdreamz

Mpdreamz commented Nov 12, 2014

Copy link
Copy Markdown
Contributor

💥 Immortalised yourself here @adamralph 👍

@juanfranblanco

juanfranblanco commented Nov 12, 2014

Copy link
Copy Markdown

Awesome you are the first

@charleslbryant

charleslbryant commented Nov 12, 2014

Copy link
Copy Markdown

Sweet

@tiagobabo

tiagobabo commented Nov 12, 2014

Copy link
Copy Markdown

👍

@tugberkugurlu

tugberkugurlu commented Nov 12, 2014

Copy link
Copy Markdown

💥 🎆

@ciriarte

ciriarte commented Nov 12, 2014

Copy link
Copy Markdown

👍 fantastic!

@erinpagemd

erinpagemd commented Nov 12, 2014

Copy link
Copy Markdown

👍

@AlexZeitler

AlexZeitler commented Nov 12, 2014

Copy link
Copy Markdown

Holy shit - it happened 🙈🙏

@haacked

haacked commented Nov 12, 2014

Copy link
Copy Markdown

selfie-0

@dennisdoomen

dennisdoomen commented Nov 12, 2014

Copy link
Copy Markdown

Congrats @adamralph. Let's drink on it next week!

@DavidChristiansen

DavidChristiansen commented Nov 12, 2014

Copy link
Copy Markdown

Woot @adamralph - You the man!! That's at least two beers for you next week! (@ buildstuff.lt)

@glennblock

glennblock commented Nov 12, 2014

Copy link
Copy Markdown

Nice job @adamralph!

@khellang

khellang commented Nov 12, 2014

Copy link
Copy Markdown
Member

Yay! 😁👍

Yay

@andrewconnell

andrewconnell commented Nov 13, 2014

Copy link
Copy Markdown

No freaking way... give that man a Surface Pro 3 & XBOX One!

xhwl9dq

No more...

@SharePointing

SharePointing commented Nov 13, 2014

Copy link
Copy Markdown

I think thus fits the bill for:

http://m.youtube.com/watch?v=xjzzLelV0Y0

Eh @andrewconnell ?

@LoungeFlyZ

LoungeFlyZ commented Nov 13, 2014

Copy link
Copy Markdown

its-working-its-working

@VesaJuvonen

VesaJuvonen commented Nov 13, 2014

Copy link
Copy Markdown

change-is-inevitable

@georgeracu

georgeracu commented Nov 13, 2014

Copy link
Copy Markdown

👍

@jbuiss0n

jbuiss0n commented Nov 13, 2014

Copy link
Copy Markdown

Awesome !

@staticvoidmaine

staticvoidmaine commented Nov 13, 2014

Copy link
Copy Markdown

So great 👍

@Zimmergren

Zimmergren commented Nov 13, 2014

Copy link
Copy Markdown

Nicely done @adamralph :-)

@ezechibritton

ezechibritton commented Nov 15, 2014

Copy link
Copy Markdown

@adamralph Simply awesome, you just earned your spot in history buddy. Can I name drop and say @adamralph was my team mate! :-)

@odiszapc

odiszapc commented Nov 20, 2014

Copy link
Copy Markdown

Fuck yeah? Fuck yeahhhh!!!!!!!!!!11

@gy

gy commented Nov 21, 2014

Copy link
Copy Markdown

Awesome @adamralph 💯

@manigandham

manigandham commented Nov 21, 2014

Copy link
Copy Markdown

Great to see Microsoft embracing open-source completely, this is fantastic! Great job getting things started @adamralph!

@kunjee17

kunjee17 commented Nov 21, 2014

Copy link
Copy Markdown

@adamralph man, you did it... Thanks and Thanks to team dot net for all this OSS work. +1

@phillip-haydon

phillip-haydon commented Nov 21, 2014

Copy link
Copy Markdown

image

image

image

Never thought I would see the day.

@henriksen

henriksen commented Nov 22, 2014

Copy link
Copy Markdown

Nice! Well done!

@vidyavardhan

vidyavardhan commented Nov 22, 2014

Copy link
Copy Markdown

👍

@fagnercarvalho

fagnercarvalho commented Nov 23, 2014

Copy link
Copy Markdown

This is historical! 😃

@santosoide

santosoide commented Dec 1, 2014

Copy link
Copy Markdown

Congratulations 👍

@AnthonyDGreen

AnthonyDGreen commented Jun 18, 2015

Copy link
Copy Markdown

Couldn't resist, LGTM!
#NDCOslo

pgavlin added a commit to pgavlin/corefx that referenced this pull request Sep 22, 2015
@pgavlin
Merge pull request dotnet#31 from pgavlin/SocketsCleanup
3036ae0 
Clean up TCP{Client,Listener}.
sepidehkh added a commit to sepidehkh/corefx that referenced this pull request Feb 3, 2016
@sepidehkh
Merge pull request dotnet#31 from sepidehMS/XmlWithCliInProgress
a85a390 
Xml with cli in progress
@adamralph adamralph mentioned this pull request May 28, 2016
Merged
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
@FiveTimesTheFun FiveTimesTheFun mentioned this pull request Jan 31, 2020
Closed
@halter73 halter73 mentioned this pull request Feb 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rtm

Development

Successfully merging this pull request may close these issues.