Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector tests to work on non en-US culture machines #31

Merged
merged 1 commit into from Nov 12, 2014

Conversation

@adamralph
Copy link
Contributor

adamralph commented Nov 12, 2014

This fixes the following test failure (on my de-CH machine)

image

After the change the build succeeds.

@joshfree
Copy link
Member

joshfree commented Nov 12, 2014

LGTM. running this through our CI

@MaximRouiller
Copy link

MaximRouiller commented Nov 12, 2014

Is that officially the first community pull request? If yes, will that be the first ACCEPTED community pull request? 👍

@nguerrera
Copy link
Member

nguerrera commented Nov 12, 2014

@gaearon
Copy link

gaearon commented Nov 12, 2014

👍

@FiveTimesTheFun
Copy link
Contributor

FiveTimesTheFun commented Nov 12, 2014

Awesome - thank you!

@mellinoe
Copy link
Contributor

mellinoe commented Nov 12, 2014

Great catch, thanks for submitting this. I believe there is an analogous test in Vector4Tests.cs that needs to be changed, as well (it also tests this same case for Vector4).

👍

@damianh
Copy link

damianh commented Nov 12, 2014

@adamralph I was hoping this would be a "Remove all regions" troll PR. Much disappoint.

@dotnet-bot dotnet-bot merged commit 5ec20d0 into dotnet:master Nov 12, 2014
@adamralph adamralph deleted the adamralph:fix-tests branch Nov 12, 2014
@davepermen
Copy link

davepermen commented Nov 12, 2014

👍 congratulations

@pgermishuys
Copy link

pgermishuys commented Nov 12, 2014

congrats!

@shanselman
Copy link

shanselman commented Nov 12, 2014

Woot

@hnrkndrssn
Copy link

hnrkndrssn commented Nov 12, 2014

Awesome dude!

@Stephanvs
Copy link

Stephanvs commented Nov 12, 2014

Haha awesome! First Accepted PR 👍

@adamralph
Copy link
Contributor Author

adamralph commented Nov 12, 2014

@mellinoe that test was using the wrong variable for assertion which is why it was passing. I've fixed it in another PR #32

@DamianEdwards
Copy link

DamianEdwards commented Nov 12, 2014

:shipit:

@jeffdoolittle
Copy link

jeffdoolittle commented Nov 12, 2014

👍

@anaisbetts
Copy link

anaisbetts commented Nov 12, 2014

Fuck yeah @adamralph

@NickMOrlando
Copy link

NickMOrlando commented Nov 12, 2014

👍

@Mpdreamz
Copy link
Collaborator

Mpdreamz commented Nov 12, 2014

💥 Immortalised yourself here @adamralph 👍

@juanfranblanco
Copy link

juanfranblanco commented Nov 12, 2014

Awesome you are the first

@charleslbryant
Copy link

charleslbryant commented Nov 12, 2014

Sweet

@tiagobabo
Copy link

tiagobabo commented Nov 12, 2014

👍

@tugberkugurlu
Copy link

tugberkugurlu commented Nov 12, 2014

💥 🎆

@ciriarte
Copy link

ciriarte commented Nov 12, 2014

👍 fantastic!

@erinpagemd
Copy link

erinpagemd commented Nov 12, 2014

👍

@AlexZeitler
Copy link

AlexZeitler commented Nov 12, 2014

Holy shit - it happened 🙈🙏

@haacked
Copy link

haacked commented Nov 12, 2014

selfie-0

@dennisdoomen
Copy link

dennisdoomen commented Nov 12, 2014

Congrats @adamralph. Let's drink on it next week!

@DavidChristiansen
Copy link

DavidChristiansen commented Nov 12, 2014

Woot @adamralph - You the man!! That's at least two beers for you next week! (@ buildstuff.lt)

@glennblock
Copy link

glennblock commented Nov 12, 2014

Nice job @adamralph!

@khellang
Copy link
Collaborator

khellang commented Nov 12, 2014

Yay! 😁👍

Yay

@andrewconnell
Copy link

andrewconnell commented Nov 13, 2014

No freaking way... give that man a Surface Pro 3 & XBOX One!

xhwl9dq

No more...

@SharePointing
Copy link

SharePointing commented Nov 13, 2014

I think thus fits the bill for:

http://m.youtube.com/watch?v=xjzzLelV0Y0

Eh @andrewconnell ?

@LoungeFlyZ
Copy link

LoungeFlyZ commented Nov 13, 2014

its-working-its-working

@VesaJuvonen
Copy link

VesaJuvonen commented Nov 13, 2014

change-is-inevitable

@georgeracu
Copy link

georgeracu commented Nov 13, 2014

👍

@jbuiss0n
Copy link

jbuiss0n commented Nov 13, 2014

Awesome !

@staticvoidmaine
Copy link

staticvoidmaine commented Nov 13, 2014

So great 👍

@Zimmergren
Copy link

Zimmergren commented Nov 13, 2014

Nicely done @adamralph :-)

@ezechibritton
Copy link

ezechibritton commented Nov 15, 2014

@adamralph Simply awesome, you just earned your spot in history buddy. Can I name drop and say @adamralph was my team mate! :-)

@odiszapc
Copy link

odiszapc commented Nov 20, 2014

Fuck yeah? Fuck yeahhhh!!!!!!!!!!11

@gy
Copy link

gy commented Nov 21, 2014

Awesome @adamralph 💯

@manigandham
Copy link

manigandham commented Nov 21, 2014

Great to see Microsoft embracing open-source completely, this is fantastic! Great job getting things started @adamralph!

@kunjee17
Copy link

kunjee17 commented Nov 21, 2014

@adamralph man, you did it... Thanks and Thanks to team dot net for all this OSS work. +1

@phillip-haydon
Copy link

phillip-haydon commented Nov 21, 2014

image

image

image

Never thought I would see the day.

@henriksen
Copy link

henriksen commented Nov 22, 2014

Nice! Well done!

@vidyavardhan
Copy link

vidyavardhan commented Nov 22, 2014

👍

@fagnercarvalho
Copy link

fagnercarvalho commented Nov 23, 2014

This is historical! 😃

@santosoide
Copy link

santosoide commented Dec 1, 2014

Congratulations 👍

@AnthonyDGreen
Copy link

AnthonyDGreen commented Jun 18, 2015

Couldn't resist, LGTM!
#NDCOslo

pgavlin added a commit to pgavlin/corefx that referenced this pull request Sep 22, 2015
sepidehkh added a commit to sepidehkh/corefx that referenced this pull request Feb 3, 2016
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.