Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capture the ExecutionContext when registering for the cancellation #33235

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@davidfowl
Copy link
Contributor

commented Nov 4, 2018

Don't capture the ExecutionContext when registering for cancellation since we're invoking our own callback.

@davidfowl davidfowl requested a review from pakrym Nov 4, 2018

@@ -3,7 +3,7 @@
<PropertyGroup>
<PackageConfigurations>
netstandard;
netcoreapp2.1;
netcoreapp;

This comment has been minimized.

Copy link
@davidfowl

davidfowl Nov 4, 2018

Author Contributor

This also drops 2.1 support, I can bring it back if that matters. The only difference is the allocation profile for the ThreadPoolScheduler.

@davidfowl

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

The windows build hung for 7 hours 😄

@davidfowl

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

@dotnet-bot test Windows x86 Release Build
@dotnet-bot test Windows x64 Debug Build

@davidfowl

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

@dotnet-bot test Linux x64 Release Build

@davidfowl

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

I assume windows is just dead.

@stephentoub

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

I assume windows is just dead.

The Windows 7 VMs have been having trouble all weekend.
@dotnet/dnceng

@MattGal

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

@stephentoub I am taking corrective action presently, my apologies for the inconvenience. Root cause analysis and fix status will be in dotnet/core-eng#4551

@MattGal

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

Windows 7 processing has caught up to real time now. We'll continue to track this issue until we find and fix the underlying cause.

@stephentoub

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

@dotnet-bot test this please

@davidfowl davidfowl merged commit 4e6418b into master Nov 6, 2018

14 checks passed

Linux arm Release Build Build finished.
Details
Linux arm64 Release Build Build finished.
Details
Linux x64 Release Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
NETFX x86 Release Build Build finished.
Details
OSX x64 Debug Build Build finished.
Details
Packaging All Configurations x64 Debug Build Build finished.
Details
Tizen armel Debug Build Build finished.
Details
UWP CoreCLR x64 Debug Build Build finished.
Details
UWP NETNative x86 Release Build Build finished.
Details
WIP Ready for review
Details
Windows x64 Debug Build Build finished.
Details
Windows x86 Release Build Build finished.
Details
license/cla All CLA requirements met.
Details

@weshaggard weshaggard deleted the davidfowl/unsafe-register branch Nov 6, 2018

@karelz karelz added this to the 3.0 milestone Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.