Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parsing tests to validate we consider enough significant digits to always round correctly. #35701

Merged
merged 1 commit into from Mar 1, 2019

Conversation

@tannergooding
Copy link
Member

commented Mar 1, 2019

This adds explicit tests for the double and floating-point strings with the most significant digits

@tannergooding tannergooding force-pushed the tannergooding:float-test branch from c017149 to 111f257 Mar 1, 2019

@tannergooding tannergooding merged commit 34118b7 into dotnet:master Mar 1, 2019

14 checks passed

WIP Ready for review
Details
corefx-ci Build #20190301.37 succeeded
Details
corefx-ci (Linux arm64_Release) Linux arm64_Release succeeded
Details
corefx-ci (Linux arm_Release) Linux arm_Release succeeded
Details
corefx-ci (Linux musl_x64_Debug) Linux musl_x64_Debug succeeded
Details
corefx-ci (Linux x64_Release) Linux x64_Release succeeded
Details
corefx-ci (Packaging All Configurations x64_Debug) Packaging All Configurations x64_Debug succeeded
Details
corefx-ci (Windows NETFX_x86_Release) Windows NETFX_x86_Release succeeded
Details
corefx-ci (Windows UWP_CoreCLR_x64_Debug) Windows UWP_CoreCLR_x64_Debug succeeded
Details
corefx-ci (Windows UWP_NETNative_x86_Release) Windows UWP_NETNative_x86_Release succeeded
Details
corefx-ci (Windows x64_Debug) Windows x64_Debug succeeded
Details
corefx-ci (Windows x86_Release) Windows x86_Release succeeded
Details
corefx-ci (macOS x64_Debug) macOS x64_Debug succeeded
Details
license/cla All CLA requirements met.
Details

@karelz karelz added this to the 3.0 milestone Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.