Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies from dotnet/coreclr #41280

Merged

Conversation

@dotnet-maestro
Copy link
Contributor

commented Sep 24, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/coreclr

  • Build: 20191001.3
  • Date Produced: 10/2/2019 12:57 AM
  • Commit: 435c480
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NET.Sdk.IL -> 5.0.0-alpha1.19501.3
    • Microsoft.NETCore.ILAsm -> 5.0.0-alpha1.19501.3
    • Microsoft.NETCore.Runtime.CoreCLR -> 5.0.0-alpha1.19501.3
@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release)
@jkotas

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

x86 failures are likely related to dotnet/coreclr#26860

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Linux Build x64_Debug)
@jkotas

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

@janvorli Windows x86 is crashing with:

0:012> k
 # ChildEBP RetAddr  
00 0963c24c 722590c5 coreclr!__report_gsfailure+0x17 [d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\gs\gs_report.c @ 220] 
01 (Inline) -------- coreclr!DoJITFailFast+0x5 [f:\workspace.2\_work\1\s\src\vm\jithelpers.cpp @ 5068] 
02 0963c254 722592ef coreclr!CrawlFrame::SetCurGSCookie+0x2f [f:\workspace.2\_work\1\s\src\vm\stackwalk.cpp @ 425] 
03 0963c268 7225a3f6 coreclr!CrawlFrame::GotoNextFrame+0x2f [f:\workspace.2\_work\1\s\src\vm\stackwalk.cpp @ 388] 
04 0963c2b0 72259d49 coreclr!StackFrameIterator::NextRaw+0x51c [f:\workspace.2\_work\1\s\src\vm\stackwalk.cpp @ 2727] 
05 (Inline) -------- coreclr!StackFrameIterator::Next+0x17 [f:\workspace.2\_work\1\s\src\vm\stackwalk.cpp @ 1627] 
06 0963c574 72259441 coreclr!Thread::StackWalkFramesEx+0x17e [f:\workspace.2\_work\1\s\src\vm\stackwalk.cpp @ 975] 
07 0963c8a8 722a5b22 coreclr!Thread::StackWalkFrames+0x8a [f:\workspace.2\_work\1\s\src\vm\stackwalk.cpp @ 1053] 
08 0963c8d0 722a5acd coreclr!UnwindFrames+0x3b [f:\workspace.2\_work\1\s\src\vm\excep.cpp @ 2206] 
09 0963c9e4 722a59f3 coreclr!COMPlusAfterUnwind+0xbb [f:\workspace.2\_work\1\s\src\vm\i386\excepx86.cpp @ 474] 

Most likely caused by dotnet/coreclr#26763 . @janvorli Could you please take a look?

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Linux Build arm_Debug)
@safern

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

cc: @GrabYourPitchforks it seems like the APIs added in: dotnet/coreclr#26711 need to be added to the ref assembly as well. Do you want me to do so, or baseline the errors and then I guess you have a PR to add tests where you can remove the baseline and expose them?

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Linux Build arm_Debug)
@janvorli

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

I am working on a fix for the crash during stack walking.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Linux Build arm_Debug)
@GrabYourPitchforks

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

@safern I already have the PR #41302 ready to go which adds ref asms + unit tests.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Linux Build arm_Debug)
@safern

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

@safern I already have the PR #41302 ready to go which adds ref asms + unit tests.

Correct, I saw that, but this PR will fail until we baseline the errors or we do the ref asms update here, since your PR change is somehow big because you added nullability, I'll baseline the errors in this PR and then on your PR we can remove the baseline.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Linux Build arm_Debug)
@GrabYourPitchforks

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

Baselining the errors sounds good to me. Thanks. :)

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Linux Build arm_Debug)
@tannergooding

This comment has been minimized.

Copy link
Member

commented Sep 29, 2019

Pushed a commit dealing with the ref assembly changes for System.Runtime.Intrinsics.Experimental (dotnet/coreclr#26895).

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@safern

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@tannergooding there are still some errors w.r.t Intrinsics.Experimental for arm64 arch.

/__w/1/s/.packages/microsoft.dotnet.apicompat/5.0.0-beta.19476.6/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : CannotSealType : Type 'System.Runtime.Intrinsics.Arm.AdvSimd.Arm64' is effectively (has a private constructor) sealed in the reference but not sealed in the implementation. [/__w/1/s/src/System.Runtime.Intrinsics.Experimental/src/System.Runtime.Intrinsics.Experimental.csproj]
##[error].packages/microsoft.dotnet.apicompat/5.0.0-beta.19476.6/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) CannotSealType : Type 'System.Runtime.Intrinsics.Arm.AdvSimd.Arm64' is effectively (has a private constructor) sealed in the reference but not sealed in the implementation.
/__w/1/s/.packages/microsoft.dotnet.apicompat/5.0.0-beta.19476.6/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.Runtime.Intrinsics.Arm.AdvSimd.Arm64..ctor()' does not exist in the reference but it does exist in the implementation. [/__w/1/s/src/System.Runtime.Intrinsics.Experimental/src/System.Runtime.Intrinsics.Experimental.csproj]
##[error].packages/microsoft.dotnet.apicompat/5.0.0-beta.19476.6/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) MembersMustExist : Member 'System.Runtime.Intrinsics.Arm.AdvSimd.Arm64..ctor()' does not exist in the reference but it does exist in the implementation.
/__w/1/s/.packages/microsoft.dotnet.apicompat/5.0.0-beta.19476.6/build/Microsoft.DotNet.ApiCompat.targets(157,5): error : MatchingRefApiCompat failed - The reference assembly doesn't match all the APIs in the implementation for '/__w/1/s/artifacts/bin/System.Runtime.Intrinsics.Experimental/netcoreapp-Unix-Debug/System.Runtime.Intrinsics.Experimental.dll'. To address either fix errors in the reference assembly (referenced as implementation in compat errors for this reverse compat check), add the issues to the baseline file '/__w/1/s/src/System.Runtime.Intrinsics.Experimental/src/MatchingRefApiCompatBaseline.txt' or disable this check by setting RunMatchingRefApiCompat=false in this project. [/__w/1/s/src/System.Runtime.Intrinsics.Experimental/src/System.Runtime.Intrinsics.Experimental.csproj]
##[error].packages/microsoft.dotnet.apicompat/5.0.0-beta.19476.6/build/Microsoft.DotNet.ApiCompat.targets(157,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) MatchingRefApiCompat failed - The reference assembly doesn't match all the APIs in the implementation for '/__w/1/s/artifacts/bin/System.Runtime.Intrinsics.Experimental/netcoreapp-Unix-Debug/System.Runtime.Intrinsics.Experimental.dll'. To address either fix errors in the reference assembly (referenced as implementation in compat errors for this reverse compat check), add the issues to the baseline file '/__w/1/s/src/System.Runtime.Intrinsics.Experimental/src/MatchingRefApiCompatBaseline.txt' or disable this check by setting RunMatchingRefApiCompat=false in this project.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@tannergooding

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

Oh, I see. The AdvSimd64.PlatformNotSupported.cs has the constructor as internal; but not the implementation assembly (in Corelib)...

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@safern

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

/azp run corefx-ci

@azure-pipelines

This comment has been minimized.

Copy link

commented Sep 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).
@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@janvorli

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

The fix for the x86 corefx tests issue (#41280 (comment)) was just merged in.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@tannergooding

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Looks like a number of UTF8String tests are failing?

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@tannergooding

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

@GrabYourPitchforks, looks like there are some actual test failures now.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@GrabYourPitchforks

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

I'm investigating.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows Build x86_Release)
@safern

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Thanks @GrabYourPitchforks -- the remaining test failure is because we haven't consumed @janvorli's fix. I will manually trigger the subscription once a new build is produced and also I will squash all the dotnet-bot commits + remove mine, in order to be able to rebase and not loose history on your and @tannergooding's changes.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux Build musl_x64_Debug)
@safern safern force-pushed the darc-master-6339d197-6c2b-47cd-ae3c-462e4bbace4c branch from 1950c42 to ca7b7f9 Oct 2, 2019
@safern

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

I've fixed the commits for this PR in order to be able to rebase and preserve history since we're changing more stuff than just dependencies here, please let me know if it makes sense to you guys before CI finishes and I merge when green.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux Build musl_x64_Debug)
Copy link
Member

left a comment

Makes sense to me. My changes look good.

@safern

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

It seems like the new version of coreclr is failing to build in musl, investigating locally.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux Build musl_x64_Debug)
GrabYourPitchforks and others added 3 commits Sep 24, 2019
…1001.3

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19501.3
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19501.3
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19501.3
@safern

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Ok, I found the issue. CoreCLR changed yesterday to build on alpine-3.9 instead of alpine3.6 and we're still building on 3.6. It seems like libicu does symbol versioning on alpine, as the failure is:

/__w/1/s/src/Microsoft.XmlSerializer.Generator/tests/Microsoft.XmlSerializer.Generator.Tests.csproj(44,5): error MSB3073: The command "export DOTNET_MULTILEVEL_LOOKUP=0 & "/__w/1/s/artifacts/bin/testhost/netcoreapp-Linux-Debug-x64/dotnet" --fx-version 5.0.0 /__w/1/s/artifacts/bin/Microsoft.XmlSerializer.Generator.Tests/netcoreapp-Debug/dotnet-Microsoft.XmlSerializer.Generator.dll /__w/1/s/artifacts/bin/Microsoft.XmlSerializer.Generator.Tests/netcoreapp-Debug/Microsoft.XmlSerializer.Generator.Tests.dll --force --quiet" exited with code 134.

Process terminated. Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.
at System.Environment.FailFast(System.String)
at System.Globalization.GlobalizationMode.GetGlobalizationInvariantMode()
at System.Globalization.GlobalizationMode..cctor()
at System.Globalization.GlobalizationMode.get_Invariant()
at System.Globalization.CultureData.CreateCultureWithInvariantData()
at System.Globalization.CultureData.get_Invariant()
at System.Globalization.CultureInfo..cctor()
at System.Globalization.CultureInfo.get_CurrentCulture()
at System.String.EndsWith(System.String, System.StringComparison)
at System.String.EndsWith(System.String)
at Microsoft.XmlSerializer.Generator.Sgen.ParseResponseFile(System.String[])
at Microsoft.XmlSerializer.Generator.Sgen.Run(System.String[])
at Microsoft.XmlSerializer.Generator.Sgen.Main(System.String[])

I think it should be fine to move corefx to build on alpine3.9 in master given that alpine-3.8 LTS support ends before .NET 5 release:

Alpine 3.8 goes EOL on May 1st 2020 and 3.9 on November 1st 2020. So we likely won't support .NET 5 on pre-3.9 given our release cadence

So I will move to build on 3.9 corefx master.

FYI: @danmosemsft @wfurt @ViktorHofer @jkoritzinsky @janvorli

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Windows Packaging All Configurations x64_Debug)
@safern safern force-pushed the darc-master-6339d197-6c2b-47cd-ae3c-462e4bbace4c branch from ca7b7f9 to 8a345fd Oct 2, 2019
@wfurt

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

The issue lives in pal_icushim.c

https://github.com/dotnet/coreclr/blob/190888373afe4f526de2bd7f366ffe53cced0325/src/corefx/System.Globalization.Native/pal_icushim.c#L57-L58

#define MinICUVersion  U_ICU_VERSION_MAJOR_NUM
#define MaxICUVersion  (MinICUVersion + 20)```

now we build on .62 but Alpine 3.8 has .58. So we never try to open proper library. It was confirmed that with strace that we are trying in range of 82-62.

It seems like the code was written with assumption that we build on oldest possible version. We should either set it to some known min version or set min = U_ICU_VERSION_MAJOR_NUM - 5(ish)

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: corefx-ci, corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (Windows Build NETFX_x86_Release), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Windows Build x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
@dotnet-maestro dotnet-maestro bot merged commit c8c2917 into master Oct 3, 2019
15 checks passed
15 checks passed
WIP Ready for review
Details
corefx-ci Build #20191002.28 succeeded
Details
corefx-ci (Linux Build RedHat6_x64_Release) Linux Build RedHat6_x64_Release succeeded
Details
corefx-ci (Linux Build arm64_Debug) Linux Build arm64_Debug succeeded
Details
corefx-ci (Linux Build arm_Debug) Linux Build arm_Debug succeeded
Details
corefx-ci (Linux Build musl_arm64_Debug) Linux Build musl_arm64_Debug succeeded
Details
corefx-ci (Linux Build musl_x64_Debug) Linux Build musl_x64_Debug succeeded
Details
corefx-ci (Linux Build x64_Debug) Linux Build x64_Debug succeeded
Details
corefx-ci (MacOS Build x64_Debug) MacOS Build x64_Debug succeeded
Details
corefx-ci (Windows Build NETFX_x86_Release) Windows Build NETFX_x86_Release succeeded
Details
corefx-ci (Windows Build UWP_CoreCLR_x64_Debug) Windows Build UWP_CoreCLR_x64_Debug succeeded
Details
corefx-ci (Windows Build x64_Debug) Windows Build x64_Debug succeeded
Details
corefx-ci (Windows Build x86_Release) Windows Build x86_Release succeeded
Details
corefx-ci (Windows Packaging All Configurations x64_Debug) Windows Packaging All Configurations x64_Debug succeeded
Details
license/cla All CLA requirements met.
Details
@dotnet-maestro dotnet-maestro bot deleted the darc-master-6339d197-6c2b-47cd-ae3c-462e4bbace4c branch Oct 3, 2019
@safern

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

The bot squashed the commits 😢

@janvorli

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@wfurt thank you for looking into that. You are completely right about the assumption that we build on the oldest supported version. I've not remembered that when moving to build on 3.9 was discussed.
The reason to not to always start from the version 50 (the first one that we can possibly work with and the one present on CentOS 7) was to ensure that we do a minimal amount of scanning when we build for specific distro. Another reason was that on glibc based distros, build from a newer distro can never work on an older one anyways.
The MUSL based distros are different though, build created on a newer Alpine actually works on an older one, so it would make sense to make the initial version constant for MUSL based distros (I would use the version from 3.6)

@GrabYourPitchforks

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

No worries @safern. I appreciate your efforts on this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.