Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.1] Add Fedora 33 runtime ids #42871

Merged
merged 3 commits into from Mar 26, 2020
Merged

Conversation

@omajid
Copy link
Member

omajid commented Feb 24, 2020

Fedora 32 is gearing up for release[1], and in-development version of Fedora has been officially labelled as being Fedora 33:

$ podman run -it fedora:33 cat /etc/os-release
NAME=Fedora
VERSION="33 (Container Image)"
ID=fedora
VERSION_ID=33
VERSION_CODENAME=""
PLATFORM_ID="platform:f33"
PRETTY_NAME="Fedora 33 (Container Image)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:33"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Container Image"
VARIANT_ID=container

[1] https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

This is a backport of dotnet/runtime#32752

Fedora 32 is gearing up for release[1], and in-development version of
Fedora has been offically labelled as being Fedora 33:

    $ podman run -it fedora:33 cat /etc/os-release
    NAME=Fedora
    VERSION="33 (Container Image)"
    ID=fedora
    VERSION_ID=33
    VERSION_CODENAME=""
    PLATFORM_ID="platform:f33"
    PRETTY_NAME="Fedora 33 (Container Image)"
    ANSI_COLOR="0;34"
    LOGO=fedora-logo-icon
    CPE_NAME="cpe:/o:fedoraproject:fedora:33"
    HOME_URL="https://fedoraproject.org/"
    DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
    SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
    BUG_REPORT_URL="https://bugzilla.redhat.com/"
    REDHAT_BUGZILLA_PRODUCT="Fedora"
    REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
    REDHAT_SUPPORT_PRODUCT="Fedora"
    REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
    PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
    VARIANT="Container Image"
    VARIANT_ID=container

[1] https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
@omajid omajid changed the title Add Fedora 33 runtime ids [release/3.1] Add Fedora 33 runtime ids Feb 24, 2020
@omajid omajid requested a review from bartonjs Feb 25, 2020
@bartonjs bartonjs requested a review from safern Feb 27, 2020
@@ -27,7 +27,7 @@
<PackageVersion Condition="'$(PackageVersion)' == ''">4.7.0</PackageVersion>
<!-- major.minor.release version of the platforms package we're currently building
Pre-release will be appended during build -->
<PlatformPackageVersion>3.1.0</PlatformPackageVersion>
<PlatformPackageVersion>3.1.1</PlatformPackageVersion>

This comment has been minimized.

Copy link
@bartonjs

bartonjs Feb 27, 2020

Member

@safern Does this require rebuilding the package index with this PR? Or is that something that gets handled automagically?

This comment has been minimized.

Copy link
@omajid

omajid Mar 3, 2020

Author Member

@safern Ping?

This comment has been minimized.

Copy link
@danmosemsft

This comment has been minimized.

Copy link
@ericstj

ericstj Mar 6, 2020

Member

I believe this is sufficient. @Anipik when do we typically add the stable version to the index?

This comment has been minimized.

Copy link
@Anipik

Anipik Mar 6, 2020

Member

we add it after the package has been pushed to the nuget. i.e on the day of release with the branding change.

@safern
safern approved these changes Mar 10, 2020
@omajid

This comment has been minimized.

Copy link
Member Author

omajid commented Mar 13, 2020

Can someone please merge this? Thanks

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Mar 13, 2020

This is for a servicing branch, has this been taken to tactics for servicing approval?

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Mar 13, 2020

I've added servicing-consider. This will need to go through shiproom. FWIW, 3.1 has been locked for a couple weeks so this wouldn't have made it into 3.1.3. It'll need to be in 3.1.4.

@omajid

This comment has been minimized.

Copy link
Member Author

omajid commented Mar 13, 2020

FWIW, ship room has previously said that RID-bumps are considered "tell-mode" not "ask-mode".

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Mar 13, 2020

Got it, I'd expect that too.

@danmosemsft danmosemsft added this to the 3.1.4 milestone Mar 24, 2020
Anipik added 2 commits Mar 25, 2020
@Anipik Anipik merged commit ef1643c into dotnet:release/3.1 Mar 26, 2020
15 checks passed
15 checks passed
WIP Ready for review
Details
corefx-ci Build #20200325.14 had test failures
Details
corefx-ci (Linux Build RedHat6_x64_Release) Linux Build RedHat6_x64_Release succeeded
Details
corefx-ci (Linux Build arm64_Debug) Linux Build arm64_Debug succeeded
Details
corefx-ci (Linux Build arm_Debug) Linux Build arm_Debug succeeded
Details
corefx-ci (Linux Build musl_arm64_Debug) Linux Build musl_arm64_Debug succeeded
Details
corefx-ci (Linux Build musl_x64_Debug) Linux Build musl_x64_Debug succeeded
Details
corefx-ci (Linux Build x64_Debug) Linux Build x64_Debug succeeded
Details
corefx-ci (MacOS Build x64_Debug) MacOS Build x64_Debug succeeded
Details
corefx-ci (Windows Build NETFX_x86_Release) Windows Build NETFX_x86_Release succeeded
Details
corefx-ci (Windows Build UWP_CoreCLR_x64_Debug) Windows Build UWP_CoreCLR_x64_Debug succeeded
Details
corefx-ci (Windows Build x64_Debug) Windows Build x64_Debug succeeded
Details
corefx-ci (Windows Build x86_Release) Windows Build x86_Release succeeded
Details
corefx-ci (Windows Packaging All Configurations x64_Debug) Windows Packaging All Configurations x64_Debug succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.