Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port non-shared readonly changes from coreclr #4855

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@stephentoub
Copy link
Member

stephentoub commented Nov 1, 2017

Dependent on dotnet/coreclr#14789 being merged and mirrored over.
cc: @jkotas

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Nov 8, 2017

CancelationToken.cs needs move work - readonly m_source is assigned in InitializeDefaultSource.

@stephentoub

This comment has been minimized.

Copy link
Member Author

stephentoub commented Nov 9, 2017

readonly m_source is assigned in InitializeDefaultSource

The InitializeDefaultSource can be deleted, and WaitHandle can be updated as was done in coreclr:
https://github.com/dotnet/coreclr/blob/master/src/mscorlib/src/System/Threading/CancellationToken.cs#L89

Will fix.

@stephentoub stephentoub force-pushed the stephentoub:port14789 branch from dcc215c to 6b75b95 Nov 9, 2017

@stephentoub

This comment has been minimized.

Copy link
Member Author

stephentoub commented Nov 9, 2017

@dotnet-bot test this please

@jkotas jkotas merged commit 2137ae6 into dotnet:master Nov 9, 2017

8 checks passed

OSX10.12 Debug and CoreCLR tests Build finished.
Details
OSX10.12 Release Build finished.
Details
Ubuntu Debug and CoreCLR tests Build finished.
Details
Ubuntu Release Build finished.
Details
WIP ready for review
Details
Windows_NT Debug and CoreCLR tests Build finished.
Details
Windows_NT Release Build finished.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.