Skip to content
This repository has been archived by the owner. It is now read-only.

Port non-shared readonly changes from coreclr #4855

Merged
merged 1 commit into from Nov 9, 2017

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 1, 2017

Dependent on dotnet/coreclr#14789 being merged and mirrored over.
cc: @jkotas

@jkotas
Copy link
Member

@jkotas jkotas commented Nov 8, 2017

CancelationToken.cs needs move work - readonly m_source is assigned in InitializeDefaultSource.

@stephentoub
Copy link
Member Author

@stephentoub stephentoub commented Nov 9, 2017

readonly m_source is assigned in InitializeDefaultSource

The InitializeDefaultSource can be deleted, and WaitHandle can be updated as was done in coreclr:
https://github.com/dotnet/coreclr/blob/master/src/mscorlib/src/System/Threading/CancellationToken.cs#L89

Will fix.

@stephentoub stephentoub force-pushed the stephentoub:port14789 branch from dcc215c to 6b75b95 Nov 9, 2017
@stephentoub
Copy link
Member Author

@stephentoub stephentoub commented Nov 9, 2017

@dotnet-bot test this please

@jkotas jkotas merged commit 2137ae6 into dotnet:master Nov 9, 2017
8 checks passed
8 checks passed
OSX10.12 Debug and CoreCLR tests Build finished.
Details
OSX10.12 Release Build finished.
Details
Ubuntu Debug and CoreCLR tests Build finished.
Details
Ubuntu Release Build finished.
Details
@wip
WIP ready for review
Details
Windows_NT Debug and CoreCLR tests Build finished.
Details
Windows_NT Release Build finished.
Details
license/cla All CLA requirements met.
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants