New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror changes from dotnet/corefx,coreclr #6997

Merged
merged 4 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@Dotnet-GitSync-Bot
Copy link
Contributor

Dotnet-GitSync-Bot commented Feb 11, 2019

This PR contains mirrored changes from dotnet/corefx,coreclr

Please REBASE this PR when merging

cc @stephentoub @stephentoub

stephentoub added some commits Feb 11, 2019

Move GCHandle to shared (dotnet/coreclr#22499)
* Move GCHandle to shared

* Cache the handle in a local to make it easier for JIT to generate good code

* Rename m_handle to _handle to match the coding conventions

* Delete isPinned argument for GCHandleInternalCompareExchange

* Add fast path to GCHandle.Alloc/Free FCalls

* Disable outdated test

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Move Volatile to shared (dotnet/coreclr#22523)
* Move Volatile to shared

This largely takes corert's implementation, which uses Unsafe.As and volatile fields.

We could investigate also removing the JIT's replacements subsequently.

* Add [Intrinsic] attributes

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 11, 2019

I am fixing the build breaks.

@stephentoub

This comment has been minimized.

Copy link
Member

stephentoub commented Feb 11, 2019

I am fixing the build breaks.

Ok, thanks. Was going to do it, but have at it :)

@jkotas jkotas force-pushed the Dotnet-GitSync-Bot:mirror-merge-10054043 branch from ad7475e to cfa7fa2 Feb 12, 2019

@jkotas jkotas merged commit 524323a into dotnet:master Feb 12, 2019

12 checks passed

OSX10.12 Debug and CoreCLR tests Build finished.
Details
OSX10.12 Debug and CoreFX tests Build finished.
Details
OSX10.12 Release Build finished.
Details
Ubuntu Debug and CoreCLR tests Build finished.
Details
Ubuntu Debug and CoreFX tests Build finished.
Details
Ubuntu Release Build finished.
Details
Windows_NT Debug and CoreCLR tests Build finished.
Details
Windows_NT Debug and CoreFX tests Build finished.
Details
Windows_NT Release Build finished.
Details
Windows_NT_Wasm Debug and CoreCLR tests WebAssembly Build finished.
Details
Windows_NT_Wasm Release WebAssembly Build finished.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment