New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror changes from dotnet/corefx,coreclr #6999

Merged
merged 4 commits into from Feb 12, 2019

Conversation

Projects
None yet
5 participants
@Dotnet-GitSync-Bot
Copy link
Contributor

Dotnet-GitSync-Bot commented Feb 12, 2019

This PR contains mirrored changes from dotnet/corefx,coreclr

Please REBASE this PR when merging

cc @marek-safar @stephentoub

marek-safar and others added some commits Feb 11, 2019

Make Module partial to allow additional changed for Mono
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Move ConditionalWeakTable to shared (dotnet/coreclr#22531)
Leaves DependentHandle as being the runtime PAL

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Fix CoreRT build breaks
- Adjust resource name
- Workaround C# compiler/analyzer bug

@jkotas jkotas closed this Feb 12, 2019

@jkotas jkotas reopened this Feb 12, 2019

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 12, 2019

@dotnet-bot test this please

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 12, 2019

03:28:02 
     1>EXEC : error : Unable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results. IComparer: 'ILCompiler.DependencyAnalysis.SortableDependencyNode+EmbeddedObjectNodeComparer'. [D:\j\workspace\release_windo---c2468dc6\tests\src\Simple\PreInitData\PreInitData.ilproj]
03:28:02          System.ArgumentException: Unable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results. IComparer: 'ILCompiler.DependencyAnalysis.SortableDependencyNode+EmbeddedObjectNodeComparer'.
03:28:02             at System.Collections.Generic.IntrospectiveSortUtilities.ThrowOrIgnoreBadComparer(Object comparer)
03:28:02             at System.Collections.Generic.ArraySortHelper`1.Sort(T[] keys, Int32 index, Int32 length, IComparer`1 comparer)
03:28:02             at System.Collections.Generic.List`1.Sort(Int32 index, Int32 count, IComparer`1 comparer)
03:28:02             at ILCompiler.DependencyAnalysis.ArrayOfEmbeddedDataNode`1.GetData(NodeFactory factory, Boolean relocsOnly) in D:\j\workspace\release_windo---c2468dc6\src\ILCompiler.Compiler\src\Compiler\DependencyAnalysis\ArrayOfEmbeddedDataNode.cs:line 82
03:28:02             at ILCompiler.DependencyAnalysis.ObjectWriter.EmitObject(String objectFilePath, IEnumerable`1 nodes, NodeFactory factory, IObjectDumper dumper) in D:\j\workspace\release_windo---c2468dc6\src\ILCompiler.Compiler\src\Compiler\DependencyAnalysis\ObjectWriter.cs:line 1005
03:28:02             at ILCompiler.Compilation.ILCompiler.ICompilation.Compile(String outputFile, ObjectDumper dumper) in D:\j\workspace\release_windo---c2468dc6\src\ILCompiler.Compiler\src\Compiler\Compilation.cs:line 389
```
@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 12, 2019

@dotnet-bot test Windows_NT Release please

@jkotas jkotas closed this Feb 12, 2019

@jkotas jkotas reopened this Feb 12, 2019

@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Feb 12, 2019

Unable to sort because

Well, at least it's deterministic. I can take a look if you're not looking.

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 12, 2019

I am not sure whether it is deterministic yet. I am not looking. It would be great if you can take a look.

@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Feb 12, 2019

I am not sure whether it is deterministic yet

I'm pretty sure I saw a result from when you closed and reopened, but once I commented on it, the comment triggered a retest of everything again.

@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Feb 12, 2019

#7005 unblocks this.

@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Feb 12, 2019

@dotnet-bot test Windows_NT Debug and CoreFX tests

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Feb 12, 2019

The CoreFX test blobs disappeared dotnet/corefx#34957 (comment)

@jkotas jkotas closed this Feb 12, 2019

@jkotas jkotas reopened this Feb 12, 2019

@jkotas jkotas merged commit 36d23ac into dotnet:master Feb 12, 2019

12 checks passed

OSX10.12 Debug and CoreCLR tests Build finished.
Details
OSX10.12 Debug and CoreFX tests Build finished.
Details
OSX10.12 Release Build finished.
Details
Ubuntu Debug and CoreCLR tests Build finished.
Details
Ubuntu Debug and CoreFX tests Build finished.
Details
Ubuntu Release Build finished.
Details
Windows_NT Debug and CoreCLR tests Build finished.
Details
Windows_NT Debug and CoreFX tests Build finished.
Details
Windows_NT Release Build finished.
Details
Windows_NT_Wasm Debug and CoreCLR tests WebAssembly Build finished.
Details
Windows_NT_Wasm Release WebAssembly Build finished.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment