Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperIlc show compile failures #7167

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@nattress
Copy link
Member

nattress commented Mar 14, 2019

Couple small quality of life improvements:

  • After compiling all assemblies, write a list of compilation failures to the console
  • Emit ready-to-run images without the .ni part of the extension. This was initially useful so we knew which images were R2R but the CoreCLR loader expects the app host in a .NET Core app to be a .dll and Crossgen doesn't use .ni anymore.
SuperIlc show compile failures
Couple small quality of life improvements:
* After compiling all assemblies, write a list of compilation failures to the console
* Emit ready-to-run images without the `.ni` part of the extension. This was initially useful so we knew which images were R2R but the CoreCLR loader expects the app host in a .NET Core app to be a .dll and Crossgen doesn't use `.ni` anymore.

@nattress nattress requested a review from trylek Mar 14, 2019

@trylek

trylek approved these changes Mar 14, 2019

Copy link
Contributor

trylek left a comment

Looks great to me. Thanks for fixing the ni extension issue so quickly!


if (_failedCompilationAssemblies.Count > 0)
{
Console.WriteLine($"Could not compile the following assemblies:");

This comment has been minimized.

@trylek

trylek Mar 14, 2019

Contributor

Nit - could you please also display the number of failing assemblies so that we don't need to count the lines in case of a larger number of failures?

This comment has been minimized.

@nattress

nattress Mar 14, 2019

Author Member

Absolutely

@nattress nattress merged commit 7e9da08 into dotnet:master Mar 15, 2019

1 of 3 checks passed

Windows_NT_Wasm Debug and CoreCLR tests WebAssembly Triggered.
Details
Windows_NT_Wasm Release WebAssembly Triggered.
Details
license/cla All CLA requirements met.
Details

@nattress nattress deleted the nattress:SuperIlcShowFailures branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.