Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller SuperIlc fixes for bugs I hit in local testing #7306

Merged
merged 4 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@trylek
Copy link
Contributor

trylek commented Apr 15, 2019

  1. One of the interesting features of the new command-line interface
    is the fact that it tries to match the option names to identifiers
    of fields and method parameters. Due to this the option --crossgen
    didn't get bound because the counterpart field was called UseCrossgen.
    I have renamed the field to just Crossgen.

  2. Don't schedule executions for apps that failed to compile as
    the executions are certain to fail due to the absence of the compiled
    artifacts.

Thanks

Tomas

Smaller SuperIlc fixes I hit in local testing
1) One of the interesting features of the new command-line interface
is the fact that it tries to match the option names to identifiers
of fields and method parameters. Due to this the option --crossgen
didn't get bound because the counterpart field was called UseCrossgen.
I have renamed the field to just Crossgen.

2) Don't schedule executions for apps that failed to compile as
the executions are certain to fail due to the absence of the compiled
artifacts.

Thanks

Tomas

@trylek trylek requested a review from nattress Apr 15, 2019

trylek added some commits Apr 15, 2019

Fix timeout bucketing and reduce ILC timeout to 2 minutes
I have yet to see a meaningful CPAOT compilation taking more than
2 minutes per assembly; for now the only occurrences of this
behavior are not yet understood timeouts that just block test
compilation.

Thanks

Tomas
@nattress
Copy link
Member

nattress left a comment

LGTM

@trylek trylek closed this Apr 16, 2019

@trylek trylek reopened this Apr 16, 2019

@trylek trylek merged commit c81d4c2 into dotnet:master Apr 16, 2019

3 checks passed

Windows_NT_Wasm Debug and CoreCLR tests WebAssembly Build finished.
Details
Windows_NT_Wasm Release WebAssembly Build finished.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.