Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdditionalBuildArgs option for the official build pipeline #7312

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@jkotas
Copy link
Member

jkotas commented Apr 16, 2019

No description provided.

@jkotas

This comment has been minimized.

Copy link
Member Author

jkotas commented Apr 16, 2019

I would like get the new objwriter packages to be built by the official build. I plan to use AdditionalBuildArgs to add objwriter option for a few official builds to build updated objwriter and then turn it off again to do not waste cloud resources.

@jkotas jkotas force-pushed the jkotas:AdditionalBuildArgs branch from 0c36a53 to c466c78 Apr 16, 2019

@MichalStrehovsky MichalStrehovsky merged commit c2fd86a into dotnet:master Apr 16, 2019

3 checks passed

Windows_NT_Wasm Debug and CoreCLR tests WebAssembly Build finished.
Details
Windows_NT_Wasm Release WebAssembly Build finished.
Details
license/cla All CLA requirements met.
Details
@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Apr 16, 2019

I'll kick off a build with the objwriter option.

@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Apr 16, 2019

Piped through the AdditionalBuildArgs variable to the official build definition, but there's some trouble with it:

Linux

CMake Error at ObjWriter/llvmCap/CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.6 or higher is required.  You are running version 2.8.12.2

Bumping DockerTag from ubuntu-14.04-198573d-20170319080304 to ubuntu-18.04-c103199-20180628134610 might fix this based on what I see in the dotnet/dotnet-buildtools-prereqs-docker repo.

macOS

Scanning dependencies of target LLVM
make[2]: *** No rule to make target `ObjWriter/llvmCap/LLVM-prefix/src/LLVM-stamp/LLVM-skip-update', needed by `ObjWriter/llvmCap/LLVM-prefix/src/LLVM-stamp/LLVM-configure'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[ 95%] Creating directories for 'LLVM'
make[1]: *** [ObjWriter/llvmCap/CMakeFiles/LLVM.dir/all] Error 2

Not sure about that one.

@jkotas

This comment has been minimized.

Copy link
Member Author

jkotas commented Apr 16, 2019

#7315 should fix these

@jkotas jkotas deleted the jkotas:AdditionalBuildArgs branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.