Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm: fix more occurrences of loading Sbytes into int32 without sign extending. #7764

Merged
merged 13 commits into from Nov 8, 2019

Conversation

@yowl
Copy link
Contributor

yowl commented Sep 3, 2019

While #7763 was fine as far as it went, it didn't actually catch all problems with loading sbyte on to the stack, namely binary operations, shifting and branching. This add a few more tests for those and fixes the sign extending

@yowl yowl changed the title Sbyteextend Wasm: fix more occurrences of loading Sbytes into int32 without sign extending. Sep 3, 2019
@yowl

This comment has been minimized.

Copy link
Contributor Author

yowl commented Sep 3, 2019

Marking back to WIP as want to get a test that failed in Debug as opposed to just in Release.

@yowl yowl changed the title Wasm: fix more occurrences of loading Sbytes into int32 without sign extending. [WIP]: Wasm: fix more occurrences of loading Sbytes into int32 without sign extending. Sep 3, 2019
@yowl yowl force-pushed the yowl:sbyteextend branch from 5471f76 to c33ef91 Nov 7, 2019
@yowl yowl changed the title [WIP]: Wasm: fix more occurrences of loading Sbytes into int32 without sign extending. Wasm: fix more occurrences of loading Sbytes into int32 without sign extending. Nov 8, 2019
@yowl

This comment has been minimized.

Copy link
Contributor Author

yowl commented Nov 8, 2019

Added an IL test to catch the bne on i8s which I couldn't find a way to do in c#.

@jkotas
jkotas approved these changes Nov 8, 2019
Copy link
Member

jkotas left a comment

Thanks!

@jkotas jkotas merged commit e30c827 into dotnet:master Nov 8, 2019
12 checks passed
12 checks passed
WIP Ready for review
Details
corert-ci Build #20191108.1 succeeded
Details
corert-ci (Build Linux x64 debug and CoreCLR tests) Build Linux x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Linux x64 debug and CoreFX tests) Build Linux x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Linux x64 release) Build Linux x64 release succeeded
Details
corert-ci (Build OSX x64 debug and CoreCLR tests) Build OSX x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build OSX x64 debug and CoreFX tests) Build OSX x64 debug and CoreFX tests succeeded
Details
corert-ci (Build OSX x64 release) Build OSX x64 release succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreCLR tests) Build Windows_NT x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreFX tests) Build Windows_NT x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
license/cla All CLA requirements met.
Details
@yowl yowl deleted the yowl:sbyteextend branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.