Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding signature matching unit test #7869

Merged
merged 3 commits into from Nov 12, 2019

Conversation

@cshung
Copy link
Member

cshung commented Nov 6, 2019

This unit test is meant to validate dotnet/coreclr#27676

@dotnet/crossgen-contrib

Copy link
Member

davidwrighton left a comment

This test passes even without the fix... that isn't really testing the problems here.

@cshung cshung force-pushed the cshung:dev/andrewau/signature-test branch from 0f3853c to 7f6c602 Nov 12, 2019
@cshung cshung merged commit 5575cc0 into dotnet:master Nov 12, 2019
12 checks passed
12 checks passed
WIP Ready for review
Details
corert-ci Build #20191112.2 succeeded
Details
corert-ci (Build Linux x64 debug and CoreCLR tests) Build Linux x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Linux x64 debug and CoreFX tests) Build Linux x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Linux x64 release) Build Linux x64 release succeeded
Details
corert-ci (Build OSX x64 debug and CoreCLR tests) Build OSX x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build OSX x64 debug and CoreFX tests) Build OSX x64 debug and CoreFX tests succeeded
Details
corert-ci (Build OSX x64 release) Build OSX x64 release succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreCLR tests) Build Windows_NT x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreFX tests) Build Windows_NT x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
license/cla All CLA requirements met.
Details
@cshung cshung deleted the cshung:dev/andrewau/signature-test branch Nov 12, 2019
@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Nov 12, 2019

@cshung can you please make sure the shared files have identical content on the CoreCLR side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.