Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm: Fix compilation error for `build wasm` #7872

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@yowl
Copy link
Contributor

yowl commented Nov 7, 2019

build wasm was failing as mentioned at #7609 (comment). Extend the #if to include _WASM_ which allows compilation to succeed.

@yowl yowl changed the title Fix compilation error for `build wasm` Wasm: Fix compilation error for `build wasm` Nov 7, 2019
@jkotas jkotas merged commit 42de01e into dotnet:master Nov 8, 2019
12 checks passed
12 checks passed
WIP Ready for review
Details
corert-ci Build #20191107.2 succeeded
Details
corert-ci (Build Linux x64 debug and CoreCLR tests) Build Linux x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Linux x64 debug and CoreFX tests) Build Linux x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Linux x64 release) Build Linux x64 release succeeded
Details
corert-ci (Build OSX x64 debug and CoreCLR tests) Build OSX x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build OSX x64 debug and CoreFX tests) Build OSX x64 debug and CoreFX tests succeeded
Details
corert-ci (Build OSX x64 release) Build OSX x64 release succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreCLR tests) Build Windows_NT x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreFX tests) Build Windows_NT x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
license/cla All CLA requirements met.
@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Nov 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.