Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86 Native build on Unix #7899

Merged
merged 1 commit into from Dec 3, 2019
Merged

Fix x86 Native build on Unix #7899

merged 1 commit into from Dec 3, 2019

Conversation

@am11
Copy link
Contributor

am11 commented Dec 2, 2019

x86 Native build (initially enabled in #4637 and #4598) is broken with the inclusion of (LLVM) libunwind, object writer and src/Native/Runtime/i386/MiscStubs.S.

This patch attempts to fill the gaps to make the Native components compile (including object writer): ./build.sh objwriter skiptests x86 (tested on Debian Stretch i386, cmake 3.13.2)

Managed components are still failing due to the lack of .NET SDK on Linux x86.

Installing dotnet cli...
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
ERROR: Could not download dotnet cli.
Please check the detailed log that follows.
Running: /home/admin/projects/corert/init-tools.sh
Installing 'https://dotnetcli.azureedge.net/dotnet/Sdk/2.1.504/dotnet-sdk-2.1.504-linux-x86.tar.gz' to '/home/admin/projects/corert/Tools/dotnetcli/dotnet.tar'
Using CLI tools version:
ls: cannot access '/home/admin/projects/corert/buildscripts/../Tools/dotnetcli/sdk': No such file or directory
./buildscripts/build-managed.sh: line 33: /home/admin/projects/corert/buildscripts/../Tools/dotnetcli/dotnet: No such file or directory

Contributes to: #4589

src/Native/libunwind/src/config.h Outdated Show resolved Hide resolved
@am11 am11 force-pushed the am11:feature/i386-support branch from 8e25fcd to 021fadc Dec 3, 2019
@jkotas
jkotas approved these changes Dec 3, 2019
Copy link
Member

jkotas left a comment

Thanks

@jkotas jkotas merged commit 180a175 into dotnet:master Dec 3, 2019
12 checks passed
12 checks passed
WIP Ready for review
Details
corert-ci #20191202.5 succeeded
Details
corert-ci (Build Linux x64 debug and CoreCLR tests) Build Linux x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Linux x64 debug and CoreFX tests) Build Linux x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Linux x64 release) Build Linux x64 release succeeded
Details
corert-ci (Build OSX x64 debug and CoreCLR tests) Build OSX x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build OSX x64 debug and CoreFX tests) Build OSX x64 debug and CoreFX tests succeeded
Details
corert-ci (Build OSX x64 release) Build OSX x64 release succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreCLR tests) Build Windows_NT x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreFX tests) Build Windows_NT x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
license/cla All CLA requirements met.
Details
@am11 am11 deleted the am11:feature/i386-support branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.