Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshaling for structs with pointers #7901

Merged
merged 1 commit into from Dec 3, 2019
Merged

Conversation

@jkotas
Copy link
Member

jkotas commented Dec 3, 2019

Fixes #7900

Fixes #7900
@jkotas

This comment has been minimized.

Copy link
Member Author

jkotas commented Dec 3, 2019

Regression introduced by #7890. It sounds like we have the same problem in CoreCLR as well.

@MichalStrehovsky @fadimounir

@jkotas jkotas merged commit 02d99d8 into dotnet:master Dec 3, 2019
12 checks passed
12 checks passed
WIP Ready for review
Details
corert-ci #20191202.3 succeeded
Details
corert-ci (Build Linux x64 debug and CoreCLR tests) Build Linux x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Linux x64 debug and CoreFX tests) Build Linux x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Linux x64 release) Build Linux x64 release succeeded
Details
corert-ci (Build OSX x64 debug and CoreCLR tests) Build OSX x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build OSX x64 debug and CoreFX tests) Build OSX x64 debug and CoreFX tests succeeded
Details
corert-ci (Build OSX x64 release) Build OSX x64 release succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreCLR tests) Build Windows_NT x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreFX tests) Build Windows_NT x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
license/cla All CLA requirements met.
Details
@MichalStrehovsky

This comment has been minimized.

Copy link
Member

MichalStrehovsky commented Dec 3, 2019

Regression introduced by #7890.

This logic wasn't in the original single-exe branch. The problematic piece was added by @janvorli in dotnet/coreclr#27746.

We really ought to split pull requests into "bring lots of already reviewed changes from a different branch" commit and "a tweak to it that needs to be reviewed thoroughly" commit.

@jkotas jkotas deleted the jkotas:issue-7900 branch Dec 3, 2019
@jkotas

This comment has been minimized.

Copy link
Member Author

jkotas commented Dec 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.