This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Fix reflection access to thread static fields #8219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflection-accessing threadstatic fields didn't work. I'm also deleting a bunch of .NET Native code that is not relevant to CoreRT. The .NET Native approach to threadstatics (using TLS region) is Windows-specific and not portable. The type loader support is incomplete (the compiler side is ready but runtime side is still going to fail with a MissingTemplateException). I got tired and this diff is already too big. Contributes to dotnet#5137.
Usage based metadata manager assumes all fields on allocated types are used and therefore reflectable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflection-accessing threadstatic fields didn't work.
I'm also deleting a bunch of .NET Native code that is not relevant to CoreRT.
The .NET Native approach to threadstatics (using TLS region) is Windows-specific
and not portable.
The type loader support is incomplete (the compiler side is ready but runtime side is
still going to fail with a MissingTemplateException). I got tired and this diff is already
too big.
Contributes to #5137.