New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Champion "pattern-matching with generics" (C# 7.1) #154

Open
gafter opened this Issue Feb 20, 2017 · 16 comments

Comments

Projects
None yet
9 participants
@gafter
Member

gafter commented Feb 20, 2017

See dotnet/roslyn#16195 (comment)

@axel-habermaier

This comment has been minimized.

Show comment
Hide comment
@axel-habermaier

axel-habermaier Mar 11, 2017

This is a very surprising limitation. It severely limits the usefulness of pattern matching in generic code, making many of the changes I was hoping to make to my code base impossible.

axel-habermaier commented Mar 11, 2017

This is a very surprising limitation. It severely limits the usefulness of pattern matching in generic code, making many of the changes I was hoping to make to my code base impossible.

@gafter

This comment has been minimized.

Show comment
Hide comment
@gafter

gafter Mar 12, 2017

Member

@axel-habermaier cast the switch expression to object to work around this issue.

Member

gafter commented Mar 12, 2017

@axel-habermaier cast the switch expression to object to work around this issue.

@alrz

This comment has been minimized.

Show comment
Hide comment
@alrz

alrz Mar 12, 2017

Contributor

I think this is also related here (dotnet/roslyn#17746)

void M<T>(T o)
{
  if (o is X x)
   ;
}

Ideally, e is T x should be valid anywhere e is T is. (excluding nullables, of course)

Contributor

alrz commented Mar 12, 2017

I think this is also related here (dotnet/roslyn#17746)

void M<T>(T o)
{
  if (o is X x)
   ;
}

Ideally, e is T x should be valid anywhere e is T is. (excluding nullables, of course)

@aluanhaddad

This comment has been minimized.

Show comment
Hide comment
@aluanhaddad

aluanhaddad Apr 1, 2017

@gafter thanks for the work around but I really would like to have this work. I had the exact same experience as @axel-habermaier and it was very frustrating especially as the error was the direct result of applying a built in Roslyn suggested refactoring inside the implementation of a pattern matching API I had written. I realize it's probably a bug in the analyzer but that really compounded the frustration since the match expression in VS 15 Preview had actually obviated the need for the API entirely.

aluanhaddad commented Apr 1, 2017

@gafter thanks for the work around but I really would like to have this work. I had the exact same experience as @axel-habermaier and it was very frustrating especially as the error was the direct result of applying a built in Roslyn suggested refactoring inside the implementation of a pattern matching API I had written. I realize it's probably a bug in the analyzer but that really compounded the frustration since the match expression in VS 15 Preview had actually obviated the need for the API entirely.

@CyrusNajmabadi

This comment has been minimized.

Show comment
Hide comment
@CyrusNajmabadi

CyrusNajmabadi Apr 1, 2017

@aluanhaddad We discussed this in the LDM, and we believe this is an issue that definitely should be addressed. @gafter's comment was more about what you could do in the meantime to unblock yourself. We'll hopefully get this addressed in a upcoming release of VS (hopefully the next one :)).

Note: we've hit this issue in our own code, so we definitely feel your pain and understand why you'd want this fixed :)

CyrusNajmabadi commented Apr 1, 2017

@aluanhaddad We discussed this in the LDM, and we believe this is an issue that definitely should be addressed. @gafter's comment was more about what you could do in the meantime to unblock yourself. We'll hopefully get this addressed in a upcoming release of VS (hopefully the next one :)).

Note: we've hit this issue in our own code, so we definitely feel your pain and understand why you'd want this fixed :)

@aluanhaddad

This comment has been minimized.

Show comment
Hide comment
@aluanhaddad

aluanhaddad Apr 1, 2017

@CyrusNajmabadi Thank you. I'm really glad to hear that this is likely to be resolved soon. That is excellent news!

aluanhaddad commented Apr 1, 2017

@CyrusNajmabadi Thank you. I'm really glad to hear that this is likely to be resolved soon. That is excellent news!

@CyrusNajmabadi

This comment has been minimized.

Show comment
Hide comment
@CyrusNajmabadi

CyrusNajmabadi Apr 1, 2017

I'm really glad to hear that this is likely to be resolved soon.

Yup! Though note the standard caveats about not being able to guarantee anything, and the future may change blah blah blah. But i'm crossing my fingers that this smoothly slots into the 7.1 release.

CyrusNajmabadi commented Apr 1, 2017

I'm really glad to hear that this is likely to be resolved soon.

Yup! Though note the standard caveats about not being able to guarantee anything, and the future may change blah blah blah. But i'm crossing my fingers that this smoothly slots into the 7.1 release.

@aluanhaddad

This comment has been minimized.

Show comment
Hide comment
@aluanhaddad

aluanhaddad Apr 1, 2017

Though note the standard caveats about not being able to guarantee anything, and the future may change blah blah blah.

Indeed. Deadlines get missed. If that were a cardinal sin in our industry I probably wouldn't even have a job anymore.
EDIT: This remark was intended to be humorous and taken lightly.

aluanhaddad commented Apr 1, 2017

Though note the standard caveats about not being able to guarantee anything, and the future may change blah blah blah.

Indeed. Deadlines get missed. If that were a cardinal sin in our industry I probably wouldn't even have a job anymore.
EDIT: This remark was intended to be humorous and taken lightly.

@gafter gafter added the Proposal label Apr 10, 2017

gafter added a commit to gafter/roslyn that referenced this issue Apr 18, 2017

Relax conversion requirements for pattern-matching involving type par…
…ameters.

Fixes #16195
This is a language change for 7.1. See dotnet/csharplang#154.
Some tests may fail until #18756 is integrated.

gafter added a commit to gafter/csharplang that referenced this issue Apr 18, 2017

gafter added a commit that referenced this issue Apr 18, 2017

@gafter gafter removed the Proposal label Apr 18, 2017

@gafter

This comment has been minimized.

Show comment
Hide comment
@gafter

gafter Apr 18, 2017

Member

I have added a proposal for this, and a PR exists for it in the Roslyn repo at dotnet/roslyn#18784.

Member

gafter commented Apr 18, 2017

I have added a proposal for this, and a PR exists for it in the Roslyn repo at dotnet/roslyn#18784.

@gafter gafter changed the title from Champion "permit pattern match of expression of type T:base with type derived" to Champion "pattern-matching with generics" Apr 18, 2017

gafter added a commit to dotnet/roslyn that referenced this issue May 8, 2017

lachbaer added a commit to lachbaer/roslyn that referenced this issue May 15, 2017

Squashed commit of the following:
commit a3ccae515e13bd3b271e692d12d971de544f0673
Merge: 2469eda 9437cf8
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 15 15:45:49 2017 -0700

    Merge pull request #19481 from CyrusNajmabadi/constructorWork

    Remove code for generating constructors from class-decl, it will be provided by another refactoring.

commit 2469edaedf61358c52eda24104731a51cda21d8a
Merge: eb4dc6c 1fccde6
Author: Shyam N <shyamnamboodiripad@users.noreply.github.com>
Date:   Mon May 15 13:54:11 2017 -0700

    Merge pull request #19365 from shyamnamboodiripad/FixMultiFileMethodInstrumentation

    Fix instrumentation for methods that have spans in multiple files.

commit eb4dc6c287991e73263c54da5249fb37471b838f
Merge: 658c728 52bbfde
Author: Tomáš Matoušek <tmat@users.noreply.github.com>
Date:   Mon May 15 13:17:31 2017 -0700

    Merge pull request #19468 from tmat/Cleanup2

    Adds internal Compiler.CommonWithMetadataImportOptions and removes SymUnmanagedExtensions

commit 658c72864e2f97e019530ecac80424082875d781
Merge: efd193c c757297
Author: Srivatsn Narayanan <srivatsn@users.noreply.github.com>
Date:   Mon May 15 11:28:24 2017 -0700

    Merge pull request #19401 from tmeschter/FixAnalyzerNodeHookup

    Use file path to hook up analyzers nodes in Solution Explorer

commit efd193c20b5648399c05597e86fb94d776f32f5f
Merge: bf7aaaf 6e011f2
Author: Artur Spychaj <drognanar@gmail.com>
Date:   Mon May 15 10:30:05 2017 -0700

    Merge pull request #19448 from drognanar/mergeempty

    Delete the PR branch if nothing to merge

commit bf7aaaf4bef16d4fb0c8a196d84733b80f130f29
Author: Jared Parsons <jaredpparsons@gmail.com>
Date:   Fri May 12 05:58:23 2017 -0500

    Switch to DO / DO NOT style

commit 8df2faf8fa650de4aeb71a5985ce4331f03f7ba6
Author: Jared Parsons <jaredpparsons@gmail.com>
Date:   Thu May 11 14:45:17 2017 -0500

    Meet the intention of CONTRIBUTING.md

    The intent of CONTRIBUTING.md is to provide guidelines for contributing to a
    repository.  Ours was a mix of guidelines, best practices and developer
    workflow.  The other aspects are already covered in our other contributing
    documents.

    Changing CONTRIBUTING.md to be guideline focused.

commit ea26f478243f8b6f1c402fe8b24440cc1d88aab2
Author: Jared Parsons <jaredpparsons@gmail.com>
Date:   Thu May 11 14:14:29 2017 -0500

    Copying content from WIKI

commit 28f00685b48deabb3b15f05f954fa327c4dcbea1
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Mon May 15 00:38:46 2017 -0700

    Mark recently completed C# 7.1 features as such (#19483)

commit 9437cf870fc43f7d2713dc3484daf363b4eaa3d2
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 14 01:24:33 2017 -0700

    Remove unused usings.

commit 9781c815ca88ce24d52591be328931a6247a3d76
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 14 01:24:17 2017 -0700

    Simplify code.

commit cddbd90f7ff9459420e422c9ad26699c88ccba3c
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 14 01:14:40 2017 -0700

    Add comments

commit 23fa44446c18012e84a91dcf2c8007fb38e05faa
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 14 01:10:35 2017 -0700

    Add comment

commit 9e95f3c670da3a913c137a4e03aa962885608e5a
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 14 01:07:42 2017 -0700

    Add comment

commit c46b37e254495e07030d47f2725365ddff40017e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:52:46 2017 -0700

    Fixup C# tests.

commit fac36fe8af6524532478f8c5bc72ca77a6403614
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:39:16 2017 -0700

    Fixup C# test code.

commit 62705b3f98febe6ea6a7cb0ad17b7ad011d8901f
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:37:37 2017 -0700

    Fixup test code.

commit 82373c8fb5f8f72c1e717277a8f7669abcec3496
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:35:39 2017 -0700

    Move type.

commit a315a6494ea7c134a705cd4c0db8821e48b0ddbf
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:34:18 2017 -0700

    Fixup VB tests.

commit 5865073828113c6dc96c73fc8eef421cc1f3373d
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:21:11 2017 -0700

    Don't add punctuation in code.

commit c81dfd31b343b5224b894c972ce1773a97d5d9a6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:19:48 2017 -0700

    Remove unneeded code.

commit 4c2862c19c16bdedddd4cadcf53a7f1d74b749e7
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 15:10:04 2017 -0700

    Move delegated constructor responsibility to the refactoring provider.

commit 54d97ddd742108b1e971576596539b6b736df4fb
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 13 14:29:41 2017 -0700

    Remove code for generating constructors from class-decl, it will be provided by another fixer.

commit c0d1472709972eee8c416ac6fe9884603fc6e2f7
Author: Matt Ellis <matell@microsoft.com>
Date:   Fri May 12 16:22:58 2017 -0700

    Pass build configuration when publishing bootstrap compiler

    Without this, we always end up publishing the debug version of the
    compiler.

commit a2e2bf45c31a7f91626017296d5e247631e92886
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Fri May 12 19:03:32 2017 -0700

    Remove refout package moniker from build (#19469)

commit d757e2eb29205f42ab4de318afbdb12ab5461e3f
Merge: 89d6bba 039cdb4
Author: Heejae Chang <heejaechang@outlook.com>
Date:   Fri May 12 15:38:25 2017 -0700

    Merge pull request #19466 from heejaechang/fixTS

    fixed crash on TS due to missing designer attribute service on OOP

commit 52bbfde6011cda1ece8a51420fdfacf00844253a
Author: Tomas Matousek <tomat@microsoft.com>
Date:   Fri May 12 13:55:33 2017 -0700

    Delete SymUnmanagedReaderExtensions.cs

commit 9c9e1830c5a3e0a55b98bfa013ee56cce13bb208
Author: Tomas Matousek <tomat@microsoft.com>
Date:   Fri May 12 13:39:29 2017 -0700

    Add CommonWithMetadataImportOptions

commit 89d6bba7d331af2e03b2de6c9db51443c9883703
Merge: 2ea8ebb f67c247
Author: Tom Meschter <tom.meschter@valinor.org>
Date:   Fri May 12 13:32:33 2017 -0700

    Merge pull request #19450 from tmeschter/FilterProjects

    Filter projects based on language name

commit 039cdb496d3f71351b18e72414ff93030105af50
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 12 13:32:31 2017 -0700

    fixed crash on TS due to missing designer attribute service on OOP

commit 1fccde6304fb6bc5b3e6add6dc301332b6564972
Author: Shyam N <gnamboo@microsoft.com>
Date:   Mon May 8 23:47:41 2017 -0700

    Add VB tests for instrumentation of methods with spans in multiple files.

commit 24e7bb61c212e7da8589eb68d8ef90e362c76a55
Author: Shyam N <gnamboo@microsoft.com>
Date:   Mon May 8 21:13:59 2017 -0700

    Add C# tests for instrumentation of methods with spans in multiple files.

commit 88cc266e5441fbeaf49e6c2210f2356d763f0ee3
Author: Shyam N <gnamboo@microsoft.com>
Date:   Mon May 8 18:56:39 2017 -0700

    Fix instrumentation for methods that have spans in multiple source files.

    A single method could have spans in multiple source files. For example, synthesized constructors of partial types can have spans in multiple files if this type has field initializers in multiple files. Another example is methods with #line directives.

    This change changes instrumentation for such methods - the instrumented IL for such methods will now include a call to a new overload of Microsoft.CodeAnalysis.Runtime.Instrumentation.CreatePayload() that accepts an array of file indices as opposed to single file index.

commit 2ea8ebbc5ac5f860d690c6b2c05be19e0812461b
Merge: 722f011 89ad231
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Thu May 11 19:01:40 2017 -0700

    Merging ref assemblies feature into master

commit 722f01199cb976771a3d0f2082c497a16ae168ca
Merge: 3506fca 2458ada
Author: Vladimir Sadov <vsadov@microsoft.com>
Date:   Thu May 11 17:41:18 2017 -0700

    Merge pull request #19440 from VSadov/fix19434

    Regression test for #19434 which appear to be fixed.

commit 3506fcadb84238a28e7502590ca9c25436df6af0
Merge: 9c6b618 125ac47
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 16:40:06 2017 -0700

    Merge pull request #19426 from CyrusNajmabadi/blockSimplification

    	Respect user settings around 'Blocks' when adding parameter null checks.

commit 9c6b6181767ccda701a39a1886655c1623e6e1f2
Merge: 781c5b0 1da5b30
Author: Heejae Chang <heejaechang@outlook.com>
Date:   Thu May 11 16:10:00 2017 -0700

    Merge pull request #19311 from heejaechang/BulkSync

    Made OOP to handle initial solution case better and made it to have better perf.

commit 781c5b0e7897dfa07644c3c760e5a24823baaaed
Merge: 8dae01b 5b693df
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 15:26:06 2017 -0700

    Merge pull request #19446 from CyrusNajmabadi/nullPaths

    Be resilient to documents/projects with null-filepaths in our persistence layer.

commit 8dae01b8c5cfdbf1442f329d606e159055cf2b10
Merge: d15e1a6 d526325
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 15:04:11 2017 -0700

    Merge pull request #19408 from CyrusNajmabadi/nullMetadataInfo

    Do not pass around null SymbolTreeIndices.  Instead, pass around empty ones.

commit 1da5b30a2628cd8168e7206e98cce9f2e031ecb4
Author: Heejae Chang <hechang@microsoft.com>
Date:   Thu May 11 14:58:53 2017 -0700

    added comments

commit 5b693dfa003723bfe2d3bf4087bde1bae84a4fce
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 14:32:52 2017 -0700

    Disable tests.

commit 3fb3205096b9ef80fa31fff4633ce4671c345b78
Merge: f1979f7 d15e1a6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 14:32:03 2017 -0700

    Merge remote-tracking branch 'upstream/master' into nullPaths

commit 125ac47e1ca1831093cb5152eb6d589e51111794
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 14:31:31 2017 -0700

    Disable tests.

commit 902da97941026612684c12c4276fbc1c6d7ce636
Merge: fdc02b9 d15e1a6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 14:30:54 2017 -0700

    Merge remote-tracking branch 'upstream/master' into blockSimplification

commit d5263256edc41bd07dff1ae26a3eb59593a958bb
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 14:30:14 2017 -0700

    Disable all tests.

commit 6e011f2cf3a45534c03abc42e782f48052a4e6fe
Author: Artur Spychaj <drognanar@gmail.com>
Date:   Thu May 11 14:10:49 2017 -0700

    Delete the PR branch if nothing to merge

commit f67c2474a3cb6bec0e5d5a320c370b9564a06be6
Author: Tom Meschter <tom.meschter@microsoft.com>
Date:   Thu May 11 14:17:01 2017 -0700

    Filter projects based on language name

    Avoids [VSO bug 433873](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/433873).

    When mapping an `IVsHierarchy` to the related Roslyn project we end up asking each project for its associated `IVsHierarchy` and checking if various properties match up with those on the "origin" hierarchy. The properties supported and the interpretation of their values varies from one project system to another. The `HierarchyItemToProjectIdMap` class was implemented when Roslyn only supported C# and VB projects, and was designed with those in mind. Now that TypeScript can also have Roslyn projects we need to filter out everything that isn't C# or VB or we risk asking for properties that aren't supported or possibly misinterpret the values.

commit 7a208ac48da840d2bf76e25f08e08ad9dcba7ec8
Merge: 0974be1 d15e1a6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 13:59:42 2017 -0700

    Merge remote-tracking branch 'upstream/master' into nullMetadataInfo

commit 89ad231429a95b5511dbc052ec4e6aa61e5ed66b
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Thu May 11 13:57:31 2017 -0700

    Refout: Re-enable NoPia, add tests from feature review (#19416)

commit d15e1a6bee5a87d1d6a08d1bd053d5f58a261c40
Merge: ca449a6 7a7210d
Author: Ty Overby <ty@pre-alpha.com>
Date:   Thu May 11 13:54:33 2017 -0700

    Merge pull request #19436 from dotnet/features/async-main

    Merge Features/async main

commit f1979f7a352c0a59afa900aef82b2af0eaed6eab
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 13:52:08 2017 -0700

    Add comments.

commit f125368c2951def311bd0796189a88a1bd3857ca
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 13:45:14 2017 -0700

    Add tests.

commit 0d01ae98b23a62ebc93785e3f8610d6d637631df
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 13:26:07 2017 -0700

    Be resilient to null-paths/names for Documents/Projects in SqlitePersistence layer.

commit ca449a6b323d0bc4aa3ed699521419a45da04a92
Author: Ivan Basov <basov@hotmail.com>
Date:   Thu May 11 13:22:32 2017 -0700

    Disabling flakey tests covered by #19441 (#19442)

    tests only. no ask mode approval is required. thanks!

commit c757297b2884a9d2c15124a3053b58645f0daca4
Author: Tom Meschter <tom.meschter@microsoft.com>
Date:   Thu May 11 13:02:14 2017 -0700

    Extract out the ExtractAnalyzerFilePath method

    Move the method to its own type (`CpsUtilities`) and add some basic unit tests.

commit fdc02b9b030f4dfd72e56c640488d912e16a00eb
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 12:46:08 2017 -0700

    Add simplification tests.

commit baa7ebdbda0bb2a47c226e16c0380a97d6cb019a
Merge: 8b18ed2 bedaa5e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 11:56:12 2017 -0700

    Merge remote-tracking branch 'upstream/master' into blockSimplification

commit 0974be1916e4527c00ed05b70448ee675dc4ce55
Merge: 4ddfe1f bedaa5e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 11:24:41 2017 -0700

    Merge remote-tracking branch 'upstream/master' into nullMetadataInfo

commit 2458ada36410a3408bbca826a74ab0b1c6750f18
Author: vsadov <vsadov@microsoft.com>
Date:   Thu May 11 11:23:10 2017 -0700

    Regression test for #19434 which appear to be fixed.

    Closes:#19434

commit bedaa5e65590ef7e8fc2118194d1ee3226f5952c
Merge: fa407a6 4a1b805
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 10:07:59 2017 -0700

    Merge pull request #19379 from CyrusNajmabadi/useThrowExtraStatemnets

    Use-throw-expression should not be offered when the 'if-block' has additional statements in it

commit 8b18ed2518267c39fd6881506fce2aca836871e5
Merge: 451641b fa407a6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 10:03:31 2017 -0700

    Merge remote-tracking branch 'upstream/master' into blockSimplification

commit fa407a64a236e232a9eba68e5515d67f8e80e8a2
Merge: 8b6e74a db8ed0f
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 11 10:03:07 2017 -0700

    Merge pull request #19424 from CyrusNajmabadi/poolSimplifiers

    Pool the simplifiers we use when simplifying code.

commit 8b6e74aab0bf625f9afcbd5637c1cfd0d80ae543
Merge: 3527fbb 9364b8c
Author: Kevin Pilch <me@pilchie.com>
Date:   Thu May 11 09:17:25 2017 -0700

    Merge pull request #19264 from alrz/bug-19225

    Preserve trivia when converting a numeric literal base

commit 7a7210dcffb9d110d3589d89dc419ee40d814633
Merge: a34367f b0249ee
Author: Ty Overby <ty@pre-alpha.com>
Date:   Thu May 11 09:11:26 2017 -0700

    Merge branch 'features/async-main' of github.com:dotnet/roslyn into features/async-main

commit a34367fa7b0f67f23cef8799bb1dce445a618e9a
Merge: e01e55a 3527fbb
Author: Ty Overby <ty@pre-alpha.com>
Date:   Thu May 11 09:10:31 2017 -0700

    Merge branch 'master' into features/async-main

commit b0249eef9b8ef140dedc20d83c06e6c1ba36023e
Author: Ty Overby <ty@pre-alpha.com>
Date:   Thu May 11 09:09:10 2017 -0700

    Remove remaining prototype comments (#19392)

    * remove remaining prototype comments, add extension method tests

    * fix old test, address review feedback

    * ReturnType implemented on each subclass

    * added more tests on non-async task returning mains

    * add obsolete tests

    * autoformat

    * add better tests for successful task overrides

commit 3527fbb4f1509eef5359dd02e845e9a8268f567b
Author: Jonathon Marolf <jmarolf@microsoft.com>
Date:   Wed May 10 13:04:42 2017 -0700

    removing no warn for type conversions

commit 1c66e3360b0c5f26776b66016dee89d7a4bf5a3f
Author: Jonathon Marolf <jmarolf@microsoft.com>
Date:   Wed May 10 12:26:48 2017 -0700

    setting option strict to on

commit 5b08615a30853298856909d146f5e616b0faba5a
Author: Jonathon Marolf <jmarolf@microsoft.com>
Date:   Wed May 10 08:29:50 2017 -0700

    setting default VB options

commit 841044b0dfb54d9a1af317bd87cb5710150e6001
Author: Neal Gafter <neal@gafter.com>
Date:   Wed May 10 22:47:56 2017 -0700

    Share pattern-matching temps when they are the same type. (#19378)

    Fixes #19280

commit 451641b3ab82b091736e3129b5cf88bd970e2106
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 21:20:03 2017 -0700

    Respect user settings around 'Blocks' when adding parameter null checks.

commit db8ed0ffb9655a7f07e26ea8f47798e70bf314b2
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 18:52:43 2017 -0700

    Revert change.

commit 90941898ddd98588ead4fb5f3574d3c7d2e587c5
Merge: be8d91b ea768e0
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 18:50:39 2017 -0700

    Merge branch 'cacheDelegates' into poolSimplifiers

commit ea768e052c5083e17920adb2b73836c70f9c9217
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 18:49:36 2017 -0700

    Fix null ref.

commit be8d91b6b7e08e5b1a026de636ab8e9f38291758
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 18:49:36 2017 -0700

    Fix null ref.

commit 8e4e29b08d6608fecd2f415f1abec66e71689764
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 18:47:30 2017 -0700

    Pool the simplifiers we create while simplifying code.

commit 71c8e3e2cf575647e8573f1fe633ec3bfe139de6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 17:29:34 2017 -0700

    Cache the delegates we use in simplification.

commit 4ddfe1fd78ef0badafe20d4e8e3f498dc3a678d2
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:39:22 2017 -0700

    Fix comparison.

commit 51de32fb9afb742a3e6e9889a4f9ca78536969f0
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:38:55 2017 -0700

    Rename parameter.

commit e01e55ab553185e2cec87f0e7c68f31d5680139e
Merge: 61514ee 2223e15
Author: Ty Overby <ty@pre-alpha.com>
Date:   Wed May 10 15:21:58 2017 -0700

    Merge branch 'master' into features/async-main

commit c0adc6242fff999e0dc84d2aac1ee6d52ffaf2a3
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:19:15 2017 -0700

    Simplify code.

commit 8b7ad834409d5c3434fb6aeea11e699ec3d7d96e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:16:03 2017 -0700

    Don't require spell checker.

commit b4c9c9e6c5399dec4016c7e17c3dce80d6880413
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:10:29 2017 -0700

    Add more contract guarantees

commit 9862f3605f79d50dfc8b6bd67fb11077a73cdf10
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:02:59 2017 -0700

    Share code.

commit c10565ecf1d0f769d74f62b373db9d760906b82f
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:01:16 2017 -0700

    Fix grammar.

commit a785172867b340542dfc7162564d1dce3c7f3b07
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 15:00:28 2017 -0700

    Take an approach where we cannot get Null Symbol Tree infos.

commit 174035e6e9774b024bb07b6a67ee1298e83948cc
Author: Heejae Chang <hechang@microsoft.com>
Date:   Wed May 10 14:56:17 2017 -0700

    fix build break.

commit 737d993c1e67d42e9b86e9cd4e6f5a7d0bbe8a7e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 14:28:34 2017 -0700

    Store a copy of the checksum as we may have failed to create an index for a piece of metadata.

commit 934fbe934b4833e8cf991a3fdfdd3170fc0313a1
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 14:21:16 2017 -0700

    Createing indices for metadata can fail.  Be resilient to that.

commit 71a9fc8e967e1ec8ac11b96cb8ae773123a0ecef
Merge: 11f3f8a 2223e15
Author: Heejae Chang <hechang@microsoft.com>
Date:   Wed May 10 14:03:22 2017 -0700

    fixed merge conflicts

commit 11f3f8abdf68ae34dd3a2350807367cf0223291b
Author: Heejae Chang <hechang@microsoft.com>
Date:   Wed May 10 14:00:19 2017 -0700

    add assert

commit 6a3f93458b173804209dc773283cc76d74907b0b
Author: Heejae Chang <hechang@microsoft.com>
Date:   Wed May 10 13:56:11 2017 -0700

    added more comments

commit 2223e15607ec068e17c23dc6aa9718a8366dcb80
Merge: 7c50394 1cbe2ce
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Wed May 10 13:47:39 2017 -0700

    Merge pull request #19396 from mavasani/FixBuildBreak

    Re-enable roslyn analyzers on Roslyn.sln and update public api file f…

commit 7c5039453c6af7dd78d47fb372da402a083f73bb
Author: Ivan Basov <basov@hotmail.com>
Date:   Wed May 10 13:43:49 2017 -0700

    Migrate BasicEditAndContinue integration tests from Tao to .NET (#19381)

    Tests only. No ask mode approval is required.

commit ab924b3d69ea7d1ac27864a428d3b55255578c26
Merge: a404917 eddbafc
Author: Fred Silberberg <fred@silberberg.xyz>
Date:   Wed May 10 13:11:21 2017 -0700

    Merge pull request #19366 from 333fred/info-bar-refactor

    Refactored IErrorReportingService

commit 4a1b805ff47f6e25cd9ebb3cb4c81d35c25f36ce
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 12:30:40 2017 -0700

    Simplify check.

commit a4dbea3760cc7b3f3093957312077876a59959d8
Author: Tom Meschter <tom.meschter@microsoft.com>
Date:   Wed May 10 12:29:24 2017 -0700

    Use file path to hook up analyzers nodes in Solution Explorer

    Fixes https://github.com/dotnet/project-system/issues/2062.

    Currently we match a hierarchy node representing an analyzer in Solution Explorer up to the proper Roslyn `AnalyzerReference` based on the "display name"--basically, the name of the assembly without the extension. This mostly works, but you can run into problems if a project uses two different versions of the same analyzer, each with a different set of diagnostics. In this case expanding one of the analyzer nodes in Solution Explorer will show you the wrong set of diagnostics for one or the other, since they both have the same display name.

    To uniquely identify an analyzer assembly we should use its full path rather than the display name. However, the project system initially didn't expose the full path through the hierarchy node. This has been fixed, and now the full path is one of the components of the node's "canonical name", along with other bits of information such as the project directory and target framework.

    This commit updates our code to extract and use the full path instead of the display name.

commit f61d8c491dae3d5adb85fd225cead7ba2afc2461
Merge: 9b9f11b 5e053aa
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 12:22:15 2017 -0700

    Merge remote-tracking branch 'upstream/master' into useThrowExtraStatemnets

commit a404917ee48210eda868e2423afb679eefa83cf7
Merge: 5e053aa 969b5cb
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Wed May 10 12:21:34 2017 -0700

    Merge pull request #19374 from CyrusNajmabadi/serializationSimplification

    Simplify serialization.

commit eddbafc4594b3e00d0e14f0e082e28ea60fe6fce
Author: Fredric Silberberg <frsilb@microsoft.com>
Date:   Wed May 10 12:15:15 2017 -0700

    Addressed pr feedback, export parts as shared and in the correct layer.

commit 5e053aaf90864362af42d3d7d7b45040e4595fb8
Author: Ty Overby <ty@pre-alpha.com>
Date:   Wed May 10 11:22:55 2017 -0700

    remove _showPosition (#19353)

commit 1cbe2ce2b0eb9edc9022ffd8a69e65586570f499
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Wed May 10 10:53:27 2017 -0700

    Re-enable roslyn analyzers on Roslyn.sln and update public api file for an IOperation API change merged yesterday (#19278).

commit f67bfae237fba950c0cc8732a31e81daba5bf539
Author: Heejae Chang <hechang@microsoft.com>
Date:   Wed May 10 10:53:20 2017 -0700

    fix build break and add test

commit 61514ee334d401c217604342c85e67ff52539bf2
Merge: cc4ea46 a33479e
Author: Ty Overby <ty@pre-alpha.com>
Date:   Wed May 10 10:15:28 2017 -0700

    Merge branch 'master' into features/async-main

commit d18aa159ca3810b1e0eaa9c74e38c8d0b93e9f9c
Merge: a33479e 36d55d1
Author: Ravi Chande <rchande@microsoft.com>
Date:   Wed May 10 10:15:17 2017 -0700

    Merge pull request #19296 from rchande/revertquickinfo

    Revert "Merge pull request #10993 from rchande/quickinfosession"

commit 124865bf9b87e71972e7af9ca278385ac1a6a529
Author: Heejae Chang <hechang@microsoft.com>
Date:   Wed May 10 09:46:36 2017 -0700

    updated following PR feedback

commit a33479e6642b1a3ed6b254b5981db307adf40f1a
Merge: b68f678 72df260
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Wed May 10 09:44:13 2017 -0700

    Merge pull request #19307 from mavasani/DelegateCreationExpression

    Fix analysis of IOperation descendants for BoundDelegateCreationExpre…

commit cc4ea4693cf28b60daf31113c680bdbd55d081cb
Author: Ty Overby <ty@pre-alpha.com>
Date:   Wed May 10 09:41:55 2017 -0700

    Entrypoint detection stages (#19093)

    * simplify partial method return type syntax finder tests

    * Bug fixes and API use changes

    * address first review

    * better comment and compiler trait on class

    * fix tests, pull entrypoint check out into local function

    * unify diagnostics for intvoid or task mains

    * add more tests, change error text

    * address review

    * finish tests

    * be explicit on language version in tests

    * add another test, fix typo, add diagnostics even when they aren't likely to exist

    * rewrite error->warning code, add more cases to tests

    * change test language versions

    * formatting on comments and adding WithLocation to tests

    * fix formatting for some tests

    * fix some formatting and added withlocation

    * fix withlocation

commit b68f6782714a3909e39d57074a9197285e581349
Merge: c16e998 5d02788
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Wed May 10 10:36:22 2017 -0500

    Merge pull request #19259 from sharwell/concurrent-analyzer

    Allow the Simplify Type Names analyzer to run concurrently

commit 9364b8c6c0320da0c99c9a0642185992da43108e
Author: Alireza Habibi <habibi.alireza@outlook.com>
Date:   Wed May 10 17:46:52 2017 +0430

    PR feedback

commit 969b5cb1be9e60269b735c9fad135d66e4f566ad
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 17:33:19 2017 -0700

    Simplify code.

commit a7ca8fd0fe286a7bd5415d400c23bbb6554f251a
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 17:32:44 2017 -0700

    Formatting.

commit b3495e9c7147d28c0f81cfd5fa58b517caaeedf6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 16:51:57 2017 -0700

    Restore logic.

commit 9b9f11b24274a8a5ba472a100d93dbd7ff3b76b9
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 16:38:18 2017 -0700

    Use-throw-expression should not be offered when the 'if-block' has additional statements in it.

commit 38925ac96f71b1d1bcbf9a5b548a80341033cc14
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:44:57 2017 -0700

    Adding comment.

commit 7551ad2b3f3b18a83be7626cc9f3b84af00654b4
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:40:16 2017 -0700

    Fix code.

commit 230d93532f3f2a54732aa9e25326a46f733ff234
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:39:51 2017 -0700

    Simplify

commit c920455ca95adf61f7b29d6750d1067cad8a7dea
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:39:19 2017 -0700

    Actually make into a struct.

commit ba6b8b105d52abd7bb3126f714f58951de485f68
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:36:34 2017 -0700

    Fix spelling

commit c16e9988a92a139302bacf652adf9dc66a3e3970
Merge: bc9be6c 1d9b64a
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Tue May 9 15:33:09 2017 -0700

    Merge pull request #19278 from mavasani/ObjectCreationExpression

    IObjectCreationExpression API Change

commit 20f0557760b07680f94a6a6482a7cbb1b53d34ef
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:32:55 2017 -0700

    Make our reference maps less overhead.

commit 2d2fed797708cf124efe99349c7850a34794feb8
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:26:17 2017 -0700

    No need to return values here.  They are never used.

commit 6f1baf8b90cf78233b52614761b4c0b59783a601
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:22:39 2017 -0700

    Write out less data for objects.

commit 4644b5bfd2280fdaa58aa47bb3b22b234e42d7ba
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:03:56 2017 -0700

    Inline method

commit 75c9f0d2b68c648a24a77d74393d66741680e9d7
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:03:08 2017 -0700

    Inline method

commit 57eca79980cbbfba569e50f72d286d2144cacecb
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Tue May 9 15:01:49 2017 -0700

    Simplify serialization.

commit bc9be6c070f488b63e8ac1126d712c75027a3e40
Merge: 3986cdb c6f25f6
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Tue May 9 16:41:17 2017 -0500

    Merge pull request #19258 from sharwell/candidate-test

    Verify member is in scope before trying to replace it

commit 7642cb0211cf0461c885ca4bdc03bcd415fdc06a
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 13:47:20 2017 -0700

    fixed release mode build break

commit c1bfe6f3caea206275af989fd095230ed5677650
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 13:47:09 2017 -0700

    added boost service in service hub

commit b4ae4feee48f030b738224b5f772613bb0876b05
Author: Fredric Silberberg <frsilb@microsoft.com>
Date:   Tue May 9 13:27:59 2017 -0700

    Added missing csproj edits

commit c6f25f62941c5fbf9c9e024319a305bd3f785482
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Tue May 9 14:19:14 2017 -0500

    Disable test for simplifier edge case

    See dotnet/roslyn#19368

commit 4a0eea3bbeef286049c8f9e4ed452e87ce205fcc
Author: Fredric Silberberg <frsilb@microsoft.com>
Date:   Tue May 9 13:20:45 2017 -0700

    Cleaned up documentation

commit d69c102665ba12b7ba920dfd5e3b4c47d04b6af2
Author: Fredric Silberberg <frsilb@microsoft.com>
Date:   Tue May 9 13:15:17 2017 -0700

    Moved VisualStudioInfoBarService, exported as workspace service

commit e9053e6b088fe4327ac68006e2763efcef39e70a
Author: Fredric Silberberg <frsilb@microsoft.com>
Date:   Tue May 9 13:09:18 2017 -0700

    Moved EditorInfoBarService to its own folder, export as workspace service

commit 3986cdb6c061ecc79680967e1a7757e64b6888f2
Author: Tomáš Matoušek <tmat@users.noreply.github.com>
Date:   Tue May 9 10:39:27 2017 -0700

    Implement SourceLink for Windows PDBs (#18539)

commit ddd68b6e04dfd1d936b4b01aafac700041f3cea8
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 10:04:15 2017 -0700

    fix test failure

commit 43c608321d68c8ce7ba8ed5c7bf06bcb89181d08
Merge: d0490d7 0d6f96a
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 09:40:50 2017 -0700

    Merge branch 'master' of https://github.com/dotnet/roslyn into BulkSync

commit 0d6f96aa4bd85f4c616c616e0a79e41adf2283c2
Merge: 8bb97a1 a68da9d
Author: Heejae Chang <heejaechang@outlook.com>
Date:   Tue May 9 09:39:56 2017 -0700

    Merge pull request #19277 from heejaechang/OOPPerf

    removed direct Workspace access from WorkspaceAnalyzerOptions and made OOP analyzers to use snapshot of OptionSet

commit 8bb97a1ec8663bb8cfc9d6cf19a03664f754f7da
Merge: c4b1692 db8b8e9
Author: Tom Meschter <tom.meschter@valinor.org>
Date:   Tue May 9 09:19:09 2017 -0700

    Merge pull request #18287 from tmeschter/ActuallyThrowExceptions

    Ensure non-fatal exceptions are actually thrown

commit d0490d7c86c43fa72afad2bfd476d6a1e30530f9
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 06:15:03 2017 -0700

    fix test failures

commit af4121be997236b299e0206b76fd908bd51aceed
Merge: 2bff739 e4b4ea4
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 05:17:33 2017 -0700

    Merge branch 'improvechecksum' of https://github.com/heejaechang/roslyn into BulkSync

commit e4b4ea4ccdd93e7348b1803d5c60109854858d5f
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 05:15:05 2017 -0700

    made document checksum not to use persistant service.

    we found 2 issues. 1. hard to validate persisted data and 2. recalculating checksum is faster than reading from storage.

commit 2bff739821ac58335ca809060e229a9330e5898e
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 02:36:32 2017 -0700

    remove unused usings.

commit 10f3ed2c39e469c12993cf16c3d32d113d9100ff
Merge: 36c013b a68da9d
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 02:33:26 2017 -0700

    Merge branch 'OOPPerf' of https://github.com/heejaechang/roslyn into BulkSync

commit a68da9dbf8fb5cebb7461a271cf6c32d28261cec
Author: Heejae Chang <hechang@microsoft.com>
Date:   Tue May 9 02:32:45 2017 -0700

    follow PR feedbacks

commit 1748167ca26fc41ee4e1bddb2c126ba8f0e15cb3
Merge: 8af036a 3a1beeb
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Tue May 9 01:25:08 2017 -0700

    Pull latest bits from master into refout feature branch

commit 3a1beeb4b9fbe9f87e3b5cf7658a926a95e192cc
Merge: 8af036a c4b1692
Author: Julien Couvreur <julien.couvreur@gmail.com>
Date:   Mon May 8 22:23:09 2017 -0700

    Merge remote-tracking branch 'dotnet/master' into refout-mergemaster

    Conflicts:
    	src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

commit c4b169218de6b57b0e62a1e823637a483d1e0acb
Merge: d6d1efa 98e2c23
Author: Jason Malinowski <jason@jason-m.com>
Date:   Mon May 8 21:40:09 2017 -0700

    Merge pull request #19358 from CyrusNajmabadi/revertChange

    Revert "Merge pull request #18972 from CyrusNajmabadi/docHighlights2"

commit 8af036a83af9cef70a38fc1c59d3ca35388a3972
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Mon May 8 21:32:58 2017 -0700

    Refout: disallow NoPia, best effort determinism, assembly redirect for CopyRefAssembly (#19326)

    * Ref assemblies make a best effort to emit with determinism
    * Fixing CopyRefAssembly message output
    * CopyRefAssembly logs when input isn't ref assembly
    * CopyRefAssembly does assembly redirect.
    * Compact error codes for C# 7.1

commit d6d1efa4eeebef75a0443917581548036ff99607
Author: Tomáš Matoušek <tmat@users.noreply.github.com>
Date:   Mon May 8 21:22:57 2017 -0700

    Update to latest PDB reader/writer dependencies (#19302)

    * Update versions

    * Improve diagnostics

commit fc737a4ae3caa98270de4ff0abc14e6f55b1913d
Merge: ba30bca 8aa521f
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Mon May 8 21:16:44 2017 -0500

    Merge pull request #19357 from CyrusNajmabadi/noTypeScriptIndices

    Do not even attempt to create indices for non-C#/VB projects.

commit ba30bca7de123c048731e9296d05b9b735a4c379
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Mon May 8 18:51:35 2017 -0700

    Tuple name completion should not include colon (#19335)

commit 98e2c2331c3745ca76ecbbe327664df441115f1a
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 18:07:14 2017 -0700

    Revert "Merge pull request #18972 from CyrusNajmabadi/docHighlights2"

    This reverts commit 8262112e63d0c92bfa421bcb49e54b6a791cabbd, reversing
    changes made to 837ca2141fc63d42ea4f6310c07e58624f0ca48a.

commit 435ee7dc08cbefb1c1b450ec0ba0901cd95b26a8
Author: Fredric Silberberg <frsilb@microsoft.com>
Date:   Mon May 8 18:05:28 2017 -0700

    Refactored IErrorReportingService to extract the info bar display logic into IInfoBarService

commit 4fbb078a84876c3132f2a9f2f5ed4471dcdc6c6a
Merge: 8262112 a015d76
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 18:02:25 2017 -0700

    Merge pull request #19291 from CyrusNajmabadi/genVariableOrdering

    Order fields/properties better based on existing class structure.

commit 8aa521fea4de5ed4792854e32b81c9bc1c44de11
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 17:54:23 2017 -0700

    Do not even attempt to create indices for non-C#/VB projects.

commit 8262112e63d0c92bfa421bcb49e54b6a791cabbd
Merge: 837ca21 c7e7b9d
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 17:42:06 2017 -0700

    Merge pull request #18972 from CyrusNajmabadi/docHighlights2

    Move DocumentHighlights (i.e. HighlightReferences) out of process.

commit a015d76f7dc0fb048571da1cc998a5ce7bea42a6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 17:17:34 2017 -0700

    Simplify code.

commit 0a6697e319ea07ada7d0addfdd4db05b8707b195
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 17:15:51 2017 -0700

    Handle this.<name> expressions.

commit 976fc43766e0067b543e238877ab9180614d6c18
Merge: 2260e68 837ca21
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 16:27:50 2017 -0700

    Merge branch 'master' into genVariableOrdering

commit c7e7b9d42eed30469114615be8bdf4fbd642ed36
Merge: e875975 837ca21
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 16:27:25 2017 -0700

    Merge branch 'master' into docHighlights2

commit 837ca2141fc63d42ea4f6310c07e58624f0ca48a
Merge: 2f23f3b c9f2fe8
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 16:26:42 2017 -0700

    Merge pull request #19324 from CyrusNajmabadi/serializationKinds

    Serialization kinds

commit 2f23f3b0ca1dee3599dd1841b6dd465ed5cb1dc8
Merge: fef0f59 c273150
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Mon May 8 18:08:34 2017 -0500

    Merge pull request #18243 from sharwell/document-setters

    Improve support for documentation comments in Replace Property with Methods

commit fef0f59606b7b256ebe5134705aded4b5b64f743
Merge: 9fecc12 1d7c848
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Mon May 8 18:01:19 2017 -0500

    Merge pull request #18363 from sharwell/test-project-guid

    Add "Test" project type GUID to all test projects

commit 9fecc12da9657a2e3b9230b4fdf001cc7b9d50a6
Author: Tomáš Matoušek <tmat@users.noreply.github.com>
Date:   Mon May 8 14:42:10 2017 -0700

    Avoid calling GetDiagnostics on compilation during EnC analysis (#19167)

    Avoid calling GetDiagnostics on compilation during EnC analysis

commit 72df26012c8c7cd18d142d1450c5aca0e80c9c47
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Mon May 8 14:29:00 2017 -0700

    Skip a bunch of failing tests due to the API change and fix an existing test to account for the change

commit a9ced1c59d70808ecb7c041e359c68e4395d20ad
Merge: 79b2bc6 74ffe80
Author: David Poeschl <dpoeschl@gmail.com>
Date:   Mon May 8 14:27:28 2017 -0700

    Merge pull request #19211 from dpoeschl/NamingStylesOnSymbolsWithNoName

    Don't run naming rules on symbols with no name

commit e87597530b1b5323ec2e5ff4eec59ca664ffb2c7
Merge: 08533b0 79b2bc6
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 13:47:11 2017 -0700

    Merge remote-tracking branch 'upstream/master' into docHighlights2

commit 79b2bc6e4b99a302605a5cba7e0abb6f9a005726
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Mon May 8 13:41:50 2017 -0700

    Fix crash with typeless tuple in "as" operator (#18416)

commit 956b17ef42b65bb49c51addb090f1667d1bdf5b9
Merge: 046597c 05d8ee3
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 13:41:29 2017 -0700

    Merge pull request #19313 from CyrusNajmabadi/poolSha1Instances

    Pool byte array used for reading from Stream during checksum calculation

commit 046597cb669d9091adc7a31f5ce062dc7467202e
Merge: a0e6a83 6cfdbb3
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 13:40:47 2017 -0700

    Merge pull request #19285 from CyrusNajmabadi/directiveHandling

    Better handling of directive-trivia in UseExpressionBody/ReplacePropWithMethod.

commit 74ffe806a7798dc92381cbc36fc2c72ea43d2f82
Merge: abfca04 a0e6a83
Author: David Poeschl <dpoeschl@gmail.com>
Date:   Mon May 8 13:35:48 2017 -0700

    Merge branch 'master' into NamingStylesOnSymbolsWithNoName

commit a0e6a8354028d23896c4410b88538de80a757c37
Merge: 2a6c6d0 a29ce9e
Author: David Poeschl <dpoeschl@gmail.com>
Date:   Mon May 8 13:34:08 2017 -0700

    Merge pull request #18890 from dpoeschl/LinkedFileRace

    Ensure linked files are kept in sync in the workspace

commit 2a6c6d082a38b4c1e72c881d6116ae4074862965
Merge: f9b1f75 6c6b25e
Author: David Poeschl <dpoeschl@gmail.com>
Date:   Mon May 8 13:33:33 2017 -0700

    Merge pull request #18693 from dpoeschl/NamingStylesUpdateXAML

    Notify XAML of renames caused by Naming Rule fixes

commit f9b1f756cc9f3a7d6dcdd43a52c8749741ea9666
Merge: e25fd7c fadaba7
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 13:21:20 2017 -0700

    Merge pull request #19325 from CyrusNajmabadi/synchronousFlushing

    Remove forced unecessary asynchrony in flushing data to disk.

commit e25fd7cd2bc0717a76453eb1f13be29f1cf2ee6d
Merge: e02548c c55f9d2
Author: Jonathon Marolf <jmarolf@users.noreply.github.com>
Date:   Mon May 8 12:28:29 2017 -0700

    Merge pull request #19331 from jmarolf/fix-15.3-build

    Fix building on 15.3

commit 05d8ee3fc435844cf8c4f1e1ed7b40f1dee9cd96
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 12:23:32 2017 -0700

    Remove pooling.

commit e66d44c24ee813650ff65476220d36777c8d5cfa
Merge: 8fc3f6e 25fb200
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 12:20:50 2017 -0700

    Merge branch 'master' into poolSha1Instances

commit e02548c6c16ef572e3ac632e28d11d8752a83e6d
Merge: 4011656 021eb94
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 12:12:26 2017 -0700

    Merge pull request #19334 from CyrusNajmabadi/generateBetterNames

    Generate better names for expressions used as parameters.

commit c9f2fe8635251758ceaf0eff638b20fad38a2318
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 12:10:58 2017 -0700

    Simplify code.

commit 5e8c4977a6672cef7eef0dd3e20a5f47ecf07a7f
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 12:09:41 2017 -0700

    Add fast path for ToString for this enum.

commit 4011656d468e44c4b0dbb50d7991c2bd42ae66f6
Merge: 022d70e 20db87a
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Mon May 8 13:54:49 2017 -0500

    Merge pull request #19126 from sharwell/enumerator

    Avoid allocations due to use of Keys/Values instead of GetEnumerator

commit 3ffbbd837e9414204330835320fc27e2ec3108d2
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 11:50:19 2017 -0700

    Rename type.

commit fadaba7dc7aea3d6a4cac16589a20e1e09d2487a
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 11:37:49 2017 -0700

    Be resilient to exceptions getting thrown.

commit d8d06b4e38426d50c38693920a04af0142a8cd55
Merge: a825831 022d70e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 11:20:06 2017 -0700

    Merge remote-tracking branch 'upstream/master' into synchronousFlushing

commit 022d70eec2655573cf6b586e33cf6acaacadc4c3
Merge: 54de6be 22ea867
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Mon May 8 11:12:24 2017 -0700

    Merge pull request #19338 from CyrusNajmabadi/completionInEnumInitializer

    Offer enum completion inside an enum member's initializer

commit 54de6be42f8e42ad3ce114a19afd185daf2ef500
Merge: 499f27a 104499d
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Mon May 8 13:08:42 2017 -0500

    Merge pull request #18924 from sharwell/rm-alloc

    Eliminate delegate allocations in PooledObject.Create

commit 6c6b25ef3f349f0f8a8ad2be9e6ed7ee3632e4fe
Merge: 032548f 499f27a
Author: David Poeschl <dpoeschl@gmail.com>
Date:   Mon May 8 11:00:36 2017 -0700

    Merge branch 'master' into NamingStylesUpdateXAML

commit 1d7c8484a7db9b7231de4618d0c0bb8c96d73fd7
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Sat Apr 1 05:46:56 2017 -0500

    Add the UnitTestContainer capability to all portable test projects

commit 98cc10ca002c9e90d40f79ce28bafbd2dacc76c9
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Sat Apr 1 05:44:35 2017 -0500

    Add the test project GUID to all non-portable test projects

commit 1e2c236bcb19a0004d94b592cf0305485e025a83
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Sat Apr 1 05:34:35 2017 -0500

    Add the language name project type GUID to test projects

commit 499f27ad7ee348a6e51d70f8257deb7711bf7618
Merge: 911adf5 1bb2cbd
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Mon May 8 11:12:20 2017 -0500

    Merge pull request #18307 from sharwell/async-local-function

    Fix support for local functions in "Make Method Asynchronous"

commit 911adf53d971518799d91aee8c044e6733250336
Author: Nick Guerrera <nicholg@microsoft.com>
Date:   Fri May 5 09:07:47 2017 -0700

    Use Target Returns instead of Target Outputs

    The former always has the meaning we want, the latter has it only
    when there are no Returns used anywhere in the same file!

commit b58ba7232f173335e76567231f08a71fa86599b6
Author: Nick Guerrera <nicholg@microsoft.com>
Date:   Thu May 4 17:40:49 2017 -0700

    Restore developer build desktop deployment

commit 4eca316dffd1b6b6de720c6c4b0d34684bb745f6
Author: Jared Parsons <jaredpar@microsoft.com>
Date:   Sat May 6 06:43:10 2017 -0700

    Consume IBCMerge from internal NuGet feed

    This both removes our flaky dependency on a file share and sets us up to
    get updates for the package.

commit 22ea8679ba0effc9f62ddfc628aac6eec5986521
Merge: 868dbf2 25fb200
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 23:40:21 2017 -0700

    Merge branch 'master' into completionInEnumInitializer

commit 2260e685e4c0bbc491cd412d6840aa57d5d44724
Merge: 4e94fcd 25fb200
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 23:32:41 2017 -0700

    Merge branch 'master' into genVariableOrdering

commit 25fb200d8cae49dc62ea30615684d833d37ccbe9
Merge: 02a0942 d3d1860
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:26:58 2017 -0700

    Merge pull request #18557 from kcnygaard/fix-18556

    Fixes #18556 - Invalid code when implementing interface through explicitly-implemented property

commit 868dbf2d4ab172ba98fa5b0d83ca0fb0ff78b2fc
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:17:28 2017 -0700

    invert control

commit 947391a5f25fa9b10337e833aed62f325b06f636
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:13:45 2017 -0700

    Add comments.

commit 16a5445f879f16a5aafdb00ed7a9bf04d8ba447b
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:09:34 2017 -0700

    Add another test.

commit f80c2feed84eba954bb67e6b43a95c0c86f25aba
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:05:44 2017 -0700

    Simplify code.

commit 596c2048025dbde19b0f58d773abdf1e2992193e
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:04:41 2017 -0700

    Simplify code.

commit 17b8156281069f4a515af164ed45a25d8a7f9c18
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 21:02:04 2017 -0700

    Offer enum completion inside an enum member's initializer

commit 02a09423c9ea63bf377caf7acdb9871b12112d4f
Author: Neal Gafter <neal@gafter.com>
Date:   Sun May 7 20:57:24 2017 -0700

    Relax conversion requirements for pattern-matching involving type parameters. (#18784)

    Fixes #16195
    This is a language change for 7.1. See https://github.com/dotnet/csharplang/issues/154.

commit 021eb94e1578f7d023dbfff315bbc426c27a38af
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 20:14:27 2017 -0700

    Restore test.

commit 5141c0bf96ec408d4feeb76b1fcc8eae8d22893a
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 20:13:02 2017 -0700

    Use parameter name only for exactly matching members.

commit d6954fba55bf1e5beb7bd326f64e662ca8337eb0
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 19:19:54 2017 -0700

    Fix warning.

commit e582cbd76c6c17ba49a5a269de529de67259916c
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 19:17:02 2017 -0700

    Add VB tests.

commit 8058ba4ee4076a751385f258d993b6a1ec64d110
Merge: 6a463b2 8cc7daac
Author: Shyam N <shyamnamboodiripad@users.noreply.github.com>
Date:   Sun May 7 17:20:38 2017 -0700

    Merge pull request #19282 from shyamnamboodiripad/FixPartialMethodInstrumentation

    Fix partial method instrumentation

commit 6711f4b720a86928b7a08232643ab9398798649f
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 16:08:35 2017 -0700

    Update VB tests.

commit 60b8f6db2639647ec154f13d66e43b7ac5a56020
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 16:01:55 2017 -0700

    Update tests.

commit 90252df70e9bea134942532b4fbb5e06cdba44a9
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 15:51:47 2017 -0700

    Respect capitalization option.

commit eed61fdf89c70acd780ba3a77091221314d1c941
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 15:41:25 2017 -0700

    Generate better names for expressions used as parameters.

commit 4e94fcddd57cdcfb70be8ebbaa004cdce065bac9
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 14:37:08 2017 -0700

    Add VB tests.

commit 763af90ee6088bf4e3529907c694f26aa3b0ce4a
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 14:29:20 2017 -0700

    Place fields/properties based on surrounding assignments.

commit 6a463b297a87bace4793b1f68b1fa7110b737847
Merge: 4f99e31 618fd16
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 13:23:03 2017 -0700

    Merge pull request #19328 from CyrusNajmabadi/deferCompilationCreation

    Defer creating a compilation if it is not needed.

commit 4f99e31b8c76d851af0ed8b1d1148d43a49a32ef
Merge: be85f32 6e7fbe8
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sun May 7 12:35:58 2017 -0700

    Merge pull request #19322 from CyrusNajmabadi/serializePerf

    Improve performance of tree serialization.

commit c55f9d2b61d19dcfe997708470f8695bfa9309b7
Author: Jonathon Marolf <jmarolf@microsoft.com>
Date:   Sun May 7 05:25:40 2017 -0700

    ignoring BC40057 in Samples.sln

commit b4fc03602e2d197b7a0b3a45eda5deec7b804eba
Author: Jonathon Marolf <jmarolf@microsoft.com>
Date:   Sun May 7 04:01:41 2017 -0700

    fixing implicit comversion errors

commit 4d3d313e3f76faf470c794f67e6319166f551aef
Author: Jonathon Marolf <jmarolf@microsoft.com>
Date:   Sun May 7 00:43:19 2017 -0700

    Ignoring compiler warnings

commit 6e7fbe80e72d3e3e84f7e324666ddeaedb4cac54
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 22:36:15 2017 -0700

    Formatting.

commit 618fd16cf3c547ea9b49f245ddd6d45820e9e9a1
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 21:18:22 2017 -0700

    Add comment.

commit 31d0de2926b5c0b37520b5bc23d143cc89d4c6b7
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 21:12:23 2017 -0700

    Ensure documents are ordered before making checksum.

commit d712cc2ee913d4df8aa9dc8d80df8e4c76faa64d
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 20:17:54 2017 -0700

    Update test

commit 3ac8cb3eda96d994380df96d789daf07a3e0eb44
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 19:59:35 2017 -0700

    Defer creating a compilation if it is not needed.

commit a8258312e2e9334d30091468a74519f9d302be63
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 17:29:23 2017 -0700

    Spelling.

commit 68f4077e5df712dd78828e34fb9e81707204c755
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 17:23:14 2017 -0700

    Remove forced unecessary asynchrony in flushing data to disk.

commit a752d1bbc83708fe8831e455468faa89ebdef5a8
Merge: a91039c de0b9b0
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 16:11:32 2017 -0700

    Merge branch 'serializePerf' into serializationKinds

commit de0b9b01a3884909916763f6773064365dfc26a2
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 16:11:01 2017 -0700

    Fixx test.

commit a91039c1e65a545bdca863e26038584fdd450e0b
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 16:09:40 2017 -0700

    Don't use a string-kind for checksums.

commit 2a736626f986bc55b432a6fc3e19d9a75c71d0bd
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 15:03:35 2017 -0700

    Simplify.

commit 89b38d501440ca416dee1cbd9eac23972c302723
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 15:01:43 2017 -0700

    Inline decl.

commit 0af082f87aec0a39b56a124279ff37508c0e4172
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 14:58:32 2017 -0700

    Simplify.

commit f6df6d59cf2f6c7414e7f9612dcdfb4286339805
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 14:55:48 2017 -0700

    Improve performance of tree serialization.

commit be85f325df614c18a752cc7d024ffa77f04781bd
Merge: d66839d aa9fd5f
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Sat May 6 13:51:54 2017 -0700

    Merge pull request #19289 from CyrusNajmabadi/orderFixes

    Order 'Remove Unused Variable' after 'Add Using'

commit d66839db52902c8cfe3f45c5e47f6212b2cbb6c4
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Sat May 6 12:32:57 2017 -0700

    Pass LangVersion thru ICompilerOptionsHostObject.SetCompilerOptions when above 15 (VB) (#19112)

commit 2cf3be85c54d4d0429389ce796b6c374c686a1a7
Merge: 8bef0a1 b03b5b3
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Sat May 6 11:42:53 2017 -0700

    Pulling latest bits from master into refout feature branch

commit b03b5b34508335b3762420c3d5aeeae63c1d1711
Merge: 8bef0a1 86c7d6c
Author: Julien Couvreur <julien.couvreur@gmail.com>
Date:   Sat May 6 01:40:17 2017 -0700

    Merge remote-tracking branch 'dotnet/master' into refout-mergemaster

commit 8bef0a1f91dfe66e8bf9415710ef2f2afd4fdbc4
Merge: a255d49 779cd6d
Author: Julien Couvreur <jcouv@users.noreply.github.com>
Date:   Sat May 6 01:32:11 2017 -0700

    Update refout feature branch with latest bits from master

    Last good commit before this merge was a255d49117941fbf404ebdbbe6b2635ba1546bd8

commit 86c7d6cb872d15969fb9e45271cf55378f41ce27
Merge: 6192c04 64d06fd
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Fri May 5 22:46:32 2017 -0500

    Merge pull request #19184 from sharwell/faster-callback

    Remove unnecessary delegate allocations when calling back to analyzers

commit 8fc3f6ee013a6a0b5d27b0b3f0c4fbbd1e184ffa
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Fri May 5 20:38:46 2017 -0700

    Use a pooled array to create hashes from.

commit 0f8b7ff4673e379708402364c67f12fbc99bc557
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Fri May 5 19:37:21 2017 -0700

    Pool SHA1 instances.

commit 779cd6d7469f7086bae1027d31d0f73e1a61ff61
Merge: a255d49 6192c04
Author: Julien Couvreur <julien.couvreur@gmail.com>
Date:   Fri May 5 18:40:51 2017 -0700

    Merge remote-tracking branch 'dotnet/master' into refout-mergemaster

    Conflicts:
    	src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs

commit 36c013bca3c99b7b05ad6bf51ccf9c1abd5f4b46
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 18:07:41 2017 -0700

    removed logging

commit ae2e67cd0e1c39b8d2c1d827d67325af3b2377ad
Merge: a260bc6 bc9de27
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 18:02:59 2017 -0700

    Merge branch 'OOPPerf' of https://github.com/heejaechang/roslyn into BulkSync

commit a260bc69f22cb020f463a3ff50bcd37278220e32
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 17:50:20 2017 -0700

    removed loggings

commit 5bdf617bb8a11241a37cea7ba3f4102d47c76d14
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 17:21:19 2017 -0700

    send additional info when setting context for service call.

    now, it includes flag whether given solution is for primary workspace or not.

    this should benefit perf on initial solution load

commit 6cfdbb3ce171c6ed5e501e17239250ae244ba437
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Fri May 5 17:11:17 2017 -0700

    Add trivia to the statement.

commit 6192c047bf645b4244849f9358dbfdf2a22f4c93
Author: Tomáš Matoušek <tmat@users.noreply.github.com>
Date:   Fri May 5 17:04:38 2017 -0700

    Remove DSRN VSIX prereq (#19304)

commit bc7c98413c1a23659d7f62a2d646cdd5fc6960cf
Merge: bf93667 4c00cec
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Fri May 5 16:53:51 2017 -0700

    Merge remote-tracking branch 'upstream/master' into directiveHandling

commit 3d11beecb074b6fe3c8f319564a8237d1cb5e5de
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 15:24:51 2017 -0700

    made VS to crash explicitly when there is bad remote session consumer.

commit 4988c1cdc2d5244e69eb550dc1dd8b4ea9c82eab
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 15:23:16 2017 -0700

    change to translate any exception to cancellation exception if cancellation is raised.

commit 4c00cec073687f66dc48c6a7da313b99bb49dc73
Author: Neal Gafter <neal@gafter.com>
Date:   Fri May 5 15:08:21 2017 -0700

    Fix a crash in the parser due to ParseStatementCore returning null (#19281)

    Other call sites appear to have been adapted already.
    Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?_a=edit&id=266237

commit 8cc7daaccf0f00e4859dd9ef0b4fa1eb82022aa8
Author: Shyam N <gnamboo@microsoft.com>
Date:   Fri May 5 15:03:32 2017 -0700

    Crash the compiler if we are trying to emit a method definition token but end up with a handle that does not correspond to a method definition.

commit 38322d4820dfc0777a92760585b8b636f4d5c4f5
Author: Shyam N <gnamboo@microsoft.com>
Date:   Thu May 4 15:05:59 2017 -0700

    Fix VB partial method instrumentation.

commit 1ee15f02cbfaaf785b4e45c29157c682c2654266
Author: Shyam N <gnamboo@microsoft.com>
Date:   Thu May 4 01:27:26 2017 -0700

    Fix C# partial method instrumentation.

commit 86e3f08b659b63c4056b1ae6dd8dc73a28f1e91d
Author: Tomáš Matoušek <tmat@users.noreply.github.com>
Date:   Fri May 5 14:04:13 2017 -0700

    Improve path completion providers (#19195)

    * Improve path completion providers

    * Make GAC completion faster and cancellable

    * Move FileSystemCompletionHelper.cs

    * Move LoadDirectiveCompletionProviderTests.cs

    * PR feedback and fix completion for 'X:' paths

commit bc9de278eef266820de7559db16bbad652f837c7
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 14:03:47 2017 -0700

    added link to github issue to make option part of solution

commit 5a6e108c55c1963c2260853069ffcd53b04b0b5a
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Fri May 5 13:57:02 2017 -0700

    Fix analysis of IOperation descendants for BoundDelegateCreationExpression

    The current IOperation API implementation of BoundDelegateCreationExpression has a bunch of issues and needs to be redesigned. This is tracked by #8897 and will be addressed post 15.3. Meanwhile, to unblock analyzers on code containing delegate creation expressions with lambda arguments, this bound node has been switched to OperationKind.None with override for Children property.

    Fixes the first repro case provided in #8884

commit a124f06493bafaede2440fc6344a5d058c9bbc55
Author: Heejae Chang <hechang@microsoft.com>
Date:   Fri May 5 13:24:41 2017 -0700

    some loggings

commit 1c155249ae8ce55af7bf0ed0a7dbd2f9838be0d2
Merge: d2c488a bfc2402
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Fri May 5 12:05:23 2017 -0700

    Merge pull request #19286 from CyrusNajmabadi/addUsingNested

    Fix crash in AddUsing when changing casing of a typename.

commit d2c488a98c44a3b2339cf9cc3e099f998a5fde49
Merge: e08df4c 112afcb
Author: Tom Meschter <tom.meschter@valinor.org>
Date:   Fri May 5 11:43:32 2017 -0700

    Merge pull request #19272 from tmeschter/FixMemoryLeakInBatching

    Fix a small memory leak related to batching project loads

commit 1d9b64a214cfaee648e5ab0c02f85cbbded6edad
Author: Manish Vasani <mavasani@microsoft.com>
Date:   Fri May 5 09:55:59 2017 -0700

    Fix one unit test and skip couple of unit tests due to the API changes. I have filed #19300 to track the skipped tests

commit a4d168aef3637768ddf5b463a603ef019a260aa0
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Fri May 5 10:42:58 2017 -0500

    Compare candidate symbols by their original definition

    The bound symbols have instantiated generic types/methods, but the candidates
    found through a lookup by name do not. We compare their original definitions
    to treat these uninstantiated generics as true candidates for simplification.

commit 36d55d1d20da6464f4106572da7223bf8f236cc2
Author: Ravi Chande <rchande@microsoft.com>
Date:   Fri May 5 08:28:29 2017 -0700

    Revert "Merge pull request #10993 from rchande/quickinfosession"

    This reverts commit 3ef5891043f89145b1e1c1a7de8c0e02acd15c6e, reversing
    changes made to 923fcbf40f87c7c50ea09c8375556c293795874a.

commit f59086a475ab2e776c8a19cd45d768ef5d435232
Merge: 9984085 e08df4c
Author: Ty Overby <ty@pre-alpha.com>
Date:   Fri May 5 07:46:51 2017 -0700

    Merge branch 'master' into features/async-main

commit 94d573e47da0e8a093970f463da6406be1ae9959
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Fri May 5 06:16:25 2017 -0500

    Avoid calling both LookupSymbols and LookupNamespacesAndTypes when we only need the latter

commit 875191bf7cee4f5f2584a19cb3237922dabd9714
Author: Sam Harwell <sam.harwell@microsoft.com>
Date:   Fri May 5 05:50:39 2017 -0500

    Use LookupSymbols and LookupNamespacesAndTypes to improve candidate speed and accuracy

commit 7e582ebd0331299c7cccdb2549cc68e46eb032f7
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 23:43:28 2017 -0700

    VB side.

commit 26c708fb2c2463ddbc12fc3c7f67b648a4e65cbf
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 23:14:48 2017 -0700

    Prefer readonly properties in constructors.

commit ff703cb1b19bd8e313b012377addc4b316416278
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 22:59:22 2017 -0700

    Add heuristic to prefer generating readonly fields.

commit e08df4c4eb89d7c8bf913b28fc866a8b983c3f3d
Merge: 857df89 859a43e
Author: Srivatsn Narayanan <srivatsn@users.noreply.github.com>
Date:   Thu May 4 22:48:13 2017 -0700

    Merge pull request #19279 from srivatsn/fixconfigs

    Fix configurations so that project will load in 15.3

commit c08f63b2704cd44cc58db0f7798d4b911a89c773
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 22:08:03 2017 -0700

    Move GenerateVariable types.

commit aa9fd5fa2f9f4ce2e5a56aaf42bb9004b398fae3
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 21:51:45 2017 -0700

    Formatting.

commit ebc112baca89eabc6f41834f56e1258f2582cb83
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 21:49:38 2017 -0700

    Order 'Remove Unused Variable' after 'Add Using'

commit bf9366705e3043edcd2971ae22b0518b5c8b8e70
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 21:29:21 2017 -0700

    Preserve trivia better when converting from an expression body to a block body.

commit bfc2402b14704644089eeb0cda0202d60a43ed5d
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 19:44:09 2017 -0700

    Make names clearer.

commit b9a3e8254db1088abddf4c490d6ab72bf303dd6b
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 19:38:30 2017 -0700

    Fix crash in AddUsing when changing casing of a typename.

commit 86c6c0479b14c578ee528d75e14a3f2d4b160aa5
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 18:47:31 2017 -0700

    Add comment.

commit 87fc19f641672fe5a346636a13c5e5ca05a4f188
Merge: 366fc20 857df89
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 18:43:18 2017 -0700

    Merge remote-tracking branch 'upstream/master' into poisonProject

commit 366fc20bdd15d0b36de98bfbccb930747a1c8735
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 18:43:04 2017 -0700

    Better handling of directive-trivia in UseExpressionBody/ReplacePropWithMethod.

commit 857df892a63b21e99b280f0f412b8fe40d599323
Merge: 6f86e61 243ff23
Author: Sam Harwell <sam@tunnelvisionlabs.com>
Date:   Thu May 4 20:40:30 2017 -0500

    Merge pull request #19255 from sharwell/asynclazy-fast-path

    Use a wait-free fast path in AsyncLazy<T>.GetValueAsync

commit 6f86e6186750e27e0a517f18cde653fc42f01420
Merge: f1ff04b 6715562
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 18:05:39 2017 -0700

    Merge pull request #19275 from CyrusNajmabadi/objectInitializerBlankLines

    Do a better job preserving blank lines when we convert code to using an object initializer.

commit f1ff04b127e58aab0c1d7b17f06e7606c7e78411
Merge: 9149507 cc4852d
Author: CyrusNajmabadi <cyrusn@microsoft.com>
Date:   Thu May 4 18:05:21 2017 -0700

    Merge pull request #19226 from CyrusNajmabadi/poisonProject

    Do not allow 'add nuget reference' for projects that we f…

@jcouv jcouv changed the title from Champion "pattern-matching with generics" to Champion "pattern-matching with generics" (C# 7.1) Jun 5, 2017

@shaggygi

This comment has been minimized.

Show comment
Hide comment
@shaggygi

shaggygi Aug 27, 2017

Contributor

@gafter @jcouv was this implemented in 7.1 and now suppose to work in VS 2017?

Contributor

shaggygi commented Aug 27, 2017

@gafter @jcouv was this implemented in 7.1 and now suppose to work in VS 2017?

@gafter

This comment has been minimized.

Show comment
Hide comment
@gafter

gafter Aug 28, 2017

Member

Yes

Member

gafter commented Aug 28, 2017

Yes

@orthoxerox

This comment has been minimized.

Show comment
Hide comment
@orthoxerox

orthoxerox Aug 28, 2017

Shouldn't it be closed, then?

orthoxerox commented Aug 28, 2017

Shouldn't it be closed, then?

@jcouv

This comment has been minimized.

Show comment
Hide comment
@jcouv

jcouv Aug 28, 2017

Member

There is a remaining workitem to update the language spec to reflect this feature. That's why the issue is kept open.

Member

jcouv commented Aug 28, 2017

There is a remaining workitem to update the language spec to reflect this feature. That's why the issue is kept open.

@shaggygi

This comment has been minimized.

Show comment
Hide comment
@shaggygi

shaggygi Aug 28, 2017

Contributor

Thank you for reply

Contributor

shaggygi commented Aug 28, 2017

Thank you for reply

@reinseth

This comment has been minimized.

Show comment
Hide comment
@reinseth

reinseth commented May 14, 2018

The link to the proposal in the description is broken. Should be https://github.com/dotnet/csharplang/blob/master/proposals/csharp-7.1/generics-pattern-match.md

@jcouv

This comment has been minimized.

Show comment
Hide comment
@jcouv

jcouv May 14, 2018

Member

@reinseth Fixed. Thanks

Member

jcouv commented May 14, 2018

@reinseth Fixed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment