Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osx-arm64 to packges/CI #1574

Merged
merged 6 commits into from Oct 8, 2020
Merged

Add osx-arm64 to packges/CI #1574

merged 6 commits into from Oct 8, 2020

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Sep 17, 2020

This is roughly what I think should work...

  • I Hijacked the osGroup usage a bit adding MacOS_cross, but it seemed simplest for now. Probably will eventually need to be cleaned up. Possibly when we move all the builds to using the XCode12 tool chain.
  • I am not sure exactly about pool configuration/queue names.
  • I am not sure whether prepare machine might need extra work...

@sdmaclea sdmaclea added arm64 ARM64 architecture related issue dotnet-sos sos labels Sep 17, 2020
@sdmaclea sdmaclea added this to the 6.0 milestone Sep 17, 2020
@sdmaclea sdmaclea self-assigned this Sep 17, 2020
@mikem8361
Copy link
Member

I learned kind of a trick to make sure my yaml syntax is ok: under "Run new" of the build pipeline select "Stages to run" and it will display any yaml errors.

Use vmImage: macOS-10.15 for public queue
Disable official builds until we have XCode 12 on an Internal queue
diagnostics.yml Outdated Show resolved Hide resolved
eng/build.yml Show resolved Hide resolved
diagnostics.yml Show resolved Hide resolved
Use vmimage for internal builds too
Reenable internal builds
Use XCode 12 beta (XCode 12 RTM doesn't support arm64 yet)
@hoyosjs
Copy link
Member

hoyosjs commented Sep 22, 2020

Merging this as the failures are well-known and this doesn't affect testing. comment in the wrong PR.

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Sep 22, 2020

@hoyosjs The failures look unrelated. Can you look and decide if you are OK with this PR.

We will need further PRs to:

@hoyosjs
Copy link
Member

hoyosjs commented Sep 22, 2020

The packaging will automatically fail here if it tries to look for the host. However, osx-arm64 is not in the list in src/Tools/Directory.Build.props, so I don't know where it will resolve the host from. As you said, managed assemblies are AnyCPU and are built in the win-x64 leg, so the managed code doesn't concern me. All this is only done in internal, so you won't see it on a PR build. I'm fine with merging this after we test this internally. Given that our testing is on the ground right now, we can evaluate it easily like this:

  • Push this to a branch in internal.
  • Add a commit there for test purposes only that you can revert after to skip testing:
    • Comment out all the test only legs in diagnostics.yml
    • Remove the test flag in eng/cibuild.sh and eng\cibuild.cmd
  • We can then test the packages manually on ARM64 and decide.

@sdmaclea
Copy link
Contributor Author

@hoyosjs Thanks. I am OK with waiting for internal testing to be fixed before merging this. It is not urgent.

FWIW, The new osx-arm64 legs do not try to test, because it no longer is using cibuild.sh so it doesn't set the --test flag.

@hoyosjs
Copy link
Member

hoyosjs commented Sep 22, 2020

I meant so that it skips testing in all legs and we can just test the packaging logic.

Fix comments

Use macOS-10.15
@sdmaclea sdmaclea requested a review from a team as a code owner October 7, 2020 20:10
@sdmaclea sdmaclea merged commit cfa2182 into dotnet:master Oct 8, 2020
@sdmaclea sdmaclea deleted the AppleSilicon branch October 8, 2020 00:47
@sdmaclea sdmaclea moved this from In progress to Done in Enable .NET Core on Apple Silicon Oct 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arm64 ARM64 architecture related issue dotnet-sos sos
Development

Successfully merging this pull request may close these issues.

None yet

3 participants