Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed PDF generation should result in Error and not Warning #4232

Closed
lg2de opened this Issue Mar 22, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@lg2de
Copy link

lg2de commented Mar 22, 2019

Operation System: Windows

DocFX Version Used: 2.40.12

Template used: custom template

Steps to Reproduce:

  1. generate PDF documentation
  2. open PDF (with a viewer locks the file, like Acrobat Reader)
  3. generate PDF documentation => PDF cannot be generated because the file is protected

Expected Behavior:
PDF generation failed => ERROR

Actual Behavior:
PDF generation failed => WARNING

[19-03-22 04:15:25.956]Warning:[PDF]Error happen when converting pdf/toc.json to Pdf. Details: ... accessed by another process...
                       ^^^^^^^

The PDF file is not up-to-date. So the process was failed!

@lg2de

This comment has been minimized.

Copy link
Author

lg2de commented Mar 27, 2019

@superyyrrzz , for me this is not an enhancement but a bug.

icnocop added a commit to icnocop/docfx that referenced this issue Apr 2, 2019

@superyyrrzz

This comment has been minimized.

Copy link
Collaborator

superyyrrzz commented Apr 4, 2019

Thank you for your feedback. @icnocop created #4289 to fix this.

@superyyrrzz superyyrrzz added bug and removed enhancement labels Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.