Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple config for replacing logo #873

Closed
roji opened this issue Nov 8, 2016 · 5 comments
Closed

Simple config for replacing logo #873

roji opened this issue Nov 8, 2016 · 5 comments

Comments

@roji
Copy link
Member

roji commented Nov 8, 2016

#239 describes how to override the navbar partial in order to replace the logo (upper-left corner).

It seems like there should be a much easier config option for doing this - practically every documentation site out there will want to put their project's logo, and overriding template partials is dangerous for compatibility as the template changes. Would you consider docfx global metadata option(s) for managing this?

@superyyrrzz
Copy link
Contributor

Yes, we can provide a metadata _appLogoPath to replace logo.svg here. Then by minor customizing the template to provide your own logo file, you can replace logo while keep the template compatible.

@superyyrrzz
Copy link
Contributor

Now in DocFX 2.8, you can use _appLogoPath and _appFaviconPath in global metadata to customize it.

@roji
Copy link
Member Author

roji commented Nov 22, 2016

@superyyrrzz great! Should I leave this open for tracking splitting out the logo into its own separate partial?

@superyyrrzz
Copy link
Contributor

@roji
Copy link
Member Author

roji commented Nov 22, 2016

Oh awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants