Create msbuild workspace with Release Configuration by default #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinezh
requested review from
vicancy,
hellosnow,
ansyral,
vwxyzh,
superyyrrzz and
chenkennt
vwxyzh
approved these changes
Feb 27, 2017
|
|
vicancy
reviewed
Feb 27, 2017
| private readonly Lazy<MSBuildWorkspace> _workspace = new Lazy<MSBuildWorkspace>(() => MSBuildWorkspace.Create()); | ||
| private readonly Lazy<MSBuildWorkspace> _workspace = new Lazy<MSBuildWorkspace>(() => MSBuildWorkspace.Create(new Dictionary<string, string> | ||
| { | ||
| { "Configuration", "Release" } |
There was a problem hiding this comment.
provide a MetadataCommandOption to change?
There was a problem hiding this comment.
I agree with it. The aim of this PR is only to change the default behavior, and I'll provide metadata option in another PR if users need it.
vicancy
approved these changes
Feb 27, 2017
qinezh
added a commit
that referenced
this pull request
Feb 27, 2017
vwxyzh
pushed a commit
that referenced
this pull request
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.