New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create msbuild workspace with Release Configuration by default #1356

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
5 participants
@qinezh
Collaborator

qinezh commented Feb 27, 2017

No description provided.

@vwxyzh

vwxyzh approved these changes Feb 27, 2017

@hellosnow

This comment has been minimized.

Show comment
Hide comment
@hellosnow

hellosnow Feb 27, 2017

Collaborator

:shipit:

Collaborator

hellosnow commented Feb 27, 2017

:shipit:

private readonly Lazy<MSBuildWorkspace> _workspace = new Lazy<MSBuildWorkspace>(() => MSBuildWorkspace.Create());
private readonly Lazy<MSBuildWorkspace> _workspace = new Lazy<MSBuildWorkspace>(() => MSBuildWorkspace.Create(new Dictionary<string, string>
{
{ "Configuration", "Release" }

This comment has been minimized.

@vicancy

vicancy Feb 27, 2017

Contributor

provide a MetadataCommandOption to change?

@vicancy

vicancy Feb 27, 2017

Contributor

provide a MetadataCommandOption to change?

This comment has been minimized.

@qinezh

qinezh Feb 27, 2017

Collaborator

I agree with it. The aim of this PR is only to change the default behavior, and I'll provide metadata option in another PR if users need it.

@qinezh

qinezh Feb 27, 2017

Collaborator

I agree with it. The aim of this PR is only to change the default behavior, and I'll provide metadata option in another PR if users need it.

@qinezh qinezh merged commit 87d7970 into dotnet:dev Feb 27, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build Docfx CI :: dev : Tests passed: 718, ignored: 3
Details

@qinezh qinezh deleted the qinezh:metadata branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment