From d2d5ff1fc5c2a3c5551ffbf3f55c3ce8d1509c4d Mon Sep 17 00:00:00 2001 From: Alex Wolf Date: Tue, 16 Jul 2024 12:29:07 -0400 Subject: [PATCH] fixes --- docs/azure/sdk/protocol-convenience-methods.md | 1 + .../AzureCoreProtocol/Program.cs | 7 +++++++ .../protocol-convenience-methods/SCMConvenience/Program.cs | 4 ++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/azure/sdk/protocol-convenience-methods.md b/docs/azure/sdk/protocol-convenience-methods.md index 494536db58e12..73336d80b29bb 100644 --- a/docs/azure/sdk/protocol-convenience-methods.md +++ b/docs/azure/sdk/protocol-convenience-methods.md @@ -107,6 +107,7 @@ The preceding code demonstrates the following `System.ClientModel` protocol meth > [!NOTE] > The preceding code configures the `ClientErrorBehaviors.NoThrow` for the `RequestOptions`. This option prevents non-success service responses status codes from throwing an exception, which means the app code should manually handle the response status code checks. + --- ## Protocol and convenience method usage guidance diff --git a/docs/azure/sdk/snippets/protocol-convenience-methods/AzureCoreProtocol/Program.cs b/docs/azure/sdk/snippets/protocol-convenience-methods/AzureCoreProtocol/Program.cs index dbc9b72f8d715..64e3bfb2f88e5 100644 --- a/docs/azure/sdk/snippets/protocol-convenience-methods/AzureCoreProtocol/Program.cs +++ b/docs/azure/sdk/snippets/protocol-convenience-methods/AzureCoreProtocol/Program.cs @@ -19,5 +19,12 @@ prompt, new RequestContext() { ErrorOptions = ErrorOptions.NoThrow}); +// Any response code other than 200 from Azure ContentSafety AnalyzeText REST API is not considered a success response +// See REST API details at https://azure-ai-content-safety-api-docs.developer.azure-api.net/api-details#api=content-safety-service-2023-10-01&operation=TextOperations_AnalyzeText +if (response.Status != 200) +{ + throw new RequestFailedException(response); +} + // Display the results Console.WriteLine(response.Content); \ No newline at end of file diff --git a/docs/azure/sdk/snippets/protocol-convenience-methods/SCMConvenience/Program.cs b/docs/azure/sdk/snippets/protocol-convenience-methods/SCMConvenience/Program.cs index 88f85faf136c9..0476a7eccf819 100644 --- a/docs/azure/sdk/snippets/protocol-convenience-methods/SCMConvenience/Program.cs +++ b/docs/azure/sdk/snippets/protocol-convenience-methods/SCMConvenience/Program.cs @@ -7,8 +7,8 @@ ChatClient chatClient = client.GetChatClient("gpt-4"); // Call the convenience method -ClientResult completion +ChatCompletion completion = chatClient.CompleteChat("What is Azure?"); // Display the results -Console.WriteLine($"{completion.Value.Role}: {completion.Value.Content}"); \ No newline at end of file +Console.WriteLine($"{completion.Role}: {completion.Content}"); \ No newline at end of file