Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientCertificates description was wrong #4790

Closed
wants to merge 4,537 commits into from
Closed

ClientCertificates description was wrong #4790

wants to merge 4,537 commits into from

Conversation

rwatjen
Copy link

@rwatjen rwatjen commented Mar 27, 2018

The ClientCertificates property description had text from the MaxResponseHeadersLength property.

Summary

Updated the summary and value of HttpClientHandler.ClientCertificates

MSGaryWang and others added 30 commits February 20, 2018 18:54
@MSGaryWang @mairaw
Update StartListening method desciption (dotnet#4344)
9604789 
* Update StartListening method desciption

The current description might mislead user calling this method unnecessarily, this change will help user understand clearly at the correct way to use this method.

* Update TcpServerChannel.xml

* Update TcpServerChannel.xml

* Update TcpServerChannel.xml

* fix link

* Update TcpServerChannel.xml
@mairaw @BillWagner
fix redirect url (dotnet#4447)
b16c476
@pkulikov @BillWagner
Added examples with string.Concat and string.Join (dotnet#4443)
2431604
@VHellin @BillWagner
Remove unused variable creating confusion. (dotnet#4446)
c59daf6
@mairaw
add level to async topics (dotnet#4448)
3c2c37a
@jjhampton @mairaw
Fix grammar in docs: communication-in-microservice-architecture.md (d…
bd4c579 
…otnet#4442)

Rephrase 'not' => 'Neither' + 'nor'
@mairaw
add two options explanation (dotnet#4449)
275720c 
* add two options explanation

* fixed heading
@jformacek @BillWagner
Maximum size of file to be compressed (dotnet#3615)
a072adc 
* Maximum size of file to be compressed

Added information about maximum file size that can be compressed, and exception that is thrown when limit is reached

* Respond to feedback

* respond to editing feedback.

* replace xref syntax with cref syntax

* fixed link format

* fix links 

include the type with int.Maxvalue
Replace an incorrect cref with xref.

* make sure the additions are in both overloads.
@VHellin
Remove unused variable (dotnet#4436)
ca5109b 
Remove unused variable creating confusion: GeometryDrawing myGeometryDrawing = new GeometryDrawing();
Addressed customer feedback about ControlBox property (dotnet#4444)
771e444 
* Addressed customer feedback about ControlBox property

* Incorporated review comments
@sas41
Fixed example Snippet and clarified it. (dotnet#4434)
0b8cef7 
* Fixed example Snippet and clarified it.

* Renamed "Local" to "LocalFunction"

From my previous commit, pointed out by @pkulikov, I forgot to rename the later mentions of the "Local" function in the paragraph after the code snippet.
@vinodhnamala
Update interpolated-strings.md (dotnet#4452)
257cd17 
Corrected typo mistake
@mairaw
update link (dotnet#4451)
0b36c40
@pkulikov @mairaw
Replaced fwlinks in csharp\programming-guide\concepts\async folder (d…
90fca1c 
…otnet#4298)

* Replaced fwlink in concepts/async except index.md

* Fix link error

* Test uwp fwlink replace

* replace fwlink in concepts/async/index.md

* text xref with uwp links

* uwp/api links -> xref links
Revised for API Browser, .NET implementations (dotnet#4337)
afbc68c 
* Revised for API Browser, .NET implementations

* Incorporated review comments

* Corrected System.Object for F#
@mairaw
fix broken links and review topic (dotnet#4432)
49a21f6 
* fix broken links and review topic

* feedback

* feedback
@mairaw
replace wrong example (dotnet#4445)
89ead2b 
* replace wrong example

* removed examples
@mairaw @JRAlexander
fix broken links (dotnet#4430)
50590ed
@pkulikov
Fixed typo (dotnet#4458)
1dd31e5
@mairaw @JRAlexander
fix broken links (dotnet#4422)
9f0bd68 
* fix broken links

* Revised  link

Revised Working with Visual Studio For Docker Tools link
Deleted unnecessary space (dotnet#4460)
f52d467
@pkulikov
Replaced fwlinks in csharp\programming-guide folder (dotnet#4459)
f2576a1 
* Replaced fwlinks in csharp\programming-guide folder

* Implemented review feedback
@WardDurossette
Updated to include a link to ECMA 335 (dotnet#4465)
ddd3551 
One of the comments provided was a desire to link this document to the actual specification, so I add that.
@mairaw
fix broken links (dotnet#4454)
f57e418
@cartermp
Update namespaces.md (dotnet#4464)
f0e6053 
The section title was missing
@cartermp
Update modules.md (dotnet#4463)
f5887ce 
The title looked awful in the live site and I think this new one is simpler
@svick @BillWagner
Use centimeters instead of inches (dotnet#4472)
637f8a8
@Styxxy
code sample, mixed indenting spaces/tabs (dotnet#4470)
3215bfe
@pkulikov @BillWagner
Improved text in concatenate-multiple-strings (dotnet#4457)
9b38c5e
@Styxxy
fix indenting code sample vb lang features (dotnet#4471)
b960089
@JRAlexander JRAlexander added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Mar 27, 2018
@rwatjen
PR comment fixes
7ce0c3e 
* Removing words ending with 'ing' 
* Cross-referencing to the type
* Clarifying when the certificate collection is used
@rwatjen
Copy link
Author

rwatjen commented Mar 28, 2018

Hi @JRAlexander, I've updated with input from your comments. Since the HttpClientHandler can be reused in multiple requests, I haven't used your suggestions directly. I hope this will do :)

@JRAlexander
Copy link
Contributor

@rwatjen, my apologies for the delay! I wanted to check on something with the devs and then was out of office late last week. Your changes are great! In the meantime, the API has been split into a new repo. So we are going to need to open a new PR there and copy your changes, and then close this PR. https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System.Net.Http/HttpClientHandler.xml

I've copied your changes here:
Summary - Gets the collection of security certificates that are associated requests to the server.
Value (removed the xref link, unnecessary after all) - The X509CertificateCollection that is presented to the server when performing certificate based client authentication.

After you copy those over, I'll merge straightaway after the build. Please let me know if you have any questions.

@JRAlexander
Copy link
Contributor

@rwatjen, Would you like me to do this? I can definitely if you'd rather. Please let me know asap. Thanks!

@JRAlexander JRAlexander modified the milestones: Sprint 133 (3/17/18 - 4/06/18) , Sprint 134 (4/9/2018 - 4/27/2018) Apr 9, 2018
@rwatjen rwatjen mentioned this pull request Apr 10, 2018
Merged
@rwatjen
Copy link
Author

rwatjen commented Apr 10, 2018

Hi @JRAlexander, I've created a new PR (dotnet/dotnet-api-docs#37). Sorry for the delay, was busy at work.

@rwatjen rwatjen closed this Apr 10, 2018
@mairaw mairaw removed this from the Sprint 134 (4/7/2018 - 4/27/2018) milestone Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRAlexander JRAlexander JRAlexander approved these changes

Assignees

@rwatjen rwatjen

Labels
✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository
Projects
None yet
Milestone
Sprint 134 (4/7/2018 - 4/27/2018)
Development

Successfully merging this pull request may close these issues.