Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type signature for MatchCollection #5608

Closed
alfredmyers opened this issue May 25, 2018 · 3 comments
Closed

Fix type signature for MatchCollection #5608

alfredmyers opened this issue May 25, 2018 · 3 comments

Comments

@alfredmyers
Copy link
Contributor

@alfredmyers alfredmyers commented May 25, 2018

The type signature for MatchCollection corresponds to the .NET Framework's implementation

public class MatchCollection : ICollection

... not the .NET Core's implementation

public class MatchCollection : IList<Match>, IReadOnlyList<Match>, IList

Do the docs support providing different type signatures for different versions and/or implementations of the APIs?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@rpetrusha

This comment has been minimized.

Copy link
Contributor

@rpetrusha rpetrusha commented May 25, 2018

Thanks for pointing this out, @alfredmyers. We don't support multiple type signatures for different versions/implementations, at least as far as I know. @dend, is that accurate?

@alfredmyers

This comment has been minimized.

Copy link
Contributor Author

@alfredmyers alfredmyers commented May 25, 2018

Here's another instance: X509Certificate added IDisposable in .NET Framework 4.6

@mairaw mairaw added the duplicate label May 30, 2018
@mairaw

This comment has been minimized.

Copy link
Contributor

@mairaw mairaw commented May 30, 2018

Duplicate of MicrosoftDocs/feedback#222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.