Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F# 4.7 docs updates #15674

Merged
merged 8 commits into from Nov 12, 2019
Merged

F# 4.7 docs updates #15674

merged 8 commits into from Nov 12, 2019

Conversation

@cartermp
Copy link
Contributor

cartermp commented Nov 3, 2019

fixes #14578

Sibling samples PR: dotnet/samples#1693

@dotnet-bot dotnet-bot added this to the November 2019 milestone Nov 3, 2019
@cartermp cartermp mentioned this pull request Nov 3, 2019
@cartermp cartermp changed the title [WIP] F# 4.7 F# 4.7 docs updates Nov 4, 2019
@cartermp

This comment has been minimized.

Copy link
Contributor Author

cartermp commented Nov 4, 2019

This is now ready.

@cartermp cartermp requested a review from dsyme Nov 4, 2019
Co-Authored-By: Petr Kulikov <petr.kulikov@gmail.com>
@mairaw mairaw removed this from the November 2019 milestone Nov 10, 2019
@mairaw
mairaw approved these changes Nov 10, 2019
Copy link
Contributor

mairaw left a comment

LGTM. Left some comments for you to consider.

docs/fsharp/language-reference/sequences.md Outdated Show resolved Hide resolved
docs/fsharp/language-reference/sequences.md Outdated Show resolved Hide resolved
docs/fsharp/language-reference/sequences.md Outdated Show resolved Hide resolved
docs/fsharp/language-reference/sequences.md Outdated Show resolved Hide resolved
docs/fsharp/language-reference/sequences.md Outdated Show resolved Hide resolved
docs/fsharp/style-guide/formatting.md Outdated Show resolved Hide resolved
cartermp and others added 2 commits Nov 10, 2019
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@cartermp

This comment has been minimized.

Copy link
Contributor Author

cartermp commented Nov 12, 2019

@mairaw thanks! I'll merge this once it's green

@cartermp cartermp merged commit 1669187 into dotnet:master Nov 12, 2019
8 checks passed
8 checks passed
lint
Details
Docs Content Validation Status: Succeeded
Details
OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 11:21:31 PST
OpenPublishing.Build (2 of 3) Preparing completed at 11:24:04 PST
OpenPublishing.Build (3 of 3) Building completed at 11:24:52 PST
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@cartermp cartermp deleted the cartermp:fsharp47 branch Nov 12, 2019
Youssef1313 added a commit to Youssef1313/docs that referenced this pull request Nov 20, 2019
* Replace double-underscore with single-underscore

* Offside subtly mentioned in style guide

* Implicit yields and reorder seq guidance

* Update formatting guidelines for -> and implicit yields

* Update ms.date fields

* Update docs/fsharp/language-reference/sequences.md

Co-Authored-By: Petr Kulikov <petr.kulikov@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Use xref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.