From c05d585fd0dc2b9b0e7c297d00caa5291ead2af0 Mon Sep 17 00:00:00 2001 From: David Pine Date: Mon, 20 Apr 2020 13:51:55 -0500 Subject: [PATCH 01/13] Add a table detailing various ways to observe exceptions from faulted tasks --- .../exception-handling-task-parallel-library.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/standard/parallel-programming/exception-handling-task-parallel-library.md b/docs/standard/parallel-programming/exception-handling-task-parallel-library.md index a144acb962dfd..35281e8838437 100644 --- a/docs/standard/parallel-programming/exception-handling-task-parallel-library.md +++ b/docs/standard/parallel-programming/exception-handling-task-parallel-library.md @@ -1,6 +1,6 @@ --- title: "Exception handling (Task Parallel Library)" -ms.date: "03/30/2017" +ms.date: 04/20/2020 ms.technology: dotnet-standard dev_langs: - "csharp" @@ -83,7 +83,16 @@ If a task completes in the property. | +| `_ = task.Exception` | Discard the , but still access it. | +| `await task` | Asynchronously `await` a task, propagating an if the task has faulted. | +| `task.Wait()` | Synchronously `.Wait` for the task, propagating an if the task has faulted. | +| `task.Result` | Access the `.Result` property, propagating an if the task has faulted. | +| `task.GetAwaiter().GetResult()` | Equivelent to `await task`, propagating an if the task has faulted. | ## UnobservedTaskException event From 6f2a01b4a2a4716eb56fe79ab89cf3168a0f47e3 Mon Sep 17 00:00:00 2001 From: David Pine Date: Mon, 20 Apr 2020 14:05:08 -0500 Subject: [PATCH 02/13] Remove extraneous close parenthesis --- docs/core/diagnostics/debug-memory-leak.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/core/diagnostics/debug-memory-leak.md b/docs/core/diagnostics/debug-memory-leak.md index 222be6cb470fa..267e4ae4bddad 100644 --- a/docs/core/diagnostics/debug-memory-leak.md +++ b/docs/core/diagnostics/debug-memory-leak.md @@ -2,7 +2,7 @@ title: Debug a memory leak tutorial description: Learn how to debug a memory leak in .NET Core. ms.topic: tutorial -ms.date: 12/17/2019 +ms.date: 04/20/2020 --- # Tutorial: Debug a memory leak in .NET Core @@ -131,7 +131,7 @@ In this tutorial, you're now done with the [Sample debug target](https://docs.mi ### Analyze the core dump -Now that you have a core dump generated, use the [dotnet-dump)](dotnet-dump.md) tool to analyze the dump: +Now that you have a core dump generated, use the [dotnet-dump](dotnet-dump.md) tool to analyze the dump: ```dotnetcli dotnet-dump analyze core_20190430_185145 From 0febf0f66b4474317f3bc4ba669ff7df5f4cec68 Mon Sep 17 00:00:00 2001 From: David Pine Date: Mon, 20 Apr 2020 15:30:27 -0500 Subject: [PATCH 03/13] Updates from feedback --- ...exception-handling-task-parallel-library.md | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/docs/standard/parallel-programming/exception-handling-task-parallel-library.md b/docs/standard/parallel-programming/exception-handling-task-parallel-library.md index 35281e8838437..01a725d950dcd 100644 --- a/docs/standard/parallel-programming/exception-handling-task-parallel-library.md +++ b/docs/standard/parallel-programming/exception-handling-task-parallel-library.md @@ -83,16 +83,14 @@ If a task completes in the property. | -| `_ = task.Exception` | Discard the , but still access it. | -| `await task` | Asynchronously `await` a task, propagating an if the task has faulted. | -| `task.Wait()` | Synchronously `.Wait` for the task, propagating an if the task has faulted. | -| `task.Result` | Access the `.Result` property, propagating an if the task has faulted. | -| `task.GetAwaiter().GetResult()` | Equivelent to `await task`, propagating an if the task has faulted. | +In a real application, the continuation delegate could log detailed information about the exception and possibly spawn new tasks to recover from the exception. If a task faults, the following expressions with throw the exception: + + - `await task` + - `task.Wait()` + - `task.Result` + - `task.GetAwaiter().GetResult()` + +To observe the exception, access the property. ## UnobservedTaskException event From 47568ac299dd031f17fccd61cd86456dbc60f74c Mon Sep 17 00:00:00 2001 From: Kent Boogaart Date: Tue, 21 Apr 2020 17:32:33 +1000 Subject: [PATCH 04/13] Update import-declarations-the-open-keyword.md (#17973) --- .../language-reference/import-declarations-the-open-keyword.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fsharp/language-reference/import-declarations-the-open-keyword.md b/docs/fsharp/language-reference/import-declarations-the-open-keyword.md index 347ee6e34f8eb..b2bd30d6fc97d 100644 --- a/docs/fsharp/language-reference/import-declarations-the-open-keyword.md +++ b/docs/fsharp/language-reference/import-declarations-the-open-keyword.md @@ -20,7 +20,7 @@ open module-or-namespace-name Referencing code by using the fully qualified namespace or module path every time can create code that is hard to write, read, and maintain. Instead, you can use the `open` keyword for frequently used modules and namespaces so that when you reference a member of that module or namespace, you can use the short form of the name instead of the fully qualified name. This keyword is similar to the `using` keyword in C#, `using namespace` in Visual C++, and `Imports` in Visual Basic. -The module or namespace provided must be in the same project or in a referenced project or assembly. If it is not, you can add a reference to the project, or use the `-reference` command`-`line option (or its abbreviation, `-r`). For more information, see [Compiler Options](compiler-options.md). +The module or namespace provided must be in the same project or in a referenced project or assembly. If it is not, you can add a reference to the project, or use the `-reference` command-line option (or its abbreviation, `-r`). For more information, see [Compiler Options](compiler-options.md). The import declaration makes the names available in the code that follows the declaration, up to the end of the enclosing namespace, module, or file. From daa3068868bf10fb96da94a2fd69d6dd47f29a51 Mon Sep 17 00:00:00 2001 From: David Pine Date: Tue, 21 Apr 2020 07:42:14 -0500 Subject: [PATCH 05/13] A bit more clarification and feedback updates --- .../exception-handling-task-parallel-library.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/standard/parallel-programming/exception-handling-task-parallel-library.md b/docs/standard/parallel-programming/exception-handling-task-parallel-library.md index 01a725d950dcd..5d2f6fa1ca46c 100644 --- a/docs/standard/parallel-programming/exception-handling-task-parallel-library.md +++ b/docs/standard/parallel-programming/exception-handling-task-parallel-library.md @@ -83,14 +83,14 @@ If a task completes in the property. +Use a [`try-catch`](../../csharp/language-reference/keywords/try-catch.md) statement to handle and observe thrown exceptions. Alternatively, observe the exception by accessing the property. ## UnobservedTaskException event From 3df7c1f756ecbb8798cab534eafb47af100b37f1 Mon Sep 17 00:00:00 2001 From: David Pine Date: Tue, 21 Apr 2020 08:31:05 -0500 Subject: [PATCH 06/13] Added latestFeature example --- docs/core/tools/global-json.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/core/tools/global-json.md b/docs/core/tools/global-json.md index f10fb2036068e..61f970c17b75d 100644 --- a/docs/core/tools/global-json.md +++ b/docs/core/tools/global-json.md @@ -1,7 +1,7 @@ --- title: global.json overview description: Learn how to use the global.json file to set the .NET Core SDK version when running .NET Core CLI commands. -ms.date: 01/14/2020 +ms.date: 04/21/2020 ms.custom: "updateeachrelease" --- # global.json overview @@ -113,6 +113,17 @@ The following example shows how to use the exact specified version: } ``` +The following example shows how to use the latest feature band and patch version installed of a specific major and minor version (in the form, 3.1.xxx): + +```json +{ + "sdk": { + "version": "3.1.000", + "rollForward": "latestFeature" + } +} +``` + The following example shows how to use the highest patch version installed of a specific version (in the form, 3.1.1xx): ```json From 82aef2ed7dc412a1f2a8b296b2c8eec0b344b938 Mon Sep 17 00:00:00 2001 From: Theodore Tsirpanis <12659251+teo-tsirpanis@users.noreply.github.com> Date: Tue, 21 Apr 2020 17:20:14 +0300 Subject: [PATCH 07/13] Fix typos in "C# reserved attributes". (#17977) --- docs/csharp/language-reference/attributes/general.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/csharp/language-reference/attributes/general.md b/docs/csharp/language-reference/attributes/general.md index 78fc49e7aa90e..bdcaa71075d40 100644 --- a/docs/csharp/language-reference/attributes/general.md +++ b/docs/csharp/language-reference/attributes/general.md @@ -13,25 +13,25 @@ The `Conditional` attribute makes the execution of a method dependent on a prepr In the following example, `Conditional` is applied to a method to enable or disable the display of program-specific diagnostic information: -::::::code language="csharp" source="snippets/trace.cs" interactive="try-dotnet" ::: +:::code language="csharp" source="snippets/trace.cs" interactive="try-dotnet" ::: If the `TRACE_ON` identifier isn't defined, the trace output isn't displayed. Explore for yourself in the interactive window. The `Conditional` attribute is often used with the `DEBUG` identifier to enable trace and logging features for debug builds but not in release builds, as shown in the following example: -::::::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetConditional" ::: +:::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetConditional" ::: When a method marked conditional is called, the presence or absence of the specified preprocessing symbol determines whether the call is included or omitted. If the symbol is defined, the call is included; otherwise, the call is omitted. A conditional method must be a method in a class or struct declaration and must have a `void` return type. Using `Conditional` is cleaner, more elegant, and less error-prone than enclosing methods inside `#if…#endif` blocks. If a method has multiple `Conditional` attributes, a call to the method is included if at one or more conditional symbols is defined (the symbols are logically linked together by using the OR operator). In the following example, the presence of either `A` or `B` results in a method call: -::::::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetMultipleConditions" ::: +:::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetMultipleConditions" ::: ### Using `Conditional` with attribute classes The `Conditional` attribute can also be applied to an attribute class definition. In the following example, the custom attribute `Documentation` will only add information to the metadata if `DEBUG` is defined. -::::::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetConditionalConditionalAttribute" ::: +:::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetConditionalConditionalAttribute" ::: ## `Obsolete` attribute @@ -39,7 +39,7 @@ The `Obsolete` attribute marks a code element as no longer recommended for use. In the following example the `Obsolete` attribute is applied to class `A` and to method `B.OldMethod`. Because the second argument of the attribute constructor applied to `B.OldMethod` is set to `true`, this method will cause a compiler error, whereas using class `A` will just produce a warning. Calling `B.NewMethod`, however, produces no warning or error. For example, when you use it with the previous definitions, the following code generates two warnings and one error: -::::::code language="csharp" source="snippets/ObsoleteExample.cs" interactive="try-dotnet" ::: +:::code language="csharp" source="snippets/ObsoleteExample.cs" interactive="try-dotnet" ::: The string provided as the first argument to the attribute constructor will be displayed as part of the warning or error. Two warnings for class `A` are generated: one for the declaration of the class reference, and one for the class constructor. The `Obsolete` attribute can be used without arguments, but including an explanation what to use instead is recommended. From fc0523a13673f4e2b0a7f59001b099d01a48bd6f Mon Sep 17 00:00:00 2001 From: Genevieve Warren Date: Tue, 21 Apr 2020 08:14:02 -0700 Subject: [PATCH 08/13] update corefx use (#17972) --- .github/ISSUE_TEMPLATE/dotnet-breaking-change.md | 2 +- docs/core/compatibility/2.0-2.1.md | 2 +- docs/core/compatibility/2.2-3.0.md | 2 +- docs/core/compatibility/2.2-3.1.md | 2 +- docs/core/compatibility/corefx.md | 8 ++++---- docs/core/compatibility/fx-core.md | 2 +- docs/core/compatibility/toc.yml | 2 +- .../migration/differences-from-net-framework.md | 2 +- includes/core-changes/categoryselector.md | 2 +- .../corefx/1.0/filesysteminfo-attributes-exceptions.md | 2 +- includes/core-changes/corefx/2.1/instantiate-struct.md | 2 +- includes/core-changes/corefx/2.1/process-start-changes.md | 2 +- .../corefx/3.0/change-in-null-in-utf8jsonwriter.md | 2 +- .../custom-encoderfallbackbuffer-cannot-be-recursive.md | 2 +- .../corefx/3.0/fieldinfo-setvalue-exception.md | 2 +- .../core-changes/corefx/3.0/floating-point-changes.md | 2 +- .../3.0/floating-point-parsing-does-not-overflow.md | 2 +- .../3.0/jsonencodedtext-encode-has-additional-argument.md | 2 +- .../corefx/3.0/move-invalidasynchronousstateexception.md | 2 +- .../net-core-3-0-follows-unicode-utf8-best-practices.md | 2 +- .../corefx/3.0/serializer-throws-notsupportedexception.md | 2 +- .../corefx/3.0/version-information-changes.md | 2 +- .../core-changes/corefx/openssl-dependencies-macos.md | 2 +- 23 files changed, 26 insertions(+), 26 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/dotnet-breaking-change.md b/.github/ISSUE_TEMPLATE/dotnet-breaking-change.md index f50930f5266c2..31171ed2b546d 100644 --- a/.github/ISSUE_TEMPLATE/dotnet-breaking-change.md +++ b/.github/ISSUE_TEMPLATE/dotnet-breaking-change.md @@ -43,7 +43,7 @@ Also, remove this comment before submitting the issue. - ASP.NET Core - C# - Core -- CoreFx +- Core .NET libraries - Data - Debugger - Deployment for .NET Core diff --git a/docs/core/compatibility/2.0-2.1.md b/docs/core/compatibility/2.0-2.1.md index 27f25204b98bb..6ae6a7eba25b2 100644 --- a/docs/core/compatibility/2.0-2.1.md +++ b/docs/core/compatibility/2.0-2.1.md @@ -7,7 +7,7 @@ ms.date: 12/17/2019 If you're migrating from version 2.0 to version 2.1 of .NET Core, the breaking changes listed in this article may affect your app. -## CoreFx +## Core .NET libraries - [Private fields added to built-in struct types](#private-fields-added-to-built-in-struct-types) - [OpenSSL versions on macOS](#openssl-versions-on-macos) diff --git a/docs/core/compatibility/2.2-3.0.md b/docs/core/compatibility/2.2-3.0.md index 153c5ec9e8208..6a19b2d941433 100644 --- a/docs/core/compatibility/2.2-3.0.md +++ b/docs/core/compatibility/2.2-3.0.md @@ -260,7 +260,7 @@ If you're migrating from version 2.2 to version 3.0 of .NET Core, ASP.NET Core, *** -## CoreFx +## Core .NET libraries - [APIs that report version now report product and not file version](#apis-that-report-version-now-report-product-and-not-file-version) - [Custom EncoderFallbackBuffer instances cannot fall back recursively](#custom-encoderfallbackbuffer-instances-cannot-fall-back-recursively) diff --git a/docs/core/compatibility/2.2-3.1.md b/docs/core/compatibility/2.2-3.1.md index 51e64b8e682e7..edc6d3e19def9 100644 --- a/docs/core/compatibility/2.2-3.1.md +++ b/docs/core/compatibility/2.2-3.1.md @@ -263,7 +263,7 @@ If you're migrating from version 2.2 to version 3.1 of .NET Core, ASP.NET Core, [!INCLUDE[Target framework: .NET Framework not supported](~/includes/core-changes/aspnetcore/3.0/targetfx-netfx-tfm-support.md)] -## CoreFx +## Core .NET libraries - [APIs that report version now report product and not file version](#apis-that-report-version-now-report-product-and-not-file-version) - [Custom EncoderFallbackBuffer instances cannot fall back recursively](#custom-encoderfallbackbuffer-instances-cannot-fall-back-recursively) diff --git a/docs/core/compatibility/corefx.md b/docs/core/compatibility/corefx.md index aab5fcb56af7b..93a555b690e8c 100644 --- a/docs/core/compatibility/corefx.md +++ b/docs/core/compatibility/corefx.md @@ -1,11 +1,11 @@ --- title: Base class library breaking changes -description: Lists the breaking changes in .NET CoreFx, the base class library. -ms.date: "09/20/2019" +description: Lists the breaking changes in core .NET libraries. +ms.date: 09/20/2019 --- -# CoreFx breaking changes +# Core .NET libraries breaking changes -CoreFx provides the primitives and other general types used by .NET Core. +The core .NET libraries provide the primitives and other general types used by .NET Core. The following breaking changes are documented on this page: diff --git a/docs/core/compatibility/fx-core.md b/docs/core/compatibility/fx-core.md index 0f24cc7a23e4a..c06b3c40ea8ed 100644 --- a/docs/core/compatibility/fx-core.md +++ b/docs/core/compatibility/fx-core.md @@ -11,7 +11,7 @@ If you're migrating an app from .NET Framework to .NET Core, the breaking change > [!NOTE] > This article is not a complete list of breaking changes between .NET Framework and .NET Core. The most important breaking changes are added here as we become aware of them. -## CoreFx +## Core .NET libraries - [Change in default value of UseShellExecute](#change-in-default-value-of-useshellexecute) - [UnauthorizedAccessException thrown by FileSystemInfo.Attributes](#unauthorizedaccessexception-thrown-by-filesysteminfoattributes) diff --git a/docs/core/compatibility/toc.yml b/docs/core/compatibility/toc.yml index 8ea89b8afad6e..58fd69d3bb076 100644 --- a/docs/core/compatibility/toc.yml +++ b/docs/core/compatibility/toc.yml @@ -30,7 +30,7 @@ items: - name: ASP.NET Core href: aspnetcore.md - - name: CoreFx + - name: Core .NET libraries href: corefx.md - name: Cryptography href: cryptography.md diff --git a/docs/desktop-wpf/migration/differences-from-net-framework.md b/docs/desktop-wpf/migration/differences-from-net-framework.md index da05628a7554f..5181cee127c59 100644 --- a/docs/desktop-wpf/migration/differences-from-net-framework.md +++ b/docs/desktop-wpf/migration/differences-from-net-framework.md @@ -35,7 +35,7 @@ When your project uses ``, packages aren't stored locally in a Code Access Security (CAS) is not supported by .NET Core or WPF for .NET Core. All CAS-related functionality is treated under the assumption of full-trust. WPF for .NET Core removes CAS-related code. The public API surface of these types still exists to ensure that calls into these types succeed. -Publicly defined CAS-related types were moved out of the WPF assemblies and into the CoreFX assemblies. The WPF assemblies have type-forwarding set to the new location of the moved types. +Publicly defined CAS-related types were moved out of the WPF assemblies and into the Core .NET library assemblies. The WPF assemblies have type-forwarding set to the new location of the moved types. | Source assembly | Target assembly | Type | | --------------- | --------------- | ------------------- | diff --git a/includes/core-changes/categoryselector.md b/includes/core-changes/categoryselector.md index 764d0cfd34579..c62eb623466d0 100644 --- a/includes/core-changes/categoryselector.md +++ b/includes/core-changes/categoryselector.md @@ -1,7 +1,7 @@ > [!div class="op_single_selector"] > > - [ASP.NET Core](~/docs/core/compatibility/aspnetcore.md) -> - [CoreFx](~/docs/core/compatibility/corefx.md) +> - [Core .NET libraries](~/docs/core/compatibility/corefx.md) > - [Cryptography](~/docs/core/compatibility/cryptography.md) > - [EF Core](/ef/core/what-is-new/ef-core-3.0/breaking-changes) > - [Globalization](~/docs/core/compatibility/globalization.md) diff --git a/includes/core-changes/corefx/1.0/filesysteminfo-attributes-exceptions.md b/includes/core-changes/corefx/1.0/filesysteminfo-attributes-exceptions.md index 343706585d181..e630e1db70137 100644 --- a/includes/core-changes/corefx/1.0/filesysteminfo-attributes-exceptions.md +++ b/includes/core-changes/corefx/1.0/filesysteminfo-attributes-exceptions.md @@ -16,7 +16,7 @@ Modify any `catch` statements to catch an and when deserializing, you #### Category -CoreFx +Core .NET libraries #### Affected APIs diff --git a/includes/core-changes/corefx/3.0/version-information-changes.md b/includes/core-changes/corefx/3.0/version-information-changes.md index 3054653b35bfc..1ebc99f1093ce 100644 --- a/includes/core-changes/corefx/3.0/version-information-changes.md +++ b/includes/core-changes/corefx/3.0/version-information-changes.md @@ -20,7 +20,7 @@ None. This change should make version detection intuitive rather than obtuse. #### Category -CoreFx +Core .NET libraries #### Affected APIs diff --git a/includes/core-changes/corefx/openssl-dependencies-macos.md b/includes/core-changes/corefx/openssl-dependencies-macos.md index ff7175983d6b0..d5f1b069ef819 100644 --- a/includes/core-changes/corefx/openssl-dependencies-macos.md +++ b/includes/core-changes/corefx/openssl-dependencies-macos.md @@ -34,7 +34,7 @@ With this change, the behavior for the .NET Core runtimes on macOS is as follows #### Category -CoreFx +Core .NET libraries #### Affected APIs From ddaddba0008289a3641d03333be665dc0700c2af Mon Sep 17 00:00:00 2001 From: David Pine Date: Tue, 21 Apr 2020 11:36:56 -0500 Subject: [PATCH 09/13] Taking ownership of a few .NET Standard areas from Genevieve --- .github/CODEOWNERS | 6 +++--- docfx.json | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 557fcd451763c..21d42b5b33b39 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -123,7 +123,7 @@ # Analyzers /docs/standard/analyzers/ @gewarren # Assembly -/docs/standard/assembly/ @gewarren +/docs/standard/assembly/ @IEvangelist # Asynchronous Programming Patterns /docs/standard/asynchronous-programming-patterns/ @BillWagner # Attributes @@ -141,7 +141,7 @@ # Design guidelines /docs/standard/design-guidelines/ @BillWagner # Events -/docs/standard/events/ @gewarren +/docs/standard/events/ @IEvangelist # Exceptions /docs/standard/exceptions/ @tdykstra # GC @@ -163,7 +163,7 @@ # Parallel programming /docs/standard/parallel-programming/ @BillWagner # Security -/docs/standard/security/ @gewarren +/docs/standard/security/ @IEvangelist # Serialization /docs/standard/serialization/ @tdykstra # Threading diff --git a/docfx.json b/docfx.json index 2dee4e1519021..df1957e6ca2a0 100644 --- a/docfx.json +++ b/docfx.json @@ -259,7 +259,7 @@ "docs/spark/**/**.md": "mamccrea", "docs/standard/**/**.md": "gewarren", "docs/standard/analyzers/**/**.md": "gewarren", - "docs/standard/assembly/**/**.md": "gewarren", + "docs/standard/assembly/**/**.md": "IEvangelist", "docs/standard/asynchronous-programming-patterns/**/**.md": "billwagner", "docs/standard/attributes/**/**.md": "tdykstra", "docs/standard/base-types/**/**.md": "Thraka", @@ -268,7 +268,7 @@ "docs/standard/data/sqlite/**/**.md": "bricelam", "docs/standard/datetime/**/**.md": "Thraka", "docs/standard/design-guidelines/**/**.md": "KrzysztofCwalina", - "docs/standard/events/**/**.md": "gewarren", + "docs/standard/events/**/**.md": "IEvangelist", "docs/standard/exceptions/**/**.md": "tdykstra", "docs/standard/garbage-collection/**/**.md": "gewarren", "docs/standard/generics/**/**.md": "Thraka", @@ -279,7 +279,7 @@ "docs/standard/memory-and-spans/**/**.md": "tdykstra", "docs/standard/native-interop/**/**.md": "jkoritzinsky", "docs/standard/parallel-programming/**/**.md": "billwagner", - "docs/standard/security/**/**.md": "gewarren", + "docs/standard/security/**/**.md": "IEvangelist", "docs/standard/serialization/**/**.md": "tdykstra", "docs/standard/threading/**/**.md": "billwagner", "docs/standard/whats-new/**/**.md": "gewarren", @@ -346,7 +346,7 @@ "docs/spark/**/**.md": "mamccrea", "docs/standard/**/**.md": "gewarren", "docs/standard/analyzers/**/**.md": "gewarren", - "docs/standard/assembly/**/**.md": "gewarren", + "docs/standard/assembly/**/**.md": "dapine", "docs/standard/asynchronous-programming-patterns/**/**.md": "wiwagn", "docs/standard/attributes/**/**.md": "tdykstra", "docs/standard/base-types/**/**.md": "adegeo", @@ -355,7 +355,7 @@ "docs/standard/data/sqlite/**/**.md": "bricelam", "docs/standard/datetime/**/**.md": "adegeo", "docs/standard/design-guidelines/**/**.md": "kcwalina", - "docs/standard/events/**/**.md": "gewarren", + "docs/standard/events/**/**.md": "dapine", "docs/standard/exceptions/**/**.md": "tdykstra", "docs/standard/garbage-collection/**/**.md": "gewarren", "docs/standard/generics/**/**.md": "adegeo", @@ -366,7 +366,7 @@ "docs/standard/memory-and-spans/**/**.md": "tdykstra", "docs/standard/native-interop/**/**.md": "jekoritz", "docs/standard/parallel-programming/**/**.md": "wiwagn", - "docs/standard/security/**/**.md": "gewarren", + "docs/standard/security/**/**.md": "dapine", "docs/standard/serialization/**/**.md": "tdykstra", "docs/standard/threading/**/**.md": "wiwagn", "docs/standard/whats-new/**/**.md": "dotnetcontent", From 77447314515897e1e8efab43ab703443219d3a57 Mon Sep 17 00:00:00 2001 From: David Pine Date: Tue, 21 Apr 2020 11:46:34 -0500 Subject: [PATCH 10/13] And another... :) --- .github/CODEOWNERS | 2 +- docfx.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 21d42b5b33b39..5d289d76ebe41 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -121,7 +121,7 @@ ################## .NET STANDARD ################## # Analyzers -/docs/standard/analyzers/ @gewarren +/docs/standard/analyzers/ @IEvangelist # Assembly /docs/standard/assembly/ @IEvangelist # Asynchronous Programming Patterns diff --git a/docfx.json b/docfx.json index df1957e6ca2a0..fcdba7638db64 100644 --- a/docfx.json +++ b/docfx.json @@ -258,7 +258,7 @@ "docs/machine-learning/**/**.md": "natke", "docs/spark/**/**.md": "mamccrea", "docs/standard/**/**.md": "gewarren", - "docs/standard/analyzers/**/**.md": "gewarren", + "docs/standard/analyzers/**/**.md": "IEvangelist", "docs/standard/assembly/**/**.md": "IEvangelist", "docs/standard/asynchronous-programming-patterns/**/**.md": "billwagner", "docs/standard/attributes/**/**.md": "tdykstra", @@ -345,7 +345,7 @@ "docs/machine-learning/**/**.md": "nakersha", "docs/spark/**/**.md": "mamccrea", "docs/standard/**/**.md": "gewarren", - "docs/standard/analyzers/**/**.md": "gewarren", + "docs/standard/analyzers/**/**.md": "dapine", "docs/standard/assembly/**/**.md": "dapine", "docs/standard/asynchronous-programming-patterns/**/**.md": "wiwagn", "docs/standard/attributes/**/**.md": "tdykstra", From 2613e8e82bb35c999ae1ab68204b3bd50a17a9f1 Mon Sep 17 00:00:00 2001 From: Pikabanga Date: Tue, 21 Apr 2020 19:24:29 +0200 Subject: [PATCH 11/13] Update dotnet-restore.md (#17978) According to https://github.com/NuGet/Home/issues/3116#issuecomment-586117187 --no-cache actually doesn't ignore packages folders, but only caches HTTP requests. --- docs/core/tools/dotnet-restore.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/tools/dotnet-restore.md b/docs/core/tools/dotnet-restore.md index fc637db5e94a7..1326a8ce2441b 100644 --- a/docs/core/tools/dotnet-restore.md +++ b/docs/core/tools/dotnet-restore.md @@ -114,7 +114,7 @@ Sometimes, it might be inconvenient to run `dotnet restore` implicitly. For exam - **`--no-cache`** - Specifies to not cache packages and HTTP requests. + Specifies to not cache HTTP requests. - **`--no-dependencies`** From 068070cd2d530af1f28c8e1882e0db35707de45b Mon Sep 17 00:00:00 2001 From: David Pine Date: Tue, 21 Apr 2020 12:56:11 -0500 Subject: [PATCH 12/13] Remove unecessary parentheses --- docs/core/tools/global-json.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/tools/global-json.md b/docs/core/tools/global-json.md index 61f970c17b75d..9a02e917fb55d 100644 --- a/docs/core/tools/global-json.md +++ b/docs/core/tools/global-json.md @@ -113,7 +113,7 @@ The following example shows how to use the exact specified version: } ``` -The following example shows how to use the latest feature band and patch version installed of a specific major and minor version (in the form, 3.1.xxx): +The following example shows how to use the latest feature band and patch version installed of a specific major and minor version: ```json { From cf1c777a74d2e5ec9267d0e7a24c8bb69d7e0845 Mon Sep 17 00:00:00 2001 From: Najeeb Kazmi Date: Tue, 21 Apr 2020 11:23:47 -0700 Subject: [PATCH 13/13] Typo in Install Extra Dependencies (#17992) --- .../how-to-guides/install-extra-dependencies.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/machine-learning/how-to-guides/install-extra-dependencies.md b/docs/machine-learning/how-to-guides/install-extra-dependencies.md index 0992f46347a2b..550c6ea141d33 100644 --- a/docs/machine-learning/how-to-guides/install-extra-dependencies.md +++ b/docs/machine-learning/how-to-guides/install-extra-dependencies.md @@ -82,7 +82,7 @@ No extra installation steps required. The library is installed when the NuGet pa 5. Add this location to the load library path: ```bash - sudo ldconfig /opt/intel/compilers_and_libraries_2020.0.166/linux/compiler/lib/intel64_li + sudo ldconfig /opt/intel/compilers_and_libraries_2020.0.166/linux/compiler/lib/intel64_lin ``` ### Mac