-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add nested loops #18039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BillWagner
merged 5 commits into
dotnet:master
from
BillWagner:add-nested-loops-example
Apr 23, 2020
Merged
Add nested loops #18039
BillWagner
merged 5 commits into
dotnet:master
from
BillWagner:add-nested-loops-example
Apr 23, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The beginner loops tutorial does not contain any examples of nested loops. Add a beginner example to both the interactive and local versions. Fixes dotnet#17208
pkulikov
reviewed
Apr 23, 2020
docs/csharp/tutorials/intro-to-csharp/branches-and-loops-local.md
Outdated
Show resolved
Hide resolved
pkulikov
reviewed
Apr 23, 2020
Co-Authored-By: Petr Kulikov <petr.kulikov@gmail.com>
tdykstra
approved these changes
Apr 23, 2020
Contributor
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple minor suggestions. What is the YAML file used for?
docs/csharp/tutorials/intro-to-csharp/branches-and-loops-local.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tom Dykstra <tdykstra@microsoft.com>
Member
Author
That's how we build the step-by-step interactive tutorials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beginner loops tutorial does not contain any examples of nested loops.
Add a beginner example to both the interactive and local versions.
Fixes #17208
internal review link - interactive
Internal review link - local