top level statements are in the global namespace #28406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#28249 The compiler generated program class and `Main` method are declared in the global namespace, not a namespace matching the project name.
Point out that local functions can't include any access modifiers. Fixes dotnet#25960
tdykstra
approved these changes
Feb 26, 2022
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
Looks great, one suggestion to remove a comma that became superfluous when an item was removed from the series.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28249
The compiler generated program class and
Mainmethod are declared in the global namespace, not a namespace matching the project name.Fixes #25960
Add a clarifying statements that local functions cannot include access modifiers.