From cee2ba1741f9ce4156a0d3bf9c40adf5aff08032 Mon Sep 17 00:00:00 2001 From: Pavel Voronin Date: Wed, 8 Jun 2022 00:13:19 +0200 Subject: [PATCH 1/3] Fix note mistake: ObservableGauge can be substituted with ObservableCounter With the previous wording it was weird: ObservableGauge can be substituted with ObservableGauge. If I am not mistaken `ObservableCounter` was meant there. --- docs/core/diagnostics/metrics-instrumentation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/metrics-instrumentation.md b/docs/core/diagnostics/metrics-instrumentation.md index a3df09f7cd6ae..480d606c1cbf8 100644 --- a/docs/core/diagnostics/metrics-instrumentation.md +++ b/docs/core/diagnostics/metrics-instrumentation.md @@ -173,7 +173,7 @@ Types of instruments currently available: > [!NOTE] > OpenTelemetry also defines an UpDownCounter not currently present in the .NET API. ObservableGauge can usually be substituted by defining a variable to store the running -> total and reporting the value of that variable in the ObservableGauge callback. +> total and reporting the value of that variable in the ObservableCounter callback. ### Example of different instrument types From 46624a44836ccc22a061ebeac024ca01a6d8f68f Mon Sep 17 00:00:00 2001 From: Pavel Voronin Date: Thu, 9 Jun 2022 23:47:32 +0200 Subject: [PATCH 2/3] Update docs/core/diagnostics/metrics-instrumentation.md Co-authored-by: Noah Falk --- docs/core/diagnostics/metrics-instrumentation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/metrics-instrumentation.md b/docs/core/diagnostics/metrics-instrumentation.md index 480d606c1cbf8..52f56a7adfa5f 100644 --- a/docs/core/diagnostics/metrics-instrumentation.md +++ b/docs/core/diagnostics/metrics-instrumentation.md @@ -172,7 +172,7 @@ Types of instruments currently available: - Other common cases, such as business metrics, physical sensors, cache hit rates, or sizes of caches, queues, and files are usually well suited for `ObservableGauge`. > [!NOTE] -> OpenTelemetry also defines an UpDownCounter not currently present in the .NET API. ObservableGauge can usually be substituted by defining a variable to store the running +> OpenTelemetry also defines an UpDownCounter not currently present in the .NET API. UpDownCounter can usually be substituted by defining a variable to store the running > total and reporting the value of that variable in the ObservableCounter callback. ### Example of different instrument types From b5920b35c1e67318e535c1c2a1ec3c292ced84c4 Mon Sep 17 00:00:00 2001 From: Pavel Voronin Date: Thu, 9 Jun 2022 23:47:46 +0200 Subject: [PATCH 3/3] Update docs/core/diagnostics/metrics-instrumentation.md Co-authored-by: Noah Falk --- docs/core/diagnostics/metrics-instrumentation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/metrics-instrumentation.md b/docs/core/diagnostics/metrics-instrumentation.md index 52f56a7adfa5f..3038047440ef7 100644 --- a/docs/core/diagnostics/metrics-instrumentation.md +++ b/docs/core/diagnostics/metrics-instrumentation.md @@ -173,7 +173,7 @@ Types of instruments currently available: > [!NOTE] > OpenTelemetry also defines an UpDownCounter not currently present in the .NET API. UpDownCounter can usually be substituted by defining a variable to store the running -> total and reporting the value of that variable in the ObservableCounter callback. +> total and reporting the value of that variable in the ObservableGauge callback. ### Example of different instrument types