Fsharp Stroustrup style guide #33171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
|
nojaf
reviewed
Dec 22, 2022
josh-degraw
requested review from
nojaf and
TheAngryByrd
and removed request for
nojaf and
TheAngryByrd
nojaf
approved these changes
Jan 17, 2023
|
@nojaf I'd also like to discuss my other comment around the name choice to use here -- whether or not "Stroustrup" is the best name and pros & cons of other options. I think better late than never but this PR is probably the point of no return for any potential style name changes. |
|
@josh-degraw thanks for reminding me. I didn't really have much to add there. |
dsyme
approved these changes
Jan 26, 2023
gewarren
reviewed
Jan 26, 2023
|
@gewarren Thank you for the suggestions! I'll add those changes in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to update the style guide to allow for "Stroustrup" formatting as discussed in fsharp/fslang-design#706.
There may still be several points which have not been agreed upon or that need further refinement. For now this is very much still considered a work in progress.
CC: @nojaf