Repository navigation
Expand warnings in compare-strings.md - #35171
Conversation
|
(Can I see the problem with the |
|
This change seems too vague. Instead of stating that "many" methods default to current culture, it's better to link to existing article that lists them: https://learn.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings#string-comparisons-that-use-the-current-culture Also "unless overridden" is not really a correct term to use here. You probable meant something like "unless another string comparison option is passed explicitly"? |
|
How about "Many methods" but hyperlinked to the page you suggest? I'm not sure what one does to a default other than override it or accept it, but sure, I'm happy to be more verbose here if you like. |
Seems fine to me
The issue is that "overriding a method" in .NET typically refers to adding a virtual method implementation in derived class. It don't have to be verbose, but it's best not to use terms in confusing way. |
This is an enhancement we've requested. At this time, no. It's behind an AAD firewall. In this instance, it was a problem allocating build resources. Closing and reopening to force a new build. |
BillWagner
left a comment
There was a problem hiding this comment.
Thanks @Smaug123 This is a good addition. I had a suggestion on wording. Once we resolve that discussion, this is ready to merge.
|
Ah, I had forgotten that |
Summary
Add two sentences in the "Linguistic Comparison" section of the "How to compare strings" documentation, noting that this is in fact the default behaviour for many methods and noting one particularly common way people discover this fact as having created a bug in their code.
(Related to #35069; raised off the back of dotnet/dotnet-api-docs#8973 .)
Internal previews