Skip to content

Update Azure SDK DI doc for additional app builders #36298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 26, 2023
Merged

Update Azure SDK DI doc for additional app builders #36298

merged 19 commits into from
Jul 26, 2023

Conversation

@scottaddie
Copy link
Member

@scottaddie scottaddie commented Jul 18, 2023 •
edited by github-actions bot
Loading

Summary of changes

  • Add HostApplicationBuilder and HostBuilder code samples
  • Add supporting sample apps to support importing code samples and line highlighting
  • Explain significance of key names used in JSON config files
  • Incorporate Acrolinx feedback

Internal previews

📄 File 🔗 Preview link
docs/azure/sdk/dependency-injection.md Dependency injection with the Azure SDK for .NET
docs/azure/sdk/logging.md Logging with the Azure SDK for .NET

@dotnet-bot dotnet-bot added this to the July 2023 milestone Jul 18, 2023
@scottaddie scottaddie marked this pull request as ready for review July 19, 2023 18:38
@scottaddie scottaddie changed the title Update Azure SDK DI doc for additional app builder Update Azure SDK DI doc for additional app builders Jul 19, 2023
@scottaddie
Copy link
Member Author

scottaddie commented Jul 20, 2023

@JoshLove-msft @jsquire Please review

mattchenderson
mattchenderson approved these changes Jul 20, 2023
View reviewed changes
Copy link

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - definitely appreciate the extra generic HostBuilder examples!

alexwolfmsft
alexwolfmsft reviewed Jul 20, 2023
View reviewed changes
alexwolfmsft
alexwolfmsft reviewed Jul 20, 2023
View reviewed changes
alexwolfmsft
alexwolfmsft reviewed Jul 20, 2023
View reviewed changes
jsquire
jsquire reviewed Jul 20, 2023
View reviewed changes
@scottaddie scottaddie mentioned this pull request Jul 25, 2023
Closed
@scottaddie
Copy link
Member Author

scottaddie commented Jul 25, 2023

@JoshLove-msft I'm interested in your feedback too.

alexwolfmsft
alexwolfmsft reviewed Jul 25, 2023
View reviewed changes
@scottaddie scottaddie requested a review from JoshLove-msft July 25, 2023 22:11
@scottaddie scottaddie merged commit a06979c into main Jul 26, 2023
@scottaddie scottaddie deleted the scottaddie/azure-sdk-di branch July 26, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@alexwolfmsft alexwolfmsft alexwolfmsft approved these changes

@CamSoper CamSoper Awaiting requested review from CamSoper

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

+1 more reviewer

@mattchenderson mattchenderson mattchenderson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dotnet-azure/svc

Projects

None yet

Milestone

July 2023

Development

Successfully merging this pull request may close these issues.

8 participants

@scottaddie @jsquire @mattchenderson @IEvangelist @JoshLove-msft @alexwolfmsft @dotnet-bot