From b2ea6e8b39bdff32314ac1df5d42a53913d85ba9 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 26 Sep 2023 11:08:50 -0400 Subject: [PATCH 1/6] use new feedback control in dependent repos The docfx.json changes to enable the updated feedback control didn't turn it on in the dependent repos we have. Make that change. While at it, add the latest compiler breaking changes article to the TOC and build. --- docfx.json | 7 +++++++ docs/csharp/toc.yml | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/docfx.json b/docfx.json index 9539fd53be0e2..5465a156c3a8f 100644 --- a/docfx.json +++ b/docfx.json @@ -162,6 +162,10 @@ }, "fileMetadata": { "feedback_system": { + "_csharplang/**.*": "OpenSource", + "_csharpstandard/standard/*.md": "OpenSource", + "_vblang/**.*": "OpenSource", + "_roslyn/**.*": "OpenSource", "docs/**.*": "OpenSource", "docs/standard/design-guidelines/**/**.md": "None", "docs/framework/data/adonet/**/**.md": "None", @@ -486,6 +490,7 @@ "_csharplang/proposals/csharp-11.0/*.md": "09/30/2022", "_csharplang/proposals/csharp-12.0/*.md": "08/15/2023", "_roslyn/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md": "11/08/2022", + "_roslyn/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md": "09/26/2023", "_vblang/spec/*.md": "07/21/2017" }, "ms.technology": { @@ -692,6 +697,7 @@ "_roslyn/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md": "C# compiler breaking changes since C# 10", + "_roslyn/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md": "C# compiler breaking changes since C# 11", "_vblang/spec/introduction.md": "Introduction", "_vblang/spec/lexical-grammar.md": "Lexical grammar", "_vblang/spec/preprocessing-directives.md": "Preprocessing directives", @@ -805,6 +811,7 @@ "_csharplang/proposals/csharp-12.0/experimental-attribute.md": "Use the ExperimentalAttribute attribute to indicate APIs that aren't stable.", "_roslyn/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md": "Learn about any breaking changes since the initial release of C# 10", + "_roslyn/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md": "Learn about any breaking changes since the initial release of C# 11", "_vblang/spec/introduction.md": "This chapter provides and introduction to the Visual Basic language.", "_vblang/spec/lexical-grammar.md": "This chapter defines the lexical grammar for Visual Basic.", "_vblang/spec/preprocessing-directives.md": "This chapter defines the preprocessing directives allowed in Visual Basic", diff --git a/docs/csharp/toc.yml b/docs/csharp/toc.yml index 6f1a7ff6e209e..d74b99c5f9cd0 100644 --- a/docs/csharp/toc.yml +++ b/docs/csharp/toc.yml @@ -151,12 +151,14 @@ items: - name: C# 12 displayName: what's New href: whats-new/csharp-12.md + - name: Breaking changes in C# 12 + href: ../../_roslyn/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20DotNet%208.md - name: C# 11 items: - name: New features displayName: what's new href: whats-new/csharp-11.md - - name: Breaking changes + - name: Breaking changes in C# 11 href: ../../_roslyn/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20DotNet%207.md - name: C# 10 href: whats-new/csharp-10.md From 1bf7227737770442104394df668a7336633830e0 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 26 Sep 2023 11:46:05 -0400 Subject: [PATCH 2/6] add more of the necessary keys --- docfx.json | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/docfx.json b/docfx.json index 5465a156c3a8f..d7dca3ee40834 100644 --- a/docfx.json +++ b/docfx.json @@ -174,19 +174,39 @@ "docs/framework/wcf/**/**.md": "None" }, "open_source_feedback_contributorGuideUrl": { - "docs/**/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute" + "docs/**/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute", + "_csharplang/**.*": "OpenSource", + "_csharpstandard/standard/*.md": "OpenSource", + "_vblang/**.*": "OpenSource", + "_roslyn/**.*": "OpenSource" }, "open_source_feedback_issueUrl": { - "docs/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml" + "docs/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", + "_csharplang/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", + "_csharpstandard/standard/*.md": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", + "_vblang/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", + "_roslyn/**.*": "OpenSource" }, "open_source_feedback_productName": { - "docs/**.*": ".NET feedback" + "docs/**.*": ".NET feedback", + "_csharplang/**.*": "C# Feature specification feedback", + "_csharpstandard/standard/*.md": "C# Standard documentation feedback", + "_vblang/**.*": "VB Language spec feedback", + "_roslyn/**.*": "roslyn breaking feedback" }, "open_source_feedback_productDescription": { - "docs/**.*": "The .NET documentation is open source. Provide feedback here." + "docs/**.*": "The .NET documentation is open source. Provide feedback here.", + "_csharplang/**.*": "The C# feature specifications are open source. Provide feedback here.", + "_csharpstandard/standard/*.md": "The C# Standard documentation is open source. Provide feedback here.", + "_vblang/**.*": "The VB Language documentation is open source. Provide feedback here.", + "_roslyn/**.*": "The rolsyn documentation is open source. Provide feedback here." }, "open_source_feedback_issueTitle": { - "docs/**.*": "" + "docs/**.*": "", + "_csharplang/**.*": "", + "_csharpstandard/standard/*.md": "", + "_vblang/**.*": "", + "_roslyn/**.*": "" }, "open_source_feedback_productLogoLightUrl": { "docs/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg" From 07503eaad775faedc6191fa04e2e2f4cf40d68c2 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 26 Sep 2023 12:04:42 -0400 Subject: [PATCH 3/6] yet more config --- docfx.json | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/docfx.json b/docfx.json index d7dca3ee40834..20efa53760990 100644 --- a/docfx.json +++ b/docfx.json @@ -209,10 +209,18 @@ "_roslyn/**.*": "" }, "open_source_feedback_productLogoLightUrl": { - "docs/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg" + "docs/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_csharplang/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_csharpstandard/standard/*.md": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_vblang/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_roslyn/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg" }, "open_source_feedback_productLogoDarkUrl": { - "docs/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg" + "docs/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_csharplang/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_csharpstandard/standard/*.md": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_vblang/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg", + "_roslyn/**.*": "https://learn.microsoft.com/media/logos/logo_net.svg" }, "social_image_url": { "docs/**/*.*": "/dotnet/media/dotnet-logo.png", From 455fc47a669a5471dba1ff090c5b69862e5f2f1e Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 26 Sep 2023 12:50:19 -0400 Subject: [PATCH 4/6] fix formatting and links --- docfx.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docfx.json b/docfx.json index 20efa53760990..47536cb26e606 100644 --- a/docfx.json +++ b/docfx.json @@ -174,11 +174,11 @@ "docs/framework/wcf/**/**.md": "None" }, "open_source_feedback_contributorGuideUrl": { - "docs/**/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute", - "_csharplang/**.*": "OpenSource", - "_csharpstandard/standard/*.md": "OpenSource", - "_vblang/**.*": "OpenSource", - "_roslyn/**.*": "OpenSource" + "docs/**/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute", + "_csharplang/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute", + "_csharpstandard/standard/*.md": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute", + "_vblang/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute", + "_roslyn/**.*": "https://learn.microsoft.com/contribute/content/dotnet/dotnet-contribute" }, "open_source_feedback_issueUrl": { "docs/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", From 28462e3ab4eba9fef87b2e8b316a9f8fce338e8f Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 26 Sep 2023 12:51:35 -0400 Subject: [PATCH 5/6] one more paste error --- docfx.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docfx.json b/docfx.json index 47536cb26e606..ac3df8d251860 100644 --- a/docfx.json +++ b/docfx.json @@ -185,7 +185,7 @@ "_csharplang/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", "_csharpstandard/standard/*.md": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", "_vblang/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml", - "_roslyn/**.*": "OpenSource" + "_roslyn/**.*": "https://github.com/dotnet/docs/issues/new?template=customer-feedback.yml" }, "open_source_feedback_productName": { "docs/**.*": ".NET feedback", From 67bc62e01cd11af779397e4fdb73016d9b6ac599 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Tue, 26 Sep 2023 13:03:30 -0400 Subject: [PATCH 6/6] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- docfx.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docfx.json b/docfx.json index ac3df8d251860..6d1112346a36b 100644 --- a/docfx.json +++ b/docfx.json @@ -189,17 +189,17 @@ }, "open_source_feedback_productName": { "docs/**.*": ".NET feedback", - "_csharplang/**.*": "C# Feature specification feedback", + "_csharplang/**.*": "C# feature specification feedback", "_csharpstandard/standard/*.md": "C# Standard documentation feedback", - "_vblang/**.*": "VB Language spec feedback", - "_roslyn/**.*": "roslyn breaking feedback" + "_vblang/**.*": "Visual Basic language spec feedback", + "_roslyn/**.*": "Roslyn breaking feedback" }, "open_source_feedback_productDescription": { "docs/**.*": "The .NET documentation is open source. Provide feedback here.", "_csharplang/**.*": "The C# feature specifications are open source. Provide feedback here.", "_csharpstandard/standard/*.md": "The C# Standard documentation is open source. Provide feedback here.", - "_vblang/**.*": "The VB Language documentation is open source. Provide feedback here.", - "_roslyn/**.*": "The rolsyn documentation is open source. Provide feedback here." + "_vblang/**.*": "The Visual Basic language documentation is open source. Provide feedback here.", + "_roslyn/**.*": "The Roslyn documentation is open source. Provide feedback here." }, "open_source_feedback_issueTitle": { "docs/**.*": "",