Skip to content

Update ca1873.md #50136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Update ca1873.md #50136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b6fb7
Update ca1873.md
abhiramch018 Nov 26, 2025
25bf61e
Remove extra line
meaghanlewis Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/fundamentals/code-analysis/quality-rules/ca1873.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ In many situations, logging is disabled or set to a log level that results in an

## Rule description

When logging methods are called, their arguments are evaluated regardless of whether the logging level is enabled. This can result in expensive operations being executed even when the log message won't be written. For better performance, guard expensive logging calls with a check to <xref:Microsoft.Extensions.Logging.ILogger.IsEnabled%2A> or use the `LoggerMessage` pattern.
When logging methods are called, their arguments are evaluated regardless of whether the logging level is enabled. This can result in expensive operations being executed even when the log message won't be written. For better performance, guard expensive logging calls with a check to <xref:Microsoft.Extensions.Logging.ILogger.IsEnabled%2A> or use **source-generated logging** with the <xref:Microsoft.Extensions.Logging.LoggerMessageAttribute> attribute.

## How to fix violations

To fix a violation of this rule, use one of the following approaches:

- Guard the logging call with a check to <xref:Microsoft.Extensions.Logging.ILogger.IsEnabled%2A>.
- Use the `LoggerMessage` pattern with <xref:Microsoft.Extensions.Logging.LoggerMessageAttribute>.
- Use **source-generated logging** with the <xref:Microsoft.Extensions.Logging.LoggerMessageAttribute> attribute for better performance and compile-time safety.
- Ensure expensive operations aren't performed in logging arguments unless necessary.

## Example
Expand Down