Changed cross-reference, fenced xml #5544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkulikov
reviewed
May 22, 2018
| The example generates an .xml file with the following contents: | ||
|
|
||
| ```xml | ||
| // This .xml file was generated with the previous code sample. |
Contributor
There was a problem hiding this comment.
That line can be removed as the line above introduces the file contents.
Contributor
Author
There was a problem hiding this comment.
Thanks for noticing that, @pkulikov! I'd added the introductory line above so that this line could be removed -- and then I forgot to remove it.
mairaw
reviewed
May 22, 2018
| A value tag is used to describe the property value</value> | ||
| </member> | ||
| </members> | ||
| \</doc> |
mairaw
approved these changes
May 22, 2018
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
LGTM. Just need to fix the nit I found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed cross-reference, fenced xml
This PR:
Fixes #5529
@Keboo