From 02640d9bd91bdf98f2a96cef3350f18d3c9c860c Mon Sep 17 00:00:00 2001
From: FilipToth <filip.toth@accelley.com>
Date: Tue, 15 Oct 2024 06:57:44 -0400
Subject: [PATCH 1/3] Add docs remarks for IsRealNumber handling of infinities

---
 xml/System.Numerics/Complex.xml               | 2 ++
 xml/System.Numerics/INumberBase`1.xml         | 2 ++
 xml/System.Runtime.InteropServices/NFloat.xml | 2 ++
 xml/System/Double.xml                         | 2 ++
 xml/System/Half.xml                           | 2 ++
 xml/System/Single.xml                         | 2 ++
 6 files changed, 12 insertions(+)

diff --git a/xml/System.Numerics/Complex.xml b/xml/System.Numerics/Complex.xml
index 5753ef8f85c..c09aea47ffa 100644
--- a/xml/System.Numerics/Complex.xml
+++ b/xml/System.Numerics/Complex.xml
@@ -2292,6 +2292,8 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
+This function also returns `true` for <xref:System.Numerics.Infinity> and a complex number `a + bi` where `a` is infinity, but not `b`.
+
           ]]></format>
         </remarks>
         <inheritdoc cref="M:System.Numerics.INumberBase`1.IsRealNumber(`0)" />
diff --git a/xml/System.Numerics/INumberBase`1.xml b/xml/System.Numerics/INumberBase`1.xml
index ec76083e56f..6eb41ac947d 100644
--- a/xml/System.Numerics/INumberBase`1.xml
+++ b/xml/System.Numerics/INumberBase`1.xml
@@ -782,6 +782,8 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
+This function also returns `true` for positive and negative infinity.
+
           ]]></format>
         </remarks>
       </Docs>
diff --git a/xml/System.Runtime.InteropServices/NFloat.xml b/xml/System.Runtime.InteropServices/NFloat.xml
index adda2d7805e..161b0cb0f50 100644
--- a/xml/System.Runtime.InteropServices/NFloat.xml
+++ b/xml/System.Runtime.InteropServices/NFloat.xml
@@ -2414,6 +2414,8 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
+This function also returns `true` for <xref:System.Runtime.InteropServices.NFloat.PositiveInfinity> and <xref:System.Runtime.InteropServices.NFloat.NegativeInfinity>.
+
           ]]></format>
         </remarks>
         <inheritdoc cref="M:System.Numerics.INumberBase`1.IsRealNumber(`0)" />
diff --git a/xml/System/Double.xml b/xml/System/Double.xml
index 4648e9456c0..9c7766bf024 100644
--- a/xml/System/Double.xml
+++ b/xml/System/Double.xml
@@ -3154,6 +3154,8 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
+This function also returns `true` for <xref:System.Double.PositiveInfinity> and <xref:System.Double.NegativeInfinity>.
+
           ]]></format>
         </remarks>
         <inheritdoc cref="M:System.Numerics.INumberBase`1.IsRealNumber(`0)" />
diff --git a/xml/System/Half.xml b/xml/System/Half.xml
index 85e27961d12..018a12801fa 100644
--- a/xml/System/Half.xml
+++ b/xml/System/Half.xml
@@ -2360,6 +2360,8 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
+This function also returns `true` for <xref:System.Half.PositiveInfinity> and <xref:System.Half.NegativeInfinity>.
+
           ]]></format>
         </remarks>
         <inheritdoc cref="M:System.Numerics.INumberBase`1.IsRealNumber(`0)" />
diff --git a/xml/System/Single.xml b/xml/System/Single.xml
index a724fd54153..8d73f7a1a64 100644
--- a/xml/System/Single.xml
+++ b/xml/System/Single.xml
@@ -3171,6 +3171,8 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
+This function also returns `true` for <xref:System.Single.PositiveInfinity> and <xref:System.Single.NegativeInfinity>.
+
           ]]></format>
         </remarks>
         <inheritdoc cref="M:System.Numerics.INumberBase`1.IsRealNumber(`0)" />

From e07db1b33c20d9d880930621b3cca03520dbd5c2 Mon Sep 17 00:00:00 2001
From: FilipToth <filip.toth@accelley.com>
Date: Tue, 15 Oct 2024 10:55:35 -0400
Subject: [PATCH 2/3] Fix xref and clarify edge case in Complex

---
 xml/System.Numerics/Complex.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xml/System.Numerics/Complex.xml b/xml/System.Numerics/Complex.xml
index c09aea47ffa..bc371a2c303 100644
--- a/xml/System.Numerics/Complex.xml
+++ b/xml/System.Numerics/Complex.xml
@@ -2292,7 +2292,7 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for <xref:System.Numerics.Infinity> and a complex number `a + bi` where `a` is infinity, but not `b`.
+This function also returns `true` for a complex number `a + bi` where `a` is infinity, but not `b`, and does not return true for <xref:System.Numerics.Complex.Infinity>.
 
           ]]></format>
         </remarks>

From de098e3d86b2a0b815db6ad316b6d98f23b212e1 Mon Sep 17 00:00:00 2001
From: FilipToth <filip.toth@accelley.com>
Date: Wed, 16 Oct 2024 12:24:27 -0400
Subject: [PATCH 3/3] Reword IsRealNumber docs for better clarity

---
 xml/System.Numerics/Complex.xml               | 2 --
 xml/System.Numerics/INumberBase`1.xml         | 2 +-
 xml/System.Runtime.InteropServices/NFloat.xml | 2 +-
 xml/System/Double.xml                         | 2 +-
 xml/System/Half.xml                           | 2 +-
 xml/System/Single.xml                         | 2 +-
 6 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/xml/System.Numerics/Complex.xml b/xml/System.Numerics/Complex.xml
index bc371a2c303..5753ef8f85c 100644
--- a/xml/System.Numerics/Complex.xml
+++ b/xml/System.Numerics/Complex.xml
@@ -2292,8 +2292,6 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for a complex number `a + bi` where `a` is infinity, but not `b`, and does not return true for <xref:System.Numerics.Complex.Infinity>.
-
           ]]></format>
         </remarks>
         <inheritdoc cref="M:System.Numerics.INumberBase`1.IsRealNumber(`0)" />
diff --git a/xml/System.Numerics/INumberBase`1.xml b/xml/System.Numerics/INumberBase`1.xml
index 6eb41ac947d..35990eef2c4 100644
--- a/xml/System.Numerics/INumberBase`1.xml
+++ b/xml/System.Numerics/INumberBase`1.xml
@@ -782,7 +782,7 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for positive and negative infinity.
+This function checks values against the extended real number line, thus returns `true` for positive and negative infinity.
 
           ]]></format>
         </remarks>
diff --git a/xml/System.Runtime.InteropServices/NFloat.xml b/xml/System.Runtime.InteropServices/NFloat.xml
index 161b0cb0f50..f23f1721ab5 100644
--- a/xml/System.Runtime.InteropServices/NFloat.xml
+++ b/xml/System.Runtime.InteropServices/NFloat.xml
@@ -2414,7 +2414,7 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for <xref:System.Runtime.InteropServices.NFloat.PositiveInfinity> and <xref:System.Runtime.InteropServices.NFloat.NegativeInfinity>.
+This function checks values against the extended real number line, thus returns `true` for <xref:System.Runtime.InteropServices.NFloat.PositiveInfinity> and <xref:System.Runtime.InteropServices.NFloat.NegativeInfinity>.
 
           ]]></format>
         </remarks>
diff --git a/xml/System/Double.xml b/xml/System/Double.xml
index 9c7766bf024..fdb25300a76 100644
--- a/xml/System/Double.xml
+++ b/xml/System/Double.xml
@@ -3154,7 +3154,7 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for <xref:System.Double.PositiveInfinity> and <xref:System.Double.NegativeInfinity>.
+This function checks values against the extended real number line, thus returns `true` for <xref:System.Double.PositiveInfinity> and <xref:System.Double.NegativeInfinity>.
 
           ]]></format>
         </remarks>
diff --git a/xml/System/Half.xml b/xml/System/Half.xml
index 018a12801fa..0c8e47422b0 100644
--- a/xml/System/Half.xml
+++ b/xml/System/Half.xml
@@ -2360,7 +2360,7 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for <xref:System.Half.PositiveInfinity> and <xref:System.Half.NegativeInfinity>.
+This function checks values against the extended real number line, thus returns `true` for <xref:System.Half.PositiveInfinity> and <xref:System.Half.NegativeInfinity>.
 
           ]]></format>
         </remarks>
diff --git a/xml/System/Single.xml b/xml/System/Single.xml
index 8d73f7a1a64..46f5625efc2 100644
--- a/xml/System/Single.xml
+++ b/xml/System/Single.xml
@@ -3171,7 +3171,7 @@ A return value of `false` does not imply that <xref:System.Numerics.INumberBase%
 
 This function returns `true` for a complex number `a + bi` where `b` is zero.
 
-This function also returns `true` for <xref:System.Single.PositiveInfinity> and <xref:System.Single.NegativeInfinity>.
+This function checks values against the extended real number line, thus returns `true` for <xref:System.Single.PositiveInfinity> and <xref:System.Single.NegativeInfinity>.
 
           ]]></format>
         </remarks>