Use Path.Combine and Environment.NewLine in GetVersionInfo examples #11981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
@dotnet-policy-service agree |
gewarren
approved these changes
Oct 27, 2025
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Thanks - also the preceding line isn't needed.
snippets/csharp/System.Diagnostics/FileVersionInfo/Overview/source.cs
Outdated
Show resolved
Hide resolved
snippets/visualbasic/System.Diagnostics/FileVersionInfo/Overview/source.vb
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
Path.CombineandEnvironment.NewLineinGetVersionInfoexamples.Path.Combinewas already used in the first call, but not in the second. This fixes that for consistency to avoid naïve\\concatenation.This also uses
Environment.NewLineinstead of\nand the undefinedvbLfvariable.