Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated return value information for Marshal.GetExceptionForHR #2305

Merged
merged 4 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@rpetrusha
Copy link
Contributor

commented Apr 15, 2019

Updated return value information for Marshal.GetExceptionForHR

Fixes #1950

@mairaw

mairaw approved these changes Apr 30, 2019

Copy link
Contributor

left a comment

LGTM but left a comment for you to consider.

Show resolved Hide resolved xml/System.Runtime.InteropServices/Marshal.xml Outdated
Incorporated review suggestion.
Co-Authored-By: rpetrusha <ronpet@microsoft.com>
@mairaw
Copy link
Contributor

left a comment

There was an extra space and the same edit should be made to the other return value then.

Show resolved Hide resolved xml/System.Runtime.InteropServices/Marshal.xml Outdated
Show resolved Hide resolved xml/System.Runtime.InteropServices/Marshal.xml Outdated

mairaw and others added some commits May 2, 2019

Update xml/System.Runtime.InteropServices/Marshal.xml
Co-Authored-By: rpetrusha <ronpet@microsoft.com>
Update xml/System.Runtime.InteropServices/Marshal.xml
Co-Authored-By: rpetrusha <ronpet@microsoft.com>

@mairaw mairaw merged commit 118110a into dotnet:master May 13, 2019

6 checks passed

OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 15:39:56 PST
OpenPublishing.Build (2 of 3) Preparing completed at 15:56:49 PST
OpenPublishing.Build (3 of 3) Building completed at 16:26:06 PST
WIP Ready for review
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.