Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port System.Security.Claims source comments to Docs #2307

Merged
merged 2 commits into from May 1, 2019

Conversation

@carlossanlop
Copy link
Member

commented Apr 15, 2019

…tnet-api-docs

Summary

Automatically ported all source code triple slash comments found in System.Security.Claims to their dotnet-api-docs element if the comment didn't exist yet. Mostly exceptions.

Fixes #Issue_Number (if available)

@carlossanlop

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

@mairaw please take a look whenever you get a chance.
Adding System.Security owners @bartonjs, @GrabYourPitchforks in case they have any comments.

@carlossanlop
Copy link
Member Author

left a comment

Question for @mairaw:
In xml/System.Security.Claims/ClaimsIdentity.xml, there is an exception that calls "this". I used <see langword="this" />. Was this the correct element to represent that keyword?

@mairaw mairaw added this to the April 2019 milestone Apr 17, 2019

@mairaw

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Yes, that's good @carlossanlop. Let me review the rest now!

@mairaw mairaw added this to In progress in April 2019 via automation Apr 26, 2019

@rpetrusha
Copy link
Contributor

left a comment

Thanks for adding exception information, @carlossanlop. I've recommended some changes so that the exception conditions conform to our standard style.

Show resolved Hide resolved xml/System.Security.Claims/Claim.xml Outdated
Show resolved Hide resolved xml/System.Security.Claims/Claim.xml Outdated
Show resolved Hide resolved xml/System.Security.Claims/Claim.xml Outdated
Show resolved Hide resolved xml/System.Security.Claims/Claim.xml Outdated
Show resolved Hide resolved xml/System.Security.Claims/ClaimsIdentity.xml Outdated
Show resolved Hide resolved xml/System.Security.Claims/ClaimsIdentity.xml Outdated
Show resolved Hide resolved xml/System.Security.Claims/ClaimsPrincipal.xml Outdated
Apply suggestions from code review
Suggestions from rpetrusha

Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
@carlossanlop

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

I think this one also looks good! @rpetrusha

April 2019 automation moved this from In progress to In Review May 1, 2019

@rpetrusha

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Yes, this looks good, @carlossanlop. Thanks. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 052dc0e into dotnet:master May 1, 2019

6 checks passed

OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 12:32:34 PST
OpenPublishing.Build (2 of 3) Preparing completed at 12:47:24 PST
OpenPublishing.Build (3 of 3) Building completed at 13:16:49 PST
WIP Ready for review
Details
license/cla All CLA requirements met.
Details

April 2019 automation moved this from In Review to Done May 1, 2019

@carlossanlop carlossanlop deleted the carlossanlop:claims branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.