Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port triple slash comment from System.IO to Docs #2321

Merged
merged 2 commits into from May 2, 2019

Conversation

@carlossanlop
Copy link
Member

commented Apr 16, 2019

Summary

Automatically porting a comment found in System.IO.FileSystemInfo source code triple slash comments that did not exist in dotnet-api-docs. I also took the liberty to manually add a return value since it was missing as well.

Fixes #Issue_Number (if available)

@carlossanlop

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@mairaw @rpetrusha please take a look whenever possible.

Adding the area owner @JeremyKuhne in case he has any additional comments or suggestions.

@mairaw mairaw added this to the April 2019 milestone Apr 17, 2019

@rpetrusha
Copy link
Contributor

left a comment

Thanks for documenting the new member, @carlossanlop. I've left two suggested changes for you to consider.

Show resolved Hide resolved xml/System.IO/FileSystemInfo.xml Outdated
Show resolved Hide resolved xml/System.IO/FileSystemInfo.xml Outdated
Apply suggestions from code review
Suggestions from rpetrusha

Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>

@mairaw mairaw added this to In progress in April 2019 via automation Apr 27, 2019

April 2019 automation moved this from In progress to In Review May 2, 2019

@rpetrusha

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

Thanks, @carlossanlop. I'll merge now.

@rpetrusha rpetrusha merged commit 936cbb7 into dotnet:master May 2, 2019

6 checks passed

OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 12:39:50 PST
OpenPublishing.Build (2 of 3) Preparing completed at 12:55:03 PST
OpenPublishing.Build (3 of 3) Building completed at 13:32:29 PST
WIP Ready for review
Details
license/cla All CLA requirements met.

April 2019 automation moved this from In Review to Done May 2, 2019

@carlossanlop carlossanlop deleted the carlossanlop:systemio branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.