Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port exception found in System.Composition.Hosting source comments to… #2322

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
3 participants
@carlossanlop
Copy link
Member

commented Apr 16, 2019

… Docs

Summary

Automatically ported an exception found in the triple slash souce code comments in System.Composition.Hosting that was not found in dotnet-api-docs.

The exception summary was originally empty, so I found the root cause that would throw it in this function:
https://github.com/dotnet/corefx/blob/a6f76f4f620cbe74821c6445af3f13e048361658/src/System.Composition.Hosting/src/System/Composition/Hosting/Core/ExportDescriptorRegistry.cs#L51

Fixes #Issue_Number (if available)

@carlossanlop

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@mairaw @rpetrusha Please take a look whenever you get a chance.

Adding area owners @maryamariyan, @ViktorHofer in case they have any additional comments or suggestions about the description of this missing exception.

@rpetrusha
Copy link
Contributor

left a comment

Thanks for adding this exception, @carlossanlop. I've suggested a change so that it conform to our general pattern for exception conditions.

Show resolved Hide resolved xml/System.Composition.Hosting/CompositionHost.xml Outdated

@mairaw mairaw added this to the April 2019 milestone Apr 17, 2019

Update xml/System.Composition.Hosting/CompositionHost.xml
Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
@rpetrusha

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Thanks, @carlossanlop. I'll merge your PR now.

@rpetrusha rpetrusha merged commit c997cb2 into dotnet:master Apr 25, 2019

6 checks passed

OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 13:27:44 PST
OpenPublishing.Build (2 of 3) Preparing completed at 13:41:26 PST
OpenPublishing.Build (3 of 3) Building completed at 14:14:03 PST
WIP Ready for review
Details
license/cla All CLA requirements met.

@carlossanlop carlossanlop deleted the carlossanlop:compositionhosting branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.