From 404051d1418ddd228e81a7de48d68996edac9341 Mon Sep 17 00:00:00 2001
From: carlossanlop <calope@microsoft.com>
Date: Tue, 30 Jul 2019 16:59:07 -0700
Subject: [PATCH 1/3] Automatically port
 System.Text.Json.Serialization.JsonConverterAttribute

---
 .../JsonConverterAttribute.xml                | 28 +++++++++++++------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml b/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
index c4781a2bbb3..1108dfddebd 100644
--- a/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
+++ b/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
@@ -19,8 +19,20 @@
     </Attribute>
   </Attributes>
   <Docs>
-    <summary>To be added.</summary>
-    <remarks>To be added.</remarks>
+    <summary>When placed on a property or type, specifies the converter type to use.</summary>
+    <remarks>
+      <format type="text/markdown"><![CDATA[
+
+## Remarks
+
+The specified converter type must derive from <xref:System.Text.Json.Serialization.JsonConverter>.
+
+When placed on a property, the specified converter will always be used.
+
+When placed on a type, the specified converter will be used unless a compatible converter is added to <xref:System.Text.Json.JsonSerializerOptions.Converters> or there is another <xref:System.Text.Json.Serialization.JsonConverterAttribute> on a property of the same type.
+            
+          ]]></format>
+    </remarks>
   </Docs>
   <Members>
     <Member MemberName=".ctor">
@@ -36,7 +48,7 @@
       </AssemblyInfo>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Initializes a new instance of <see cref="T:System.Text.Json.Serialization.JsonConverterAttribute" />.</summary>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -56,8 +68,8 @@
         <Parameter Name="converterType" Type="System.Type" />
       </Parameters>
       <Docs>
-        <param name="converterType">To be added.</param>
-        <summary>To be added.</summary>
+        <param name="converterType">The type of the converter.</param>
+        <summary>Initializes a new instance of <see cref="T:System.Text.Json.Serialization.JsonConverterAttribute" /> with the specified converter type.</summary>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -77,7 +89,7 @@
         <ReturnType>System.Type</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>To be added.</summary>
+        <summary>The type of the converter to create, or <see langword="null" /> if <see cref="M:System.Text.Json.Serialization.JsonConverterAttribute.CreateConverter(System.Type)" /> should be used to obtain the converter.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
       </Docs>
@@ -102,8 +114,8 @@
       </Parameters>
       <Docs>
         <param name="typeToConvert">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>If overridden and <see cref="P:System.Text.Json.Serialization.JsonConverterAttribute.ConverterType" /> is <see langword="null" />, allows a custom attribute to create the converter in order to pass additional state.</summary>
+        <returns>The custom converter.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>

From 276c22251582af6297175a8dded2ebeca5505f2f Mon Sep 17 00:00:00 2001
From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Date: Thu, 1 Aug 2019 09:55:24 -0700
Subject: [PATCH 2/3] suggestions by rpetrusha and Jozkee

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: David Cantu <jozkyy@gmail.com>
---
 .../JsonConverterAttribute.xml                         | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml b/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
index 1108dfddebd..e310d420b54 100644
--- a/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
+++ b/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
@@ -29,7 +29,7 @@ The specified converter type must derive from <xref:System.Text.Json.Serializati
 
 When placed on a property, the specified converter will always be used.
 
-When placed on a type, the specified converter will be used unless a compatible converter is added to <xref:System.Text.Json.JsonSerializerOptions.Converters> or there is another <xref:System.Text.Json.Serialization.JsonConverterAttribute> on a property of the same type.
+When placed on a type, the specified converter will be used unless a compatible converter is added to the <xref:System.Text.Json.JsonSerializerOptions.Converters?displayProperty=nameWithType> collection or there is another <xref:System.Text.Json.Serialization.JsonConverterAttribute> on a property of the same type.
             
           ]]></format>
     </remarks>
@@ -89,8 +89,8 @@ When placed on a type, the specified converter will be used unless a compatible
         <ReturnType>System.Type</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>The type of the converter to create, or <see langword="null" /> if <see cref="M:System.Text.Json.Serialization.JsonConverterAttribute.CreateConverter(System.Type)" /> should be used to obtain the converter.</summary>
-        <value>To be added.</value>
+        <summary>Gets the type of the <see cref="T:System.Text.Json.Serialization.JsonConverterAttribute"/>, or <see langword="null" /> if it was created without a type.</summary>
+         <value>The type of the <see cref="T:System.Text.Json.Serialization.JsonConverterAttribute"/>, or <see langword="null" /> if it was created without a type.</value>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -114,10 +114,10 @@ When placed on a type, the specified converter will be used unless a compatible
       </Parameters>
       <Docs>
         <param name="typeToConvert">To be added.</param>
-        <summary>If overridden and <see cref="P:System.Text.Json.Serialization.JsonConverterAttribute.ConverterType" /> is <see langword="null" />, allows a custom attribute to create the converter in order to pass additional state.</summary>
+        <summary>When overridden in a derived class and <see cref="P:System.Text.Json.Serialization.JsonConverterAttribute.ConverterType" /> is <see langword="null" />, allows the derived class to create a <see cref="T:System.Text.Json.Serialization.JsonConverter"/> in order to pass additional state.</summary>
         <returns>The custom converter.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
   </Members>
-</Type>
\ No newline at end of file
+</Type>

From 9969d1c620dd604e610bcc340a443be8ef726692 Mon Sep 17 00:00:00 2001
From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Date: Thu, 1 Aug 2019 13:07:50 -0700
Subject: [PATCH 3/3] missing value

---
 xml/System.Text.Json.Serialization/JsonConverterAttribute.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml b/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
index e310d420b54..a9e0f6065b1 100644
--- a/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
+++ b/xml/System.Text.Json.Serialization/JsonConverterAttribute.xml
@@ -113,7 +113,7 @@ When placed on a type, the specified converter will be used unless a compatible
         <Parameter Name="typeToConvert" Type="System.Type" />
       </Parameters>
       <Docs>
-        <param name="typeToConvert">To be added.</param>
+        <param name="typeToConvert">The type of the converter.</param>
         <summary>When overridden in a derived class and <see cref="P:System.Text.Json.Serialization.JsonConverterAttribute.ConverterType" /> is <see langword="null" />, allows the derived class to create a <see cref="T:System.Text.Json.Serialization.JsonConverter"/> in order to pass additional state.</summary>
         <returns>The custom converter.</returns>
         <remarks>To be added.</remarks>