Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrinsics: Enclose instructions with param, move comments to remarks #3125

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@carlossanlop
Copy link
Member

commented Sep 5, 2019

This change has no ported triple slash comments.
Summaries have the special instructions enclosed by <param></para> to force adding an endline.
Descriptions at the end of the summaries were moved to the Remarks section.
No content changes, aside from a couple of extra sentence ending dots and spelling errors (intrinics -> intrinsic, or similar).

@mairaw
mairaw approved these changes Sep 5, 2019
Copy link
Contributor

left a comment

Great set of changes! Didn't review one by one but checked a few on review. Feel free to squash and merge when you're ready.

@mairaw mairaw added this to the September 2019 milestone Sep 5, 2019

@CarolEidt
Copy link
Member

left a comment

I also reviewed only a sampling, but it looks good.

@tannergooding
Copy link
Member

left a comment

Same. LGTM

@carlossanlop

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@mairaw @rpetrusha the build passed without warnings. If this looks good, can we please merge it?

@mairaw

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

I thought you had permissions. Merging now.

@mairaw mairaw merged commit 3e35e97 into dotnet:master Sep 6, 2019

6 checks passed

OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 10:47:08 PST
OpenPublishing.Build (2 of 3) Preparing completed at 11:02:29 PST
OpenPublishing.Build (3 of 3) Building completed at 11:30:52 PST
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.